aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2012-09-11 02:31:17 -0400
committerEric W. Biederman <ebiederm@xmission.com>2012-09-17 21:03:59 -0400
commitf95732e2e0a649c148be0242b72e3c7473092687 (patch)
tree3bcc942e4456bc95ac43ccdf619425aa24f00873 /kernel
parent02276bda4a2bf094fcde89fb5db4d9e86347ebf4 (diff)
audit: kill audit_prepare_user_tty
Now that netlink messages are processed in the context of the sender tty_audit_push_task can be called directly and audit_prepare_user_tty which only added looking up the task of the tty by process id is not needed. Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Eric Paris <eparis@redhat.com> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/audit.c20
1 files changed, 1 insertions, 19 deletions
diff --git a/kernel/audit.c b/kernel/audit.c
index fecb1507b48..58f704b432e 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -468,24 +468,6 @@ static int kauditd_thread(void *dummy)
468 return 0; 468 return 0;
469} 469}
470 470
471static int audit_prepare_user_tty(pid_t pid, uid_t loginuid, u32 sessionid)
472{
473 struct task_struct *tsk;
474 int err;
475
476 rcu_read_lock();
477 tsk = find_task_by_vpid(pid);
478 if (!tsk) {
479 rcu_read_unlock();
480 return -ESRCH;
481 }
482 get_task_struct(tsk);
483 rcu_read_unlock();
484 err = tty_audit_push_task(tsk, loginuid, sessionid);
485 put_task_struct(tsk);
486 return err;
487}
488
489int audit_send_list(void *_dest) 471int audit_send_list(void *_dest)
490{ 472{
491 struct audit_netlink_list *dest = _dest; 473 struct audit_netlink_list *dest = _dest;
@@ -748,7 +730,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
748 if (err == 1) { 730 if (err == 1) {
749 err = 0; 731 err = 0;
750 if (msg_type == AUDIT_USER_TTY) { 732 if (msg_type == AUDIT_USER_TTY) {
751 err = audit_prepare_user_tty(pid, loginuid, 733 err = tty_audit_push_task(current, loginuid,
752 sessionid); 734 sessionid);
753 if (err) 735 if (err)
754 break; 736 break;