diff options
author | Jeff Layton <jlayton@redhat.com> | 2012-10-10 15:25:21 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-10-12 00:32:00 -0400 |
commit | c43a25abba97c7d87131e71db6be24b24d7791a5 (patch) | |
tree | 0fe959853254064e17805ca111838e7869720e43 /kernel | |
parent | 9cec9d68ae53aae60b4a1fca4505c75a1d026392 (diff) |
audit: reverse arguments to audit_inode_child
Most of the callers get called with an inode and dentry in the reverse
order. The compiler then has to reshuffle the arg registers and/or
stack in order to pass them on to audit_inode_child.
Reverse those arguments for a micro-optimization.
Reported-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/auditsc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 2e481141b01..40743af02d8 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c | |||
@@ -2166,9 +2166,9 @@ out: | |||
2166 | } | 2166 | } |
2167 | 2167 | ||
2168 | /** | 2168 | /** |
2169 | * audit_inode_child - collect inode info for created/removed objects | 2169 | * __audit_inode_child - collect inode info for created/removed objects |
2170 | * @dentry: dentry being audited | ||
2171 | * @parent: inode of dentry parent | 2170 | * @parent: inode of dentry parent |
2171 | * @dentry: dentry being audited | ||
2172 | * | 2172 | * |
2173 | * For syscalls that create or remove filesystem objects, audit_inode | 2173 | * For syscalls that create or remove filesystem objects, audit_inode |
2174 | * can only collect information for the filesystem object's parent. | 2174 | * can only collect information for the filesystem object's parent. |
@@ -2178,8 +2178,8 @@ out: | |||
2178 | * must be hooked prior, in order to capture the target inode during | 2178 | * must be hooked prior, in order to capture the target inode during |
2179 | * unsuccessful attempts. | 2179 | * unsuccessful attempts. |
2180 | */ | 2180 | */ |
2181 | void __audit_inode_child(const struct dentry *dentry, | 2181 | void __audit_inode_child(const struct inode *parent, |
2182 | const struct inode *parent) | 2182 | const struct dentry *dentry) |
2183 | { | 2183 | { |
2184 | struct audit_context *context = current->audit_context; | 2184 | struct audit_context *context = current->audit_context; |
2185 | const char *found_parent = NULL, *found_child = NULL; | 2185 | const char *found_parent = NULL, *found_child = NULL; |