aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/trace
diff options
context:
space:
mode:
authorSteven Rostedt <srostedt@redhat.com>2011-03-09 10:41:56 -0500
committerSteven Rostedt <rostedt@goodmis.org>2011-03-10 10:31:48 -0500
commite6e1e2593592a8f6f6380496655d8c6f67431266 (patch)
tree00ef843b23fac5ab6be92725ce5b01487f555997 /kernel/trace
parentde29be5e712dc8b7eef2bef9417af3bb6a88e47a (diff)
tracing: Remove lock_depth from event entry
The lock_depth field in the event headers was added as a temporary data point for help in removing the BKL. Now that the BKL is pretty much been removed, we can remove this field. This in turn changes the header from 12 bytes to 8 bytes, removing the 4 byte buffer that gcc would insert if the first field in the data load was 8 bytes in size. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
-rw-r--r--kernel/trace/trace.c8
-rw-r--r--kernel/trace/trace_events.c1
-rw-r--r--kernel/trace/trace_output.c10
3 files changed, 5 insertions, 14 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 85e3ee1e474..fd6e1b906b3 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1101,7 +1101,6 @@ tracing_generic_entry_update(struct trace_entry *entry, unsigned long flags,
1101 1101
1102 entry->preempt_count = pc & 0xff; 1102 entry->preempt_count = pc & 0xff;
1103 entry->pid = (tsk) ? tsk->pid : 0; 1103 entry->pid = (tsk) ? tsk->pid : 0;
1104 entry->lock_depth = (tsk) ? tsk->lock_depth : 0;
1105 entry->flags = 1104 entry->flags =
1106#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT 1105#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT
1107 (irqs_disabled_flags(flags) ? TRACE_FLAG_IRQS_OFF : 0) | 1106 (irqs_disabled_flags(flags) ? TRACE_FLAG_IRQS_OFF : 0) |
@@ -1748,10 +1747,9 @@ static void print_lat_help_header(struct seq_file *m)
1748 seq_puts(m, "# | / _----=> need-resched \n"); 1747 seq_puts(m, "# | / _----=> need-resched \n");
1749 seq_puts(m, "# || / _---=> hardirq/softirq \n"); 1748 seq_puts(m, "# || / _---=> hardirq/softirq \n");
1750 seq_puts(m, "# ||| / _--=> preempt-depth \n"); 1749 seq_puts(m, "# ||| / _--=> preempt-depth \n");
1751 seq_puts(m, "# |||| /_--=> lock-depth \n"); 1750 seq_puts(m, "# |||| / delay \n");
1752 seq_puts(m, "# |||||/ delay \n"); 1751 seq_puts(m, "# cmd pid ||||| time | caller \n");
1753 seq_puts(m, "# cmd pid |||||| time | caller \n"); 1752 seq_puts(m, "# \\ / ||||| \\ | / \n");
1754 seq_puts(m, "# \\ / |||||| \\ | / \n");
1755} 1753}
1756 1754
1757static void print_func_help_header(struct seq_file *m) 1755static void print_func_help_header(struct seq_file *m)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 5f499e0438a..e1d579b1983 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -116,7 +116,6 @@ static int trace_define_common_fields(void)
116 __common_field(unsigned char, flags); 116 __common_field(unsigned char, flags);
117 __common_field(unsigned char, preempt_count); 117 __common_field(unsigned char, preempt_count);
118 __common_field(int, pid); 118 __common_field(int, pid);
119 __common_field(int, lock_depth);
120 119
121 return ret; 120 return ret;
122} 121}
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 02272baa220..151f32e5f2c 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -529,7 +529,7 @@ seq_print_ip_sym(struct trace_seq *s, unsigned long ip, unsigned long sym_flags)
529 * @entry: The trace entry field from the ring buffer 529 * @entry: The trace entry field from the ring buffer
530 * 530 *
531 * Prints the generic fields of irqs off, in hard or softirq, preempt 531 * Prints the generic fields of irqs off, in hard or softirq, preempt
532 * count and lock depth. 532 * count.
533 */ 533 */
534int trace_print_lat_fmt(struct trace_seq *s, struct trace_entry *entry) 534int trace_print_lat_fmt(struct trace_seq *s, struct trace_entry *entry)
535{ 535{
@@ -554,13 +554,7 @@ int trace_print_lat_fmt(struct trace_seq *s, struct trace_entry *entry)
554 else 554 else
555 ret = trace_seq_putc(s, '.'); 555 ret = trace_seq_putc(s, '.');
556 556
557 if (!ret) 557 return ret;
558 return 0;
559
560 if (entry->lock_depth < 0)
561 return trace_seq_putc(s, '.');
562
563 return trace_seq_printf(s, "%d", entry->lock_depth);
564} 558}
565 559
566static int 560static int