Audit: clean up the audit_watch split

No real changes, just cleanup to the audit_watch split patch which we done
with minimal code changes for easy review.  Now fix interfaces to make
things work better.

Signed-off-by: Eric Paris <eparis@redhat.com>

1 files changed, 15 insertions, 26 deletions

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index ce08041f578..ac87577f36b 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -71,6 +71,7 @@ static inline void audit_free_rule(struct audit_entry *e)
 {
         int i;
         struct audit_krule *erule = &e->rule;
+
         /* some rules don't have associated watches */
         if (erule->watch)
                 audit_put_watch(erule->watch);
@@ -746,8 +747,7 @@ static inline int audit_dupe_lsm_field(struct audit_field *df,
  * rule with the new rule in the filterlist, then free the old rule.
  * The rlist element is undefined; list manipulations are handled apart from
  * the initial copy. */
-struct audit_entry *audit_dupe_rule(struct audit_krule *old,
-                                    struct audit_watch *watch)
+struct audit_entry *audit_dupe_rule(struct audit_krule *old)
 {
         u32 fcount = old->field_count;
         struct audit_entry *entry;
@@ -769,8 +769,8 @@ struct audit_entry *audit_dupe_rule(struct audit_krule *old,
         new->prio = old->prio;
         new->buflen = old->buflen;
         new->inode_f = old->inode_f;
-        new->watch = NULL;
         new->field_count = old->field_count;
+
         /*
          * note that we are OK with not refcounting here; audit_match_tree()
          * never dereferences tree and we can't get false positives there
@@ -811,9 +811,9 @@ struct audit_entry *audit_dupe_rule(struct audit_krule *old,
                 }
         }
 
-        if (watch) {
-                audit_get_watch(watch);
-                new->watch = watch;
+        if (old->watch) {
+                audit_get_watch(old->watch);
+                new->watch = old->watch;
         }
 
         return entry;
@@ -866,7 +866,7 @@ static inline int audit_add_rule(struct audit_entry *entry)
         struct audit_watch *watch = entry->rule.watch;
         struct audit_tree *tree = entry->rule.tree;
         struct list_head *list;
-        int h, err;
+        int err;
 #ifdef CONFIG_AUDITSYSCALL
         int dont_count = 0;
 
@@ -889,15 +889,11 @@ static inline int audit_add_rule(struct audit_entry *entry)
 
         if (watch) {
                 /* audit_filter_mutex is dropped and re-taken during this call */
-                err = audit_add_watch(&entry->rule);
+                err = audit_add_watch(&entry->rule, &list);
                 if (err) {
                         mutex_unlock(&audit_filter_mutex);
                         goto error;
                 }
-                /* entry->rule.watch may have changed during audit_add_watch() */
-                watch = entry->rule.watch;
-                h = audit_hash_ino((u32)audit_watch_inode(watch));
-                list = &audit_inode_hash[h];
         }
         if (tree) {
                 err = audit_add_tree_rule(&entry->rule);
@@ -949,7 +945,7 @@ static inline int audit_del_rule(struct audit_entry *entry)
         struct audit_watch *watch = entry->rule.watch;
         struct audit_tree *tree = entry->rule.tree;
         struct list_head *list;
-        LIST_HEAD(inotify_list);
+        LIST_HEAD(inotify_unregister_list);
         int ret = 0;
 #ifdef CONFIG_AUDITSYSCALL
         int dont_count = 0;
@@ -969,7 +965,7 @@ static inline int audit_del_rule(struct audit_entry *entry)
         }
 
         if (e->rule.watch)
-                audit_remove_watch_rule(&e->rule, &inotify_list);
+                audit_remove_watch_rule(&e->rule, &inotify_unregister_list);
 
         if (e->rule.tree)
                 audit_remove_tree_rule(&e->rule);
@@ -987,8 +983,8 @@ static inline int audit_del_rule(struct audit_entry *entry)
 #endif
         mutex_unlock(&audit_filter_mutex);
 
-        if (!list_empty(&inotify_list))
-                audit_inotify_unregister(&inotify_list);
+        if (!list_empty(&inotify_unregister_list))
+                audit_watch_inotify_unregister(&inotify_unregister_list);
 
 out:
         if (watch)
@@ -1323,30 +1319,23 @@ static int update_lsm_rule(struct audit_krule *r)
 {
         struct audit_entry *entry = container_of(r, struct audit_entry, rule);
         struct audit_entry *nentry;
-        struct audit_watch *watch;
-        struct audit_tree *tree;
         int err = 0;
 
         if (!security_audit_rule_known(r))
                 return 0;
 
-        watch = r->watch;
-        tree = r->tree;
-        nentry = audit_dupe_rule(r, watch);
+        nentry = audit_dupe_rule(r);
         if (IS_ERR(nentry)) {
                 /* save the first error encountered for the
                  * return value */
                 err = PTR_ERR(nentry);
                 audit_panic("error updating LSM filters");
-                if (watch)
+                if (r->watch)
                         list_del(&r->rlist);
                 list_del_rcu(&entry->list);
                 list_del(&r->list);
         } else {
-                if (watch) {
-                        list_add(&nentry->rule.rlist, audit_watch_rules(watch));
-                        list_del(&r->rlist);
-                } else if (tree)
+                if (r->watch || r->tree)
                         list_replace_init(&r->rlist, &nentry->rule.rlist);
                 list_replace_rcu(&entry->list, &nentry->list);
                 list_replace(&r->list, &nentry->rule.list);