net: Make flowi ports AF dependent.

Create two sets of port member accessors, one set prefixed by fl4_*
and the other prefixed by fl6_*

This will let us to create AF optimal flow instances.

It will work because every context in which we access the ports,
we have to be fully aware of which AF the flowi is anyways.

Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 46 insertions, 36 deletions

diff --git a/include/net/flow.h b/include/net/flow.h
index 541ac13f245..f19f41d7daf 100644
--- a/include/net/flow.h
+++ b/include/net/flow.h
@@ -89,13 +89,20 @@ struct flowi {
 #define fl4_scope       flowi_scope
 
         union flowi_uli uli_u;
-#define fl_ip_sport     uli_u.ports.sport
-#define fl_ip_dport     uli_u.ports.dport
-#define fl_icmp_type    uli_u.icmpt.type
-#define fl_icmp_code    uli_u.icmpt.code
-#define fl_ipsec_spi    uli_u.spi
-#define fl_mh_type      uli_u.mht.type
-#define fl_gre_key      uli_u.gre_key
+#define fl4_sport       uli_u.ports.sport
+#define fl4_dport       uli_u.ports.dport
+#define fl4_icmp_type   uli_u.icmpt.type
+#define fl4_icmp_code   uli_u.icmpt.code
+#define fl4_ipsec_spi   uli_u.spi
+#define fl4_mh_type     uli_u.mht.type
+#define fl4_gre_key     uli_u.gre_key
+#define fl6_sport       uli_u.ports.sport
+#define fl6_dport       uli_u.ports.dport
+#define fl6_icmp_type   uli_u.icmpt.type
+#define fl6_icmp_code   uli_u.icmpt.code
+#define fl6_ipsec_spi   uli_u.spi
+#define fl6_mh_type     uli_u.mht.type
+#define fl6_gre_key     uli_u.gre_key
 } __attribute__((__aligned__(BITS_PER_LONG/8)));
 
 #define FLOW_DIR_IN     0
diff --git a/include/net/route.h b/include/net/route.h
index 3d814f84abd..4c207f9fe0c 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -157,8 +157,8 @@ static inline struct rtable *ip_route_output_ports(struct net *net, struct sock
                 .fl4_src = saddr,
                 .fl4_tos = tos,
                 .flowi_proto = proto,
-                .fl_ip_dport = dport,
-                .fl_ip_sport = sport,
+                .fl4_dport = dport,
+                .fl4_sport = sport,
         };
         if (sk)
                 security_sk_classify_flow(sk, &fl);
@@ -175,7 +175,7 @@ static inline struct rtable *ip_route_output_gre(struct net *net,
                 .fl4_src = saddr,
                 .fl4_tos = tos,
                 .flowi_proto = IPPROTO_GRE,
-                .fl_gre_key = gre_key,
+                .fl4_gre_key = gre_key,
         };
         return ip_route_output_key(net, &fl);
 }
@@ -228,14 +228,16 @@ static inline struct rtable *ip_route_connect(__be32 dst, __be32 src, u32 tos,
                                               __be16 sport, __be16 dport,
                                               struct sock *sk, bool can_sleep)
 {
-        struct flowi fl = { .flowi_oif = oif,
-                            .flowi_mark = sk->sk_mark,
-                            .fl4_dst = dst,
-                            .fl4_src = src,
-                            .fl4_tos = tos,
-                            .flowi_proto = protocol,
-                            .fl_ip_sport = sport,
-                            .fl_ip_dport = dport };
+        struct flowi fl = {
+                .flowi_oif = oif,
+                .flowi_mark = sk->sk_mark,
+                .fl4_dst = dst,
+                .fl4_src = src,
+                .fl4_tos = tos,
+                .flowi_proto = protocol,
+                .fl4_sport = sport,
+                .fl4_dport = dport,
+        };
         struct net *net = sock_net(sk);
         struct rtable *rt;
 
@@ -264,15 +266,16 @@ static inline struct rtable *ip_route_newports(struct rtable *rt,
                                                __be16 dport, struct sock *sk)
 {
         if (sport != orig_sport || dport != orig_dport) {
-                struct flowi fl = { .flowi_oif = rt->rt_oif,
-                                    .flowi_mark = rt->rt_mark,
-                                    .fl4_dst = rt->rt_key_dst,
-                                    .fl4_src = rt->rt_key_src,
-                                    .fl4_tos = rt->rt_tos,
-                                    .flowi_proto = protocol,
-                                    .fl_ip_sport = sport,
-                                    .fl_ip_dport = dport };
-
+                struct flowi fl = {
+                        .flowi_oif = rt->rt_oif,
+                        .flowi_mark = rt->rt_mark,
+                        .fl4_dst = rt->rt_key_dst,
+                        .fl4_src = rt->rt_key_src,
+                        .fl4_tos = rt->rt_tos,
+                        .flowi_proto = protocol,
+                        .fl4_sport = sport,
+                        .fl4_dport = dport
+                };
                 if (inet_sk(sk)->transparent)
                         fl.flowi_flags |= FLOWI_FLAG_ANYSRC;
                 if (protocol == IPPROTO_TCP)
diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index d5a12d10a0d..aa860add570 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -800,7 +800,7 @@ static inline bool addr_match(const void *token1, const void *token2,
 }
 
 static __inline__
-__be16 xfrm_flowi_sport(const struct flowi *fl)
+__be16 xfrm_flowi_sport(const struct flowi *fl, const union flowi_uli *uli)
 {
         __be16 port;
         switch(fl->flowi_proto) {
@@ -808,17 +808,17 @@ __be16 xfrm_flowi_sport(const struct flowi *fl)
         case IPPROTO_UDP:
         case IPPROTO_UDPLITE:
         case IPPROTO_SCTP:
-                port = fl->fl_ip_sport;
+                port = uli->ports.sport;
                 break;
         case IPPROTO_ICMP:
         case IPPROTO_ICMPV6:
-                port = htons(fl->fl_icmp_type);
+                port = htons(uli->icmpt.type);
                 break;
         case IPPROTO_MH:
-                port = htons(fl->fl_mh_type);
+                port = htons(uli->mht.type);
                 break;
         case IPPROTO_GRE:
-                port = htons(ntohl(fl->fl_gre_key) >> 16);
+                port = htons(ntohl(uli->gre_key) >> 16);
                 break;
         default:
                 port = 0;       /*XXX*/
@@ -827,7 +827,7 @@ __be16 xfrm_flowi_sport(const struct flowi *fl)
 }
 
 static __inline__
-__be16 xfrm_flowi_dport(const struct flowi *fl)
+__be16 xfrm_flowi_dport(const struct flowi *fl, const union flowi_uli *uli)
 {
         __be16 port;
         switch(fl->flowi_proto) {
@@ -835,14 +835,14 @@ __be16 xfrm_flowi_dport(const struct flowi *fl)
         case IPPROTO_UDP:
         case IPPROTO_UDPLITE:
         case IPPROTO_SCTP:
-                port = fl->fl_ip_dport;
+                port = uli->ports.dport;
                 break;
         case IPPROTO_ICMP:
         case IPPROTO_ICMPV6:
-                port = htons(fl->fl_icmp_code);
+                port = htons(uli->icmpt.code);
                 break;
         case IPPROTO_GRE:
-                port = htons(ntohl(fl->fl_gre_key) & 0xffff);
+                port = htons(ntohl(uli->gre_key) & 0xffff);
                 break;
         default:
                 port = 0;       /*XXX*/