Merge tag 'xceiv-for-v3.4' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next

USB: transceiver changes for 3.4

Here we have a big rework done by Heikki Krogerus (thanks) which
splits OTG functionality away from transceivers.

We have known for quite a long time that struct otg_transceiver was
a bad name for the structure, considering transceiver is far from
being OTG-specific (see 4e67185).

4 files changed, 99 insertions, 77 deletions

diff --git a/include/linux/usb/intel_mid_otg.h b/include/linux/usb/intel_mid_otg.h
index a0ccf795f36..756cf5543ff 100644
--- a/include/linux/usb/intel_mid_otg.h
+++ b/include/linux/usb/intel_mid_otg.h
@@ -104,11 +104,11 @@ struct iotg_ulpi_access_ops {
 /*
  * the Intel MID (Langwell/Penwell) otg transceiver driver needs to interact
  * with device and host drivers to implement the USB OTG related feature. More
- * function members are added based on otg_transceiver data structure for this
+ * function members are added based on usb_phy data structure for this
  * purpose.
  */
 struct intel_mid_otg_xceiv {
-        struct otg_transceiver  otg;
+        struct usb_phy          otg;
         struct otg_hsm          hsm;
 
         /* base address */
@@ -147,7 +147,7 @@ struct intel_mid_otg_xceiv {
 
 };
 static inline
-struct intel_mid_otg_xceiv *otg_to_mid_xceiv(struct otg_transceiver *otg)
+struct intel_mid_otg_xceiv *otg_to_mid_xceiv(struct usb_phy *otg)
 {
         return container_of(otg, struct intel_mid_otg_xceiv, otg);
 }
diff --git a/include/linux/usb/msm_hsusb.h b/include/linux/usb/msm_hsusb.h
index 00311fe9d0d..22a396c13f3 100644
--- a/include/linux/usb/msm_hsusb.h
+++ b/include/linux/usb/msm_hsusb.h
@@ -160,7 +160,7 @@ struct msm_otg_platform_data {
  *               detection process.
  */
 struct msm_otg {
-        struct otg_transceiver otg;
+        struct usb_phy phy;
         struct msm_otg_platform_data *pdata;
         int irq;
         struct clk *clk;
diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
index d87f44f5b04..f67810f8f21 100644
--- a/include/linux/usb/otg.h
+++ b/include/linux/usb/otg.h
@@ -35,7 +35,7 @@ enum usb_otg_state {
         OTG_STATE_A_VBUS_ERR,
 };
 
-enum usb_xceiv_events {
+enum usb_phy_events {
         USB_EVENT_NONE,         /* no events or cable disconnected */
         USB_EVENT_VBUS,         /* vbus valid event */
         USB_EVENT_ID,           /* id was grounded */
@@ -43,14 +43,39 @@ enum usb_xceiv_events {
         USB_EVENT_ENUMERATED,   /* gadget driver enumerated */
 };
 
-struct otg_transceiver;
+struct usb_phy;
 
 /* for transceivers connected thru an ULPI interface, the user must
  * provide access ops
  */
-struct otg_io_access_ops {
-        int (*read)(struct otg_transceiver *otg, u32 reg);
-        int (*write)(struct otg_transceiver *otg, u32 val, u32 reg);
+struct usb_phy_io_ops {
+        int (*read)(struct usb_phy *x, u32 reg);
+        int (*write)(struct usb_phy *x, u32 val, u32 reg);
+};
+
+struct usb_otg {
+        u8                      default_a;
+
+        struct usb_phy          *phy;
+        struct usb_bus          *host;
+        struct usb_gadget       *gadget;
+
+        /* bind/unbind the host controller */
+        int     (*set_host)(struct usb_otg *otg, struct usb_bus *host);
+
+        /* bind/unbind the peripheral controller */
+        int     (*set_peripheral)(struct usb_otg *otg,
+                                        struct usb_gadget *gadget);
+
+        /* effective for A-peripheral, ignored for B devices */
+        int     (*set_vbus)(struct usb_otg *otg, bool enabled);
+
+        /* for B devices only:  start session with A-Host */
+        int     (*start_srp)(struct usb_otg *otg);
+
+        /* start or continue HNP role switch */
+        int     (*start_hnp)(struct usb_otg *otg);
+
 };
 
 /*
@@ -59,22 +84,20 @@ struct otg_io_access_ops {
  * moment, using the transceiver, ID signal, HNP and sometimes static
  * configuration information (including "board isn't wired for otg").
  */
-struct otg_transceiver {
+struct usb_phy {
         struct device           *dev;
         const char              *label;
         unsigned int             flags;
 
-        u8                      default_a;
         enum usb_otg_state      state;
-        enum usb_xceiv_events   last_event;
+        enum usb_phy_events     last_event;
 
-        struct usb_bus          *host;
-        struct usb_gadget       *gadget;
+        struct usb_otg          *otg;
 
-        struct otg_io_access_ops        *io_ops;
-        void __iomem                    *io_priv;
+        struct usb_phy_io_ops   *io_ops;
+        void __iomem            *io_priv;
 
-        /* for notification of usb_xceiv_events */
+        /* for notification of usb_phy_events */
         struct atomic_notifier_head     notifier;
 
         /* to pass extra port status to the root hub */
@@ -82,40 +105,22 @@ struct otg_transceiver {
         u16                     port_change;
 
         /* initialize/shutdown the OTG controller */
-        int     (*init)(struct otg_transceiver *otg);
-        void    (*shutdown)(struct otg_transceiver *otg);
-
-        /* bind/unbind the host controller */
-        int     (*set_host)(struct otg_transceiver *otg,
-                                struct usb_bus *host);
-
-        /* bind/unbind the peripheral controller */
-        int     (*set_peripheral)(struct otg_transceiver *otg,
-                                struct usb_gadget *gadget);
+        int     (*init)(struct usb_phy *x);
+        void    (*shutdown)(struct usb_phy *x);
 
         /* effective for B devices, ignored for A-peripheral */
-        int     (*set_power)(struct otg_transceiver *otg,
+        int     (*set_power)(struct usb_phy *x,
                                 unsigned mA);
 
-        /* effective for A-peripheral, ignored for B devices */
-        int     (*set_vbus)(struct otg_transceiver *otg,
-                                bool enabled);
-
         /* for non-OTG B devices: set transceiver into suspend mode */
-        int     (*set_suspend)(struct otg_transceiver *otg,
+        int     (*set_suspend)(struct usb_phy *x,
                                 int suspend);
 
-        /* for B devices only:  start session with A-Host */
-        int     (*start_srp)(struct otg_transceiver *otg);
-
-        /* start or continue HNP role switch */
-        int     (*start_hnp)(struct otg_transceiver *otg);
-
 };
 
 
 /* for board-specific init logic */
-extern int otg_set_transceiver(struct otg_transceiver *);
+extern int usb_set_transceiver(struct usb_phy *);
 
 #if defined(CONFIG_NOP_USB_XCEIV) || (defined(CONFIG_NOP_USB_XCEIV_MODULE) && defined(MODULE))
 /* sometimes transceivers are accessed only through e.g. ULPI */
@@ -132,50 +137,50 @@ static inline void usb_nop_xceiv_unregister(void)
 #endif
 
 /* helpers for direct access thru low-level io interface */
-static inline int otg_io_read(struct otg_transceiver *otg, u32 reg)
+static inline int usb_phy_io_read(struct usb_phy *x, u32 reg)
 {
-        if (otg->io_ops && otg->io_ops->read)
-                return otg->io_ops->read(otg, reg);
+        if (x->io_ops && x->io_ops->read)
+                return x->io_ops->read(x, reg);
 
         return -EINVAL;
 }
 
-static inline int otg_io_write(struct otg_transceiver *otg, u32 val, u32 reg)
+static inline int usb_phy_io_write(struct usb_phy *x, u32 val, u32 reg)
 {
-        if (otg->io_ops && otg->io_ops->write)
-                return otg->io_ops->write(otg, val, reg);
+        if (x->io_ops && x->io_ops->write)
+                return x->io_ops->write(x, val, reg);
 
         return -EINVAL;
 }
 
 static inline int
-otg_init(struct otg_transceiver *otg)
+usb_phy_init(struct usb_phy *x)
 {
-        if (otg->init)
-                return otg->init(otg);
+        if (x->init)
+                return x->init(x);
 
         return 0;
 }
 
 static inline void
-otg_shutdown(struct otg_transceiver *otg)
+usb_phy_shutdown(struct usb_phy *x)
 {
-        if (otg->shutdown)
-                otg->shutdown(otg);
+        if (x->shutdown)
+                x->shutdown(x);
 }
 
 /* for usb host and peripheral controller drivers */
 #ifdef CONFIG_USB_OTG_UTILS
-extern struct otg_transceiver *otg_get_transceiver(void);
-extern void otg_put_transceiver(struct otg_transceiver *);
+extern struct usb_phy *usb_get_transceiver(void);
+extern void usb_put_transceiver(struct usb_phy *);
 extern const char *otg_state_string(enum usb_otg_state state);
 #else
-static inline struct otg_transceiver *otg_get_transceiver(void)
+static inline struct usb_phy *usb_get_transceiver(void)
 {
         return NULL;
 }
 
-static inline void otg_put_transceiver(struct otg_transceiver *x)
+static inline void usb_put_transceiver(struct usb_phy *x)
 {
 }
 
@@ -187,67 +192,84 @@ static inline const char *otg_state_string(enum usb_otg_state state)
 
 /* Context: can sleep */
 static inline int
-otg_start_hnp(struct otg_transceiver *otg)
+otg_start_hnp(struct usb_otg *otg)
 {
-        return otg->start_hnp(otg);
+        if (otg && otg->start_hnp)
+                return otg->start_hnp(otg);
+
+        return -ENOTSUPP;
 }
 
 /* Context: can sleep */
 static inline int
-otg_set_vbus(struct otg_transceiver *otg, bool enabled)
+otg_set_vbus(struct usb_otg *otg, bool enabled)
 {
-        return otg->set_vbus(otg, enabled);
+        if (otg && otg->set_vbus)
+                return otg->set_vbus(otg, enabled);
+
+        return -ENOTSUPP;
 }
 
 /* for HCDs */
 static inline int
-otg_set_host(struct otg_transceiver *otg, struct usb_bus *host)
+otg_set_host(struct usb_otg *otg, struct usb_bus *host)
 {
-        return otg->set_host(otg, host);
+        if (otg && otg->set_host)
+                return otg->set_host(otg, host);
+
+        return -ENOTSUPP;
 }
 
 /* for usb peripheral controller drivers */
 
 /* Context: can sleep */
 static inline int
-otg_set_peripheral(struct otg_transceiver *otg, struct usb_gadget *periph)
+otg_set_peripheral(struct usb_otg *otg, struct usb_gadget *periph)
 {
-        return otg->set_peripheral(otg, periph);
+        if (otg && otg->set_peripheral)
+                return otg->set_peripheral(otg, periph);
+
+        return -ENOTSUPP;
 }
 
 static inline int
-otg_set_power(struct otg_transceiver *otg, unsigned mA)
+usb_phy_set_power(struct usb_phy *x, unsigned mA)
 {
-        return otg->set_power(otg, mA);
+        if (x && x->set_power)
+                return x->set_power(x, mA);
+        return 0;
 }
 
 /* Context: can sleep */
 static inline int
-otg_set_suspend(struct otg_transceiver *otg, int suspend)
+usb_phy_set_suspend(struct usb_phy *x, int suspend)
 {
-        if (otg->set_suspend != NULL)
-                return otg->set_suspend(otg, suspend);
+        if (x->set_suspend != NULL)
+                return x->set_suspend(x, suspend);
         else
                 return 0;
 }
 
 static inline int
-otg_start_srp(struct otg_transceiver *otg)
+otg_start_srp(struct usb_otg *otg)
 {
-        return otg->start_srp(otg);
+        if (otg && otg->start_srp)
+                return otg->start_srp(otg);
+
+        return -ENOTSUPP;
 }
 
 /* notifiers */
 static inline int
-otg_register_notifier(struct otg_transceiver *otg, struct notifier_block *nb)
+usb_register_notifier(struct usb_phy *x, struct notifier_block *nb)
 {
-        return atomic_notifier_chain_register(&otg->notifier, nb);
+        return atomic_notifier_chain_register(&x->notifier, nb);
 }
 
 static inline void
-otg_unregister_notifier(struct otg_transceiver *otg, struct notifier_block *nb)
+usb_unregister_notifier(struct usb_phy *x, struct notifier_block *nb)
 {
-        atomic_notifier_chain_unregister(&otg->notifier, nb);
+        atomic_notifier_chain_unregister(&x->notifier, nb);
 }
 
 /* for OTG controller drivers (and maybe other stuff) */
diff --git a/include/linux/usb/ulpi.h b/include/linux/usb/ulpi.h
index 9595796d62e..6f033a415ec 100644
--- a/include/linux/usb/ulpi.h
+++ b/include/linux/usb/ulpi.h
@@ -181,12 +181,12 @@
 
 /*-------------------------------------------------------------------------*/
 
-struct otg_transceiver *otg_ulpi_create(struct otg_io_access_ops *ops,
+struct usb_phy *otg_ulpi_create(struct usb_phy_io_ops *ops,
                                         unsigned int flags);
 
 #ifdef CONFIG_USB_ULPI_VIEWPORT
 /* access ops for controllers with a viewport register */
-extern struct otg_io_access_ops ulpi_viewport_access_ops;
+extern struct usb_phy_io_ops ulpi_viewport_access_ops;
 #endif
 
 #endif /* __LINUX_USB_ULPI_H */