aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/fs.h
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2011-06-24 14:29:47 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2011-07-20 20:47:49 -0400
commitaacfc19c626ebd3daa675652457d71019a1f583f (patch)
tree9c1cfb5945e939f1ba56b4c0101c211e84e544c0 /include/linux/fs.h
parentdf2d6f26586f12a24f3ae5df4e236dc5c08d6eb4 (diff)
fs: simplify the blockdev_direct_IO prototype
Simple filesystems always pass inode->i_sb_bdev as the block device argument, and never need a end_io handler. Let's simply things for them and for my grepping activity by dropping these arguments. The only thing not falling into that scheme is ext4, which passes and end_io handler without needing special flags (yet), but given how messy the direct I/O code there is use of __blockdev_direct_IO in one instead of two out of three cases isn't going to make a large difference anyway. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'include/linux/fs.h')
-rw-r--r--include/linux/fs.h9
1 files changed, 4 insertions, 5 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 2fe920774ab..824453be9fe 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2418,12 +2418,11 @@ ssize_t __blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode,
2418 dio_submit_t submit_io, int flags); 2418 dio_submit_t submit_io, int flags);
2419 2419
2420static inline ssize_t blockdev_direct_IO(int rw, struct kiocb *iocb, 2420static inline ssize_t blockdev_direct_IO(int rw, struct kiocb *iocb,
2421 struct inode *inode, struct block_device *bdev, const struct iovec *iov, 2421 struct inode *inode, const struct iovec *iov, loff_t offset,
2422 loff_t offset, unsigned long nr_segs, get_block_t get_block, 2422 unsigned long nr_segs, get_block_t get_block)
2423 dio_iodone_t end_io)
2424{ 2423{
2425 return __blockdev_direct_IO(rw, iocb, inode, bdev, iov, offset, 2424 return __blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov,
2426 nr_segs, get_block, end_io, NULL, 2425 offset, nr_segs, get_block, NULL, NULL,
2427 DIO_LOCKING | DIO_SKIP_HOLES); 2426 DIO_LOCKING | DIO_SKIP_HOLES);
2428} 2427}
2429#endif 2428#endif