diff options
author | Jan Kara <jack@suse.cz> | 2012-01-11 13:52:10 -0500 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2012-01-25 12:01:31 -0500 |
commit | 9b025eb3a89e041bab6698e3858706be2385d692 (patch) | |
tree | acb29c488c3f538c2041e279b701b0965cd9667b /fs | |
parent | dcd6c92267155e70a94b3927bce681ce74b80d1f (diff) |
xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink()
Commit b52a360b forgot to call xfs_iunlock() when it detected corrupted
symplink and bailed out. Fix it by jumping to 'out' instead of doing return.
CC: stable@kernel.org
CC: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Alex Elder <elder@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/xfs/xfs_vnodeops.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index 0cf52da9d24..ebdb88840a4 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c | |||
@@ -131,7 +131,8 @@ xfs_readlink( | |||
131 | __func__, (unsigned long long) ip->i_ino, | 131 | __func__, (unsigned long long) ip->i_ino, |
132 | (long long) pathlen); | 132 | (long long) pathlen); |
133 | ASSERT(0); | 133 | ASSERT(0); |
134 | return XFS_ERROR(EFSCORRUPTED); | 134 | error = XFS_ERROR(EFSCORRUPTED); |
135 | goto out; | ||
135 | } | 136 | } |
136 | 137 | ||
137 | 138 | ||