aboutsummaryrefslogtreecommitdiffstats
path: root/fs/sysfs/dir.c
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2011-10-12 18:01:34 -0400
committerDavid S. Miller <davem@davemloft.net>2011-10-19 19:24:15 -0400
commit23396180a9770df2c6a694bbb689c12bdf792f94 (patch)
treea943f113f6532b04fcef1673113493cf44ac2365 /fs/sysfs/dir.c
parent4c22400ab64d434a00ecbe0c655a16956c902aa8 (diff)
sysfs: Remove support for tagged directories with untagged members.
Now that /sys/class/net/bonding_masters is implemented as a tagged sysfs file we can remove support for untagged files in tagged directories. This change removes any ambiguity of what a NULL namespace value means. A NULL namespace parameter after this patch means that we are talking about an untagged sysfs dirent. This makes the sysfs code much less prone to mistakes when during maintenance. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/sysfs/dir.c')
-rw-r--r--fs/sysfs/dir.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index ea9120a830d..352d26d98c0 100644
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@ -543,7 +543,7 @@ struct sysfs_dirent *sysfs_find_dirent(struct sysfs_dirent *parent_sd,
543 struct sysfs_dirent *sd; 543 struct sysfs_dirent *sd;
544 544
545 for (sd = parent_sd->s_dir.children; sd; sd = sd->s_sibling) { 545 for (sd = parent_sd->s_dir.children; sd; sd = sd->s_sibling) {
546 if (ns && sd->s_ns && (sd->s_ns != ns)) 546 if (sd->s_ns != ns)
547 continue; 547 continue;
548 if (!strcmp(sd->s_name, name)) 548 if (!strcmp(sd->s_name, name))
549 return sd; 549 return sd;
@@ -885,7 +885,7 @@ static struct sysfs_dirent *sysfs_dir_pos(const void *ns,
885 while (pos && (ino > pos->s_ino)) 885 while (pos && (ino > pos->s_ino))
886 pos = pos->s_sibling; 886 pos = pos->s_sibling;
887 } 887 }
888 while (pos && pos->s_ns && pos->s_ns != ns) 888 while (pos && pos->s_ns != ns)
889 pos = pos->s_sibling; 889 pos = pos->s_sibling;
890 return pos; 890 return pos;
891} 891}
@@ -896,7 +896,7 @@ static struct sysfs_dirent *sysfs_dir_next_pos(const void *ns,
896 pos = sysfs_dir_pos(ns, parent_sd, ino, pos); 896 pos = sysfs_dir_pos(ns, parent_sd, ino, pos);
897 if (pos) 897 if (pos)
898 pos = pos->s_sibling; 898 pos = pos->s_sibling;
899 while (pos && pos->s_ns && pos->s_ns != ns) 899 while (pos && pos->s_ns != ns)
900 pos = pos->s_sibling; 900 pos = pos->s_sibling;
901 return pos; 901 return pos;
902} 902}