make d_splice_alias(ERR_PTR(err), dentry) = ERR_PTR(err)

... and simplify the living hell out of callers

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

1 files changed, 0 insertions, 5 deletions

diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c
index 51b36958492..0682b38d7e3 100644
--- a/fs/squashfs/namei.c
+++ b/fs/squashfs/namei.c
@@ -220,11 +220,6 @@ static struct dentry *squashfs_lookup(struct inode *dir, struct dentry *dentry,
                                         blk, off, ino_num);
 
                                 inode = squashfs_iget(dir->i_sb, ino, ino_num);
-                                if (IS_ERR(inode)) {
-                                        err = PTR_ERR(inode);
-                                        goto failed;
-                                }
-
                                 goto exit_lookup;
                         }
                 }