diff options
author | Chen Gong <gong.chen@linux.intel.com> | 2011-05-16 13:58:57 -0400 |
---|---|---|
committer | Tony Luck <tony.luck@intel.com> | 2011-05-16 14:04:51 -0400 |
commit | 8d38d74b648513dd8ed8bd2b67d899208ef4e09e (patch) | |
tree | 9746a4273b2ffb68a298ce038eb196f0f65452bb /fs/pstore/platform.c | |
parent | 693d92a1bbc9e42681c42ed190bd42b636ca876f (diff) |
pstore: fix one type of return value in pstore
the return type of function _read_ in pstore is size_t,
but in the callback function of _read_, the logic doesn't
consider it too much, which means if negative value (assuming
error here) is returned, it will be converted to positive because
of type casting. ssize_t is enough for this function.
Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'fs/pstore/platform.c')
-rw-r--r-- | fs/pstore/platform.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index f835a25625f..912403c2a93 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c | |||
@@ -152,7 +152,7 @@ EXPORT_SYMBOL_GPL(pstore_register); | |||
152 | void pstore_get_records(void) | 152 | void pstore_get_records(void) |
153 | { | 153 | { |
154 | struct pstore_info *psi = psinfo; | 154 | struct pstore_info *psi = psinfo; |
155 | size_t size; | 155 | ssize_t size; |
156 | u64 id; | 156 | u64 id; |
157 | enum pstore_type_id type; | 157 | enum pstore_type_id type; |
158 | struct timespec time; | 158 | struct timespec time; |
@@ -163,7 +163,7 @@ void pstore_get_records(void) | |||
163 | 163 | ||
164 | mutex_lock(&psinfo->buf_mutex); | 164 | mutex_lock(&psinfo->buf_mutex); |
165 | while ((size = psi->read(&id, &type, &time)) > 0) { | 165 | while ((size = psi->read(&id, &type, &time)) > 0) { |
166 | if (pstore_mkfile(type, psi->name, id, psi->buf, size, | 166 | if (pstore_mkfile(type, psi->name, id, psi->buf, (size_t)size, |
167 | time, psi->erase)) | 167 | time, psi->erase)) |
168 | failed++; | 168 | failed++; |
169 | } | 169 | } |