aboutsummaryrefslogtreecommitdiffstats
path: root/fs/hfsplus/bitmap.c
diff options
context:
space:
mode:
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>2012-07-12 10:26:31 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2012-07-22 15:58:04 -0400
commit9e6c5829b07c9ba6668807631914efc557fab059 (patch)
tree4355c4b76869cf7fba0b2a60066e649e12e7fcc8 /fs/hfsplus/bitmap.c
parent58770d7e83eede5fafbcdf54a604277d70010705 (diff)
hfsplus: get rid of write_super
This patch makes hfsplus stop using the VFS '->write_super()' method along with the 's_dirt' superblock flag, because they are on their way out. The whole "superblock write-out" VFS infrastructure is served by the 'sync_supers()' kernel thread, which wakes up every 5 (by default) seconds and writes out all dirty superblocks using the '->write_super()' call-back. But the problem with this thread is that it wastes power by waking up the system every 5 seconds, even if there are no diry superblocks, or there are no client file-systems which would need this (e.g., btrfs does not use '->write_super()'). So we want to kill it completely and thus, we need to make file-systems to stop using the '->write_super()' VFS service, and then remove it together with the kernel thread. Tested using fsstress from the LTP project. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/hfsplus/bitmap.c')
-rw-r--r--fs/hfsplus/bitmap.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/hfsplus/bitmap.c b/fs/hfsplus/bitmap.c
index 1cad80c789c..4cfbe2edd29 100644
--- a/fs/hfsplus/bitmap.c
+++ b/fs/hfsplus/bitmap.c
@@ -153,7 +153,7 @@ done:
153 kunmap(page); 153 kunmap(page);
154 *max = offset + (curr - pptr) * 32 + i - start; 154 *max = offset + (curr - pptr) * 32 + i - start;
155 sbi->free_blocks -= *max; 155 sbi->free_blocks -= *max;
156 sb->s_dirt = 1; 156 hfsplus_mark_mdb_dirty(sb);
157 dprint(DBG_BITMAP, "-> %u,%u\n", start, *max); 157 dprint(DBG_BITMAP, "-> %u,%u\n", start, *max);
158out: 158out:
159 mutex_unlock(&sbi->alloc_mutex); 159 mutex_unlock(&sbi->alloc_mutex);
@@ -228,7 +228,7 @@ out:
228 set_page_dirty(page); 228 set_page_dirty(page);
229 kunmap(page); 229 kunmap(page);
230 sbi->free_blocks += len; 230 sbi->free_blocks += len;
231 sb->s_dirt = 1; 231 hfsplus_mark_mdb_dirty(sb);
232 mutex_unlock(&sbi->alloc_mutex); 232 mutex_unlock(&sbi->alloc_mutex);
233 233
234 return 0; 234 return 0;