diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2011-06-20 11:31:30 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-07-20 01:43:16 -0400 |
commit | 178ea73521d64ba41d7aa5488fb9f549c6d4507d (patch) | |
tree | 7fb6bfb6483577752e307a5bb2e3905658d44294 /fs/gfs2 | |
parent | 07b8ce1ee87d291ff564c02cf878fae973317a52 (diff) |
kill check_acl callback of generic_permission()
its value depends only on inode and does not change; we might as
well store it in ->i_op->check_acl and be done with that.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/gfs2')
-rw-r--r-- | fs/gfs2/inode.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 03e0c529063..d5f0f4ea25d 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -1564,7 +1564,7 @@ int gfs2_permission(struct inode *inode, int mask, unsigned int flags) | |||
1564 | if ((mask & MAY_WRITE) && IS_IMMUTABLE(inode)) | 1564 | if ((mask & MAY_WRITE) && IS_IMMUTABLE(inode)) |
1565 | error = -EACCES; | 1565 | error = -EACCES; |
1566 | else | 1566 | else |
1567 | error = generic_permission(inode, mask, flags, gfs2_check_acl); | 1567 | error = generic_permission(inode, mask, flags); |
1568 | if (unlock) | 1568 | if (unlock) |
1569 | gfs2_glock_dq_uninit(&i_gh); | 1569 | gfs2_glock_dq_uninit(&i_gh); |
1570 | 1570 | ||
@@ -1854,6 +1854,7 @@ const struct inode_operations gfs2_file_iops = { | |||
1854 | .listxattr = gfs2_listxattr, | 1854 | .listxattr = gfs2_listxattr, |
1855 | .removexattr = gfs2_removexattr, | 1855 | .removexattr = gfs2_removexattr, |
1856 | .fiemap = gfs2_fiemap, | 1856 | .fiemap = gfs2_fiemap, |
1857 | .check_acl = gfs2_check_acl, | ||
1857 | }; | 1858 | }; |
1858 | 1859 | ||
1859 | const struct inode_operations gfs2_dir_iops = { | 1860 | const struct inode_operations gfs2_dir_iops = { |
@@ -1874,6 +1875,7 @@ const struct inode_operations gfs2_dir_iops = { | |||
1874 | .listxattr = gfs2_listxattr, | 1875 | .listxattr = gfs2_listxattr, |
1875 | .removexattr = gfs2_removexattr, | 1876 | .removexattr = gfs2_removexattr, |
1876 | .fiemap = gfs2_fiemap, | 1877 | .fiemap = gfs2_fiemap, |
1878 | .check_acl = gfs2_check_acl, | ||
1877 | }; | 1879 | }; |
1878 | 1880 | ||
1879 | const struct inode_operations gfs2_symlink_iops = { | 1881 | const struct inode_operations gfs2_symlink_iops = { |
@@ -1888,5 +1890,6 @@ const struct inode_operations gfs2_symlink_iops = { | |||
1888 | .listxattr = gfs2_listxattr, | 1890 | .listxattr = gfs2_listxattr, |
1889 | .removexattr = gfs2_removexattr, | 1891 | .removexattr = gfs2_removexattr, |
1890 | .fiemap = gfs2_fiemap, | 1892 | .fiemap = gfs2_fiemap, |
1893 | .check_acl = gfs2_check_acl, | ||
1891 | }; | 1894 | }; |
1892 | 1895 | ||