diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2009-05-06 10:43:07 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:08 -0400 |
commit | bbd6851a3213a525128473e978b692ab6ac11aba (patch) | |
tree | 8ebddebadd8992871ab98456187cb00849a82058 /fs/ext3 | |
parent | 6cfd0148425e528b859b26e436b01f23f6926224 (diff) |
Push lock_super() into the ->remount_fs() of filesystems that care about it
Note that since we can't run into contention between remount_fs and write_super
(due to exclusion on s_umount), we have to care only about filesystems that
touch lock_super() on their own. Out of those ext3, ext4, hpfs, sysv and ufs
do need it; fat doesn't since its ->remount_fs() only accesses assign-once
data (basically, it's "we have no atime on directories and only have atime on
files for vfat; force nodiratime and possibly noatime into *flags").
[folded a build fix from hch]
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ext3')
-rw-r--r-- | fs/ext3/super.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 546b8d732bf..e213a2613a5 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -2491,6 +2491,7 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) | |||
2491 | #endif | 2491 | #endif |
2492 | 2492 | ||
2493 | /* Store the original options */ | 2493 | /* Store the original options */ |
2494 | lock_super(sb); | ||
2494 | old_sb_flags = sb->s_flags; | 2495 | old_sb_flags = sb->s_flags; |
2495 | old_opts.s_mount_opt = sbi->s_mount_opt; | 2496 | old_opts.s_mount_opt = sbi->s_mount_opt; |
2496 | old_opts.s_resuid = sbi->s_resuid; | 2497 | old_opts.s_resuid = sbi->s_resuid; |
@@ -2598,6 +2599,7 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) | |||
2598 | old_opts.s_qf_names[i] != sbi->s_qf_names[i]) | 2599 | old_opts.s_qf_names[i] != sbi->s_qf_names[i]) |
2599 | kfree(old_opts.s_qf_names[i]); | 2600 | kfree(old_opts.s_qf_names[i]); |
2600 | #endif | 2601 | #endif |
2602 | unlock_super(sb); | ||
2601 | return 0; | 2603 | return 0; |
2602 | restore_opts: | 2604 | restore_opts: |
2603 | sb->s_flags = old_sb_flags; | 2605 | sb->s_flags = old_sb_flags; |
@@ -2614,6 +2616,7 @@ restore_opts: | |||
2614 | sbi->s_qf_names[i] = old_opts.s_qf_names[i]; | 2616 | sbi->s_qf_names[i] = old_opts.s_qf_names[i]; |
2615 | } | 2617 | } |
2616 | #endif | 2618 | #endif |
2619 | unlock_super(sb); | ||
2617 | return err; | 2620 | return err; |
2618 | } | 2621 | } |
2619 | 2622 | ||