aboutsummaryrefslogtreecommitdiffstats
path: root/fs/cifs/connect.c
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2011-01-11 07:24:02 -0500
committerSteve French <sfrench@us.ibm.com>2011-01-19 12:52:38 -0500
commit8097531a5cb55c6472118da094dc88caf9be66ac (patch)
tree77707f0bc5fe63e08844426ffe878a0191f4faef /fs/cifs/connect.c
parentc5797a945cac4c470f0113fc839c521aab0d799d (diff)
cifs: clean up accesses to midCount
It's an atomic_t and the code accesses the "counter" field in it directly instead of using atomic_read(). It also is sometimes accessed under a spinlock and sometimes not. Move it out of the spinlock since we don't need belt-and-suspenders for something that's just informational. Reviewed-by: Suresh Jayaraman <sjayaraman@suse.de> Reviewed-by: Pavel Shilovsky <piastryyy@gmail.com> Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/connect.c')
-rw-r--r--fs/cifs/connect.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 75b538f50b1..465ecad6d7c 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -628,7 +628,7 @@ multi_t2_fnd:
628 } else if (!is_valid_oplock_break(smb_buffer, server) && 628 } else if (!is_valid_oplock_break(smb_buffer, server) &&
629 !isMultiRsp) { 629 !isMultiRsp) {
630 cERROR(1, "No task to wake, unknown frame received! " 630 cERROR(1, "No task to wake, unknown frame received! "
631 "NumMids %d", midCount.counter); 631 "NumMids %d", atomic_read(&midCount));
632 cifs_dump_mem("Received Data is: ", (char *)smb_buffer, 632 cifs_dump_mem("Received Data is: ", (char *)smb_buffer,
633 sizeof(struct smb_hdr)); 633 sizeof(struct smb_hdr));
634#ifdef CONFIG_CIFS_DEBUG2 634#ifdef CONFIG_CIFS_DEBUG2