diff options
author | Kirill A. Shutemov <kirill.shutemov@linux.intel.com> | 2012-09-25 21:33:07 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-10-02 21:35:55 -0400 |
commit | 8c0a85377048b64c880e76ec7368904fe46d0b94 (patch) | |
tree | 12e075f4159e88b09a89e35866017f82f80bcc7d /fs/ceph | |
parent | 99621b44aa194eab594e1f17217231c02b519211 (diff) |
fs: push rcu_barrier() from deactivate_locked_super() to filesystems
There's no reason to call rcu_barrier() on every
deactivate_locked_super(). We only need to make sure that all delayed rcu
free inodes are flushed before we destroy related cache.
Removing rcu_barrier() from deactivate_locked_super() affects some fast
paths. E.g. on my machine exit_group() of a last process in IPC
namespace takes 0.07538s. rcu_barrier() takes 0.05188s of that time.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ceph')
-rw-r--r-- | fs/ceph/super.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index b982239f38f..3a42d932637 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c | |||
@@ -603,6 +603,11 @@ bad_cap: | |||
603 | 603 | ||
604 | static void destroy_caches(void) | 604 | static void destroy_caches(void) |
605 | { | 605 | { |
606 | /* | ||
607 | * Make sure all delayed rcu free inodes are flushed before we | ||
608 | * destroy cache. | ||
609 | */ | ||
610 | rcu_barrier(); | ||
606 | kmem_cache_destroy(ceph_inode_cachep); | 611 | kmem_cache_destroy(ceph_inode_cachep); |
607 | kmem_cache_destroy(ceph_cap_cachep); | 612 | kmem_cache_destroy(ceph_cap_cachep); |
608 | kmem_cache_destroy(ceph_dentry_cachep); | 613 | kmem_cache_destroy(ceph_dentry_cachep); |