aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/file-item.c
diff options
context:
space:
mode:
authorJeff Mahoney <jeffm@suse.com>2012-03-01 08:56:26 -0500
committerDavid Sterba <dsterba@suse.cz>2012-03-21 20:45:34 -0400
commit143bede527b054a271053f41bfaca2b57baa9408 (patch)
tree95c71d3705c73bf98e7a1547da35e70a44703c1e /fs/btrfs/file-item.c
parentffd7b33944f4573a063af7a55f8a5199c8185665 (diff)
btrfs: return void in functions without error conditions
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Diffstat (limited to 'fs/btrfs/file-item.c')
-rw-r--r--fs/btrfs/file-item.c25
1 files changed, 10 insertions, 15 deletions
diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c
index c7fb3a4247d..edb69b4d533 100644
--- a/fs/btrfs/file-item.c
+++ b/fs/btrfs/file-item.c
@@ -483,18 +483,17 @@ int btrfs_csum_one_bio(struct btrfs_root *root, struct inode *inode,
483 * This calls btrfs_truncate_item with the correct args based on the 483 * This calls btrfs_truncate_item with the correct args based on the
484 * overlap, and fixes up the key as required. 484 * overlap, and fixes up the key as required.
485 */ 485 */
486static noinline int truncate_one_csum(struct btrfs_trans_handle *trans, 486static noinline void truncate_one_csum(struct btrfs_trans_handle *trans,
487 struct btrfs_root *root, 487 struct btrfs_root *root,
488 struct btrfs_path *path, 488 struct btrfs_path *path,
489 struct btrfs_key *key, 489 struct btrfs_key *key,
490 u64 bytenr, u64 len) 490 u64 bytenr, u64 len)
491{ 491{
492 struct extent_buffer *leaf; 492 struct extent_buffer *leaf;
493 u16 csum_size = btrfs_super_csum_size(root->fs_info->super_copy); 493 u16 csum_size = btrfs_super_csum_size(root->fs_info->super_copy);
494 u64 csum_end; 494 u64 csum_end;
495 u64 end_byte = bytenr + len; 495 u64 end_byte = bytenr + len;
496 u32 blocksize_bits = root->fs_info->sb->s_blocksize_bits; 496 u32 blocksize_bits = root->fs_info->sb->s_blocksize_bits;
497 int ret;
498 497
499 leaf = path->nodes[0]; 498 leaf = path->nodes[0];
500 csum_end = btrfs_item_size_nr(leaf, path->slots[0]) / csum_size; 499 csum_end = btrfs_item_size_nr(leaf, path->slots[0]) / csum_size;
@@ -510,7 +509,7 @@ static noinline int truncate_one_csum(struct btrfs_trans_handle *trans,
510 */ 509 */
511 u32 new_size = (bytenr - key->offset) >> blocksize_bits; 510 u32 new_size = (bytenr - key->offset) >> blocksize_bits;
512 new_size *= csum_size; 511 new_size *= csum_size;
513 ret = btrfs_truncate_item(trans, root, path, new_size, 1); 512 btrfs_truncate_item(trans, root, path, new_size, 1);
514 } else if (key->offset >= bytenr && csum_end > end_byte && 513 } else if (key->offset >= bytenr && csum_end > end_byte &&
515 end_byte > key->offset) { 514 end_byte > key->offset) {
516 /* 515 /*
@@ -522,15 +521,13 @@ static noinline int truncate_one_csum(struct btrfs_trans_handle *trans,
522 u32 new_size = (csum_end - end_byte) >> blocksize_bits; 521 u32 new_size = (csum_end - end_byte) >> blocksize_bits;
523 new_size *= csum_size; 522 new_size *= csum_size;
524 523
525 ret = btrfs_truncate_item(trans, root, path, new_size, 0); 524 btrfs_truncate_item(trans, root, path, new_size, 0);
526 525
527 key->offset = end_byte; 526 key->offset = end_byte;
528 ret = btrfs_set_item_key_safe(trans, root, path, key); 527 btrfs_set_item_key_safe(trans, root, path, key);
529 BUG_ON(ret);
530 } else { 528 } else {
531 BUG(); 529 BUG();
532 } 530 }
533 return 0;
534} 531}
535 532
536/* 533/*
@@ -639,9 +636,7 @@ int btrfs_del_csums(struct btrfs_trans_handle *trans,
639 636
640 key.offset = end_byte - 1; 637 key.offset = end_byte - 1;
641 } else { 638 } else {
642 ret = truncate_one_csum(trans, root, path, 639 truncate_one_csum(trans, root, path, &key, bytenr, len);
643 &key, bytenr, len);
644 BUG_ON(ret);
645 if (key.offset < bytenr) 640 if (key.offset < bytenr)
646 break; 641 break;
647 } 642 }
@@ -772,7 +767,7 @@ again:
772 if (diff != csum_size) 767 if (diff != csum_size)
773 goto insert; 768 goto insert;
774 769
775 ret = btrfs_extend_item(trans, root, path, diff); 770 btrfs_extend_item(trans, root, path, diff);
776 goto csum; 771 goto csum;
777 } 772 }
778 773