aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorReinette Chatre <reinette.chatre@intel.com>2009-08-28 12:58:50 -0400
committerJohn W. Linville <linville@tuxdriver.com>2009-08-31 14:42:11 -0400
commitaf472a953ef23d6b9fe717486974d7caff3fa194 (patch)
tree673e36ca11f071406c62de64b96f02d60c2f1a0c /drivers
parentb57d46aa0db87b6349737e7b110ebe48ee14c143 (diff)
iwl3945: reduce debug noise when default debug flags used
Significant literature suggests users use debug flags 0x43fff - this causes the debug flags to be set that causes information to be printed for every received frame - including beacons. In the best case it fills up the logs, at worst it slows driver down and causes failures due to timeouts. In the RX handler, print debugging only if user requested RX debugging. Signed-off-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/wireless/iwlwifi/iwl3945-base.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 34790413ead..2238c9f2018 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -1373,7 +1373,7 @@ static void iwl3945_rx_handle(struct iwl_priv *priv)
1373 fill_rx = 1; 1373 fill_rx = 1;
1374 /* Rx interrupt, but nothing sent from uCode */ 1374 /* Rx interrupt, but nothing sent from uCode */
1375 if (i == r) 1375 if (i == r)
1376 IWL_DEBUG(priv, IWL_DL_RX | IWL_DL_ISR, "r = %d, i = %d\n", r, i); 1376 IWL_DEBUG_RX(priv, "r = %d, i = %d\n", r, i);
1377 1377
1378 while (i != r) { 1378 while (i != r) {
1379 rxb = rxq->queue[i]; 1379 rxb = rxq->queue[i];
@@ -1404,15 +1404,13 @@ static void iwl3945_rx_handle(struct iwl_priv *priv)
1404 * handle those that need handling via function in 1404 * handle those that need handling via function in
1405 * rx_handlers table. See iwl3945_setup_rx_handlers() */ 1405 * rx_handlers table. See iwl3945_setup_rx_handlers() */
1406 if (priv->rx_handlers[pkt->hdr.cmd]) { 1406 if (priv->rx_handlers[pkt->hdr.cmd]) {
1407 IWL_DEBUG(priv, IWL_DL_HCMD | IWL_DL_RX | IWL_DL_ISR, 1407 IWL_DEBUG_RX(priv, "r = %d, i = %d, %s, 0x%02x\n", r, i,
1408 "r = %d, i = %d, %s, 0x%02x\n", r, i,
1409 get_cmd_string(pkt->hdr.cmd), pkt->hdr.cmd); 1408 get_cmd_string(pkt->hdr.cmd), pkt->hdr.cmd);
1410 priv->rx_handlers[pkt->hdr.cmd] (priv, rxb); 1409 priv->rx_handlers[pkt->hdr.cmd] (priv, rxb);
1411 priv->isr_stats.rx_handlers[pkt->hdr.cmd]++; 1410 priv->isr_stats.rx_handlers[pkt->hdr.cmd]++;
1412 } else { 1411 } else {
1413 /* No handling needed */ 1412 /* No handling needed */
1414 IWL_DEBUG(priv, IWL_DL_HCMD | IWL_DL_RX | IWL_DL_ISR, 1413 IWL_DEBUG_RX(priv, "r %d i %d No handler needed for %s, 0x%02x\n",
1415 "r %d i %d No handler needed for %s, 0x%02x\n",
1416 r, i, get_cmd_string(pkt->hdr.cmd), 1414 r, i, get_cmd_string(pkt->hdr.cmd),
1417 pkt->hdr.cmd); 1415 pkt->hdr.cmd);
1418 } 1416 }