aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorH Hartley Sweeten <hartleys@visionengravers.com>2012-07-18 21:49:03 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-07-19 19:32:56 -0400
commit6d2d7ef7315cb40549baec7bb13dccfcf5162225 (patch)
tree4c125948f0b642afdebce4cfeca7a206bcd99c3e /drivers
parent6191a3ff59ed91ed3efd7a4a5fcad0368c199f28 (diff)
staging: comedi: cb_pcimdas: remove BADR0 from the private data
The pci resource bar 0 address is only used as a "flag" to let the datach function know that the pci device has been enabled. Use dev->iobase in the detach instead and remove BADR0 from the private data. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/staging/comedi/drivers/cb_pcimdas.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/staging/comedi/drivers/cb_pcimdas.c b/drivers/staging/comedi/drivers/cb_pcimdas.c
index 4312e9b6db0..ce08533fa04 100644
--- a/drivers/staging/comedi/drivers/cb_pcimdas.c
+++ b/drivers/staging/comedi/drivers/cb_pcimdas.c
@@ -56,7 +56,6 @@ See http://www.mccdaq.com/PDFs/Manuals/pcim-das1602-16.pdf for more details.
56/* Registers for the PCIM-DAS1602/16 */ 56/* Registers for the PCIM-DAS1602/16 */
57 57
58/* sizes of io regions (bytes) */ 58/* sizes of io regions (bytes) */
59#define BADR0_SIZE 2 /* ?? */
60#define BADR3_SIZE 16 59#define BADR3_SIZE 16
61 60
62/* DAC Offsets */ 61/* DAC Offsets */
@@ -135,7 +134,6 @@ struct cb_pcimdas_private {
135 struct pci_dev *pci_dev; 134 struct pci_dev *pci_dev;
136 135
137 /* base addresses */ 136 /* base addresses */
138 unsigned long BADR0;
139 unsigned long BADR3; 137 unsigned long BADR3;
140 138
141 /* Used for AO readback */ 139 /* Used for AO readback */
@@ -230,7 +228,6 @@ static int cb_pcimdas_attach(struct comedi_device *dev,
230 return -EIO; 228 return -EIO;
231 } 229 }
232 230
233 devpriv->BADR0 = pci_resource_start(devpriv->pci_dev, 0);
234 dev->iobase = pci_resource_start(devpriv->pci_dev, 2); 231 dev->iobase = pci_resource_start(devpriv->pci_dev, 2);
235 devpriv->BADR3 = pci_resource_start(devpriv->pci_dev, 3); 232 devpriv->BADR3 = pci_resource_start(devpriv->pci_dev, 3);
236 iobase_8255 = pci_resource_start(devpriv->pci_dev, 4); 233 iobase_8255 = pci_resource_start(devpriv->pci_dev, 4);
@@ -290,7 +287,7 @@ static void cb_pcimdas_detach(struct comedi_device *dev)
290 free_irq(dev->irq, dev); 287 free_irq(dev->irq, dev);
291 if (devpriv) { 288 if (devpriv) {
292 if (devpriv->pci_dev) { 289 if (devpriv->pci_dev) {
293 if (devpriv->BADR0) 290 if (dev->iobase)
294 comedi_pci_disable(devpriv->pci_dev); 291 comedi_pci_disable(devpriv->pci_dev);
295 pci_dev_put(devpriv->pci_dev); 292 pci_dev_put(devpriv->pci_dev);
296 } 293 }