diff options
author | Henrik Kretzschmar <henne@nachtwindheim.de> | 2010-05-24 17:33:59 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-25 11:07:08 -0400 |
commit | ad1458464cbbe6935be6e20d70920301733158af (patch) | |
tree | 3c1581f3554c1ce9d17de3b6171c15aac9441b82 /drivers/video | |
parent | 3cc04971661e37e7de6fbf9808ede554b5e1cb4e (diff) |
fbdev: section cleanup in vga16fb
Fix up the sections in the vga16fb driver, by moving:
* the variables vga16_defined and vga16fb
from .init.data to .devinit.data
* vga16fb_setup() from .text to .init.text
* vga16fb_remove() from .text. to .devexit.text
This fixes the following warnings issued by modpost:
WARNING: drivers/video/built-in.o(.devinit.text+0x1a420): Section mismatch in re
ference from the function vga16fb_probe() to the (unknown reference) .init.data:
(unknown)
The function __devinit vga16fb_probe() references
a (unknown reference) __initdata (unknown).
If (unknown) is only used by vga16fb_probe then
annotate (unknown) with a matching annotation.
WARNING: drivers/video/built-in.o(.devinit.text+0x1a437): Section mismatch in reference from the function vga16fb_probe() to the variable .init.data:vga16fb_defined
The function __devinit vga16fb_probe() references
a variable __initdata vga16fb_defined.
If vga16fb_defined is only used by vga16fb_probe then
annotate vga16fb_defined with a matching annotation.
WARNING: drivers/video/built-in.o(.devinit.text+0x1a457): Section mismatch in reference from the function vga16fb_probe() to the variable .init.data:vga16fb_fix
The function __devinit vga16fb_probe() references
a variable __initdata vga16fb_fix.
If vga16fb_fix is only used by vga16fb_probe then
annotate vga16fb_fix with a matching annotation.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: <stable@kernel.org> [if "platform-drivers: move probe to .devinit.text in drivers/video" was merged]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/vga16fb.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c index 149c47ac7e9..28ccab44a39 100644 --- a/drivers/video/vga16fb.c +++ b/drivers/video/vga16fb.c | |||
@@ -65,7 +65,7 @@ struct vga16fb_par { | |||
65 | 65 | ||
66 | /* --------------------------------------------------------------------- */ | 66 | /* --------------------------------------------------------------------- */ |
67 | 67 | ||
68 | static struct fb_var_screeninfo vga16fb_defined __initdata = { | 68 | static struct fb_var_screeninfo vga16fb_defined __devinitdata = { |
69 | .xres = 640, | 69 | .xres = 640, |
70 | .yres = 480, | 70 | .yres = 480, |
71 | .xres_virtual = 640, | 71 | .xres_virtual = 640, |
@@ -85,7 +85,7 @@ static struct fb_var_screeninfo vga16fb_defined __initdata = { | |||
85 | }; | 85 | }; |
86 | 86 | ||
87 | /* name should not depend on EGA/VGA */ | 87 | /* name should not depend on EGA/VGA */ |
88 | static struct fb_fix_screeninfo vga16fb_fix __initdata = { | 88 | static struct fb_fix_screeninfo vga16fb_fix __devinitdata = { |
89 | .id = "VGA16 VGA", | 89 | .id = "VGA16 VGA", |
90 | .smem_start = VGA_FB_PHYS, | 90 | .smem_start = VGA_FB_PHYS, |
91 | .smem_len = VGA_FB_PHYS_LEN, | 91 | .smem_len = VGA_FB_PHYS_LEN, |
@@ -1287,7 +1287,7 @@ static struct fb_ops vga16fb_ops = { | |||
1287 | }; | 1287 | }; |
1288 | 1288 | ||
1289 | #ifndef MODULE | 1289 | #ifndef MODULE |
1290 | static int vga16fb_setup(char *options) | 1290 | static int __init vga16fb_setup(char *options) |
1291 | { | 1291 | { |
1292 | char *this_opt; | 1292 | char *this_opt; |
1293 | 1293 | ||
@@ -1393,7 +1393,7 @@ static int __devinit vga16fb_probe(struct platform_device *dev) | |||
1393 | return ret; | 1393 | return ret; |
1394 | } | 1394 | } |
1395 | 1395 | ||
1396 | static int vga16fb_remove(struct platform_device *dev) | 1396 | static int __devexit vga16fb_remove(struct platform_device *dev) |
1397 | { | 1397 | { |
1398 | struct fb_info *info = platform_get_drvdata(dev); | 1398 | struct fb_info *info = platform_get_drvdata(dev); |
1399 | 1399 | ||
@@ -1405,7 +1405,7 @@ static int vga16fb_remove(struct platform_device *dev) | |||
1405 | 1405 | ||
1406 | static struct platform_driver vga16fb_driver = { | 1406 | static struct platform_driver vga16fb_driver = { |
1407 | .probe = vga16fb_probe, | 1407 | .probe = vga16fb_probe, |
1408 | .remove = vga16fb_remove, | 1408 | .remove = __devexit_p(vga16fb_remove), |
1409 | .driver = { | 1409 | .driver = { |
1410 | .name = "vga16fb", | 1410 | .name = "vga16fb", |
1411 | }, | 1411 | }, |