diff options
author | Julia Lawall <julia@diku.dk> | 2010-07-20 18:22:44 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-08-02 15:42:59 -0400 |
commit | 5c79b496a713dac1a706845bdd047aae15421ef5 (patch) | |
tree | 10bf7fa2f02b37342350b26334a18d4a110223b8 /drivers/video | |
parent | febe2ea10e041c014b295a0321f7ec62c05b7e3f (diff) |
V4L/DVB: drivers/video/omap2/displays: add missing mutex_unlock
Add a mutex_unlock missing on the error paths. The use of the mutex is
balanced elsewhere in the file.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression E1;
@@
* mutex_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* mutex_unlock(E1,...);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Mike Isely <isely@pobox.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/video')
-rw-r--r-- | drivers/video/omap2/displays/panel-acx565akm.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c index 1f8eb70e293..07fbb8a733b 100644 --- a/drivers/video/omap2/displays/panel-acx565akm.c +++ b/drivers/video/omap2/displays/panel-acx565akm.c | |||
@@ -592,7 +592,7 @@ static int acx_panel_power_on(struct omap_dss_device *dssdev) | |||
592 | r = omapdss_sdi_display_enable(dssdev); | 592 | r = omapdss_sdi_display_enable(dssdev); |
593 | if (r) { | 593 | if (r) { |
594 | pr_err("%s sdi enable failed\n", __func__); | 594 | pr_err("%s sdi enable failed\n", __func__); |
595 | return r; | 595 | goto fail_unlock; |
596 | } | 596 | } |
597 | 597 | ||
598 | /*FIXME tweak me */ | 598 | /*FIXME tweak me */ |
@@ -633,6 +633,8 @@ static int acx_panel_power_on(struct omap_dss_device *dssdev) | |||
633 | return acx565akm_bl_update_status(md->bl_dev); | 633 | return acx565akm_bl_update_status(md->bl_dev); |
634 | fail: | 634 | fail: |
635 | omapdss_sdi_display_disable(dssdev); | 635 | omapdss_sdi_display_disable(dssdev); |
636 | fail_unlock: | ||
637 | mutex_unlock(&md->mutex); | ||
636 | return r; | 638 | return r; |
637 | } | 639 | } |
638 | 640 | ||