aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@ti.com>2012-05-10 04:15:14 -0400
committerTomi Valkeinen <tomi.valkeinen@ti.com>2012-05-11 07:44:27 -0400
commit3a028bb99d1f1e5c444060a176cbd4bf93530df3 (patch)
tree198ca5954a9dd59e005c871374fffac355f7e6ab /drivers/video
parentb3e68d306519cc96ff5ad2957d133997f91bb53e (diff)
OMAPFB: fix parsing of vram parameter
omapfb_parse_vram_param()'s check for end pointer returned from simple_strtoul() is wrong, causing the code to bug if the second or later vram parameters are non-parseable, for example "omapfb.vram=0:2M,:5M". However, even in that case the code will most likely bail out with -EINVAL in the following checks, so the bug is probably not a fatal one. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reported-by: Hein Tibosch <hein_tibosch@yahoo.es>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/omap2/omapfb/omapfb-main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index b00db4068d2..7f02e7f90d6 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -1502,7 +1502,7 @@ static int omapfb_parse_vram_param(const char *param, int max_entries,
1502 1502
1503 fbnum = simple_strtoul(p, &p, 10); 1503 fbnum = simple_strtoul(p, &p, 10);
1504 1504
1505 if (p == param) 1505 if (p == start)
1506 return -EINVAL; 1506 return -EINVAL;
1507 1507
1508 if (*p != ':') 1508 if (*p != ':')