diff options
author | Felipe Balbi <balbi@ti.com> | 2011-11-15 02:53:37 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 13:20:53 -0500 |
commit | d762ad4792fcdec4d58c5385097083116e47337d (patch) | |
tree | 0b53f21a48feea29c5e4f3408231290cc6bd26ba /drivers/usb/storage | |
parent | e2c83f019a2abe48f5faf2fe631e8502adcc70ea (diff) |
usb: storagE: realtek_cr: fix sparse warnings
Fix the following sparse warnings:
| drivers/usb/storage/realtek_cr.c:821:6: warning: symbol
| 'rts51x_invoke_transport' was not declared. Should
| it be static?
|
| drivers/usb/storage/realtek_cr.c:980:5: warning: symbol
| 'realtek_cr_suspend' was not declared. Should it
| be static?
|
| drivers/usb/storage/realtek_cr.c:518:23: warning: cast
| truncates bits from constant value (fe47 becomes 47)
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/storage')
-rw-r--r-- | drivers/usb/storage/realtek_cr.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 0ce5f79197e..30f64bfe101 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c | |||
@@ -507,15 +507,14 @@ static int enable_oscillator(struct us_data *us) | |||
507 | static int __do_config_autodelink(struct us_data *us, u8 *data, u16 len) | 507 | static int __do_config_autodelink(struct us_data *us, u8 *data, u16 len) |
508 | { | 508 | { |
509 | int retval; | 509 | int retval; |
510 | u16 addr = 0xFE47; | ||
511 | u8 cmnd[12] = {0}; | 510 | u8 cmnd[12] = {0}; |
512 | 511 | ||
513 | US_DEBUGP("%s, addr = 0x%x, len = %d\n", __FUNCTION__, addr, len); | 512 | US_DEBUGP("%s, addr = 0xfe47, len = %d\n", __FUNCTION__, len); |
514 | 513 | ||
515 | cmnd[0] = 0xF0; | 514 | cmnd[0] = 0xF0; |
516 | cmnd[1] = 0x0E; | 515 | cmnd[1] = 0x0E; |
517 | cmnd[2] = (u8)(addr >> 8); | 516 | cmnd[2] = 0xfe; |
518 | cmnd[3] = (u8)addr; | 517 | cmnd[3] = 0x47; |
519 | cmnd[4] = (u8)(len >> 8); | 518 | cmnd[4] = (u8)(len >> 8); |
520 | cmnd[5] = (u8)len; | 519 | cmnd[5] = (u8)len; |
521 | 520 | ||
@@ -818,7 +817,7 @@ static inline int working_scsi(struct scsi_cmnd *srb) | |||
818 | return 1; | 817 | return 1; |
819 | } | 818 | } |
820 | 819 | ||
821 | void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us) | 820 | static void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us) |
822 | { | 821 | { |
823 | struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra); | 822 | struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra); |
824 | static int card_first_show = 1; | 823 | static int card_first_show = 1; |
@@ -977,7 +976,7 @@ static void realtek_cr_destructor(void *extra) | |||
977 | } | 976 | } |
978 | 977 | ||
979 | #ifdef CONFIG_PM | 978 | #ifdef CONFIG_PM |
980 | int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message) | 979 | static int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message) |
981 | { | 980 | { |
982 | struct us_data *us = usb_get_intfdata(iface); | 981 | struct us_data *us = usb_get_intfdata(iface); |
983 | 982 | ||