diff options
author | Johan Hovold <jhovold@gmail.com> | 2011-11-06 13:06:30 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 13:35:27 -0500 |
commit | fd11961a2deaf4220ca90ce734439b4006db2911 (patch) | |
tree | f18e3a656eb93b01fe3238ba2b014add9a85b034 /drivers/usb/serial/garmin_gps.c | |
parent | b7195188e9884f62efd96a3a91415418cb44381f (diff) |
USB: serial: remove unnecessary bulk-urb re-fills
Remove unnecessary re-fills of bulk urbs whose fields have not changed
since port probe.
Compile-only tested.
Cc: Matthias Bruestle and Harald Welte <support@reiner-sct.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/garmin_gps.c')
-rw-r--r-- | drivers/usb/serial/garmin_gps.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index d39da13d3db..bf12565f8e8 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c | |||
@@ -1276,7 +1276,6 @@ static void garmin_read_int_callback(struct urb *urb) | |||
1276 | unsigned long flags; | 1276 | unsigned long flags; |
1277 | int retval; | 1277 | int retval; |
1278 | struct usb_serial_port *port = urb->context; | 1278 | struct usb_serial_port *port = urb->context; |
1279 | struct usb_serial *serial = port->serial; | ||
1280 | struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); | 1279 | struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); |
1281 | unsigned char *data = urb->transfer_buffer; | 1280 | unsigned char *data = urb->transfer_buffer; |
1282 | int status = urb->status; | 1281 | int status = urb->status; |
@@ -1310,12 +1309,6 @@ static void garmin_read_int_callback(struct urb *urb) | |||
1310 | if (0 == (garmin_data_p->flags & FLAGS_BULK_IN_ACTIVE)) { | 1309 | if (0 == (garmin_data_p->flags & FLAGS_BULK_IN_ACTIVE)) { |
1311 | 1310 | ||
1312 | /* bulk data available */ | 1311 | /* bulk data available */ |
1313 | usb_fill_bulk_urb(port->read_urb, serial->dev, | ||
1314 | usb_rcvbulkpipe(serial->dev, | ||
1315 | port->bulk_in_endpointAddress), | ||
1316 | port->read_urb->transfer_buffer, | ||
1317 | port->read_urb->transfer_buffer_length, | ||
1318 | garmin_read_bulk_callback, port); | ||
1319 | retval = usb_submit_urb(port->read_urb, GFP_ATOMIC); | 1312 | retval = usb_submit_urb(port->read_urb, GFP_ATOMIC); |
1320 | if (retval) { | 1313 | if (retval) { |
1321 | dev_err(&port->dev, | 1314 | dev_err(&port->dev, |