diff options
author | Johan Hovold <jhovold@gmail.com> | 2011-11-06 13:06:28 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 13:33:16 -0500 |
commit | 5833041f1b130e5823a99d03b14538282e5ad345 (patch) | |
tree | 394caf266125dd725d47470a11cb5840040130ec /drivers/usb/serial/garmin_gps.c | |
parent | 016af7ec49836342c3b35166792c8d73a360571c (diff) |
USB: serial: remove unnecessary reinitialisations of urb->dev
Remove unnecessary reinitialisations of urb->dev before each submission,
which were based on the (no longer valid) assumption that serial->dev
will be set to NULL on close.
Compile-only tested.
Cc: Matthias Bruestle and Harald Welte <support@reiner-sct.com>
Cc: Lonnie Mendez <dignome@gmail.com>
Cc: Peter Berger <pberger@brimson.com>
Cc: Al Borchers <alborchers@steinerpoint.com>
Cc: Support Department <support@connecttech.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/garmin_gps.c')
-rw-r--r-- | drivers/usb/serial/garmin_gps.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index 1a49ca9c8ea..d39da13d3db 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c | |||
@@ -901,7 +901,6 @@ static int garmin_init_session(struct usb_serial_port *port) | |||
901 | usb_kill_urb(port->interrupt_in_urb); | 901 | usb_kill_urb(port->interrupt_in_urb); |
902 | 902 | ||
903 | dbg("%s - adding interrupt input", __func__); | 903 | dbg("%s - adding interrupt input", __func__); |
904 | port->interrupt_in_urb->dev = serial->dev; | ||
905 | status = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); | 904 | status = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); |
906 | if (status) | 905 | if (status) |
907 | dev_err(&serial->dev->dev, | 906 | dev_err(&serial->dev->dev, |
@@ -1353,7 +1352,6 @@ static void garmin_read_int_callback(struct urb *urb) | |||
1353 | 1352 | ||
1354 | garmin_read_process(garmin_data_p, data, urb->actual_length, 0); | 1353 | garmin_read_process(garmin_data_p, data, urb->actual_length, 0); |
1355 | 1354 | ||
1356 | port->interrupt_in_urb->dev = port->serial->dev; | ||
1357 | retval = usb_submit_urb(urb, GFP_ATOMIC); | 1355 | retval = usb_submit_urb(urb, GFP_ATOMIC); |
1358 | if (retval) | 1356 | if (retval) |
1359 | dev_err(&urb->dev->dev, | 1357 | dev_err(&urb->dev->dev, |