aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorIlia Mirkin <imirkin@alum.mit.edu>2011-03-13 00:29:15 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2011-03-14 14:57:37 -0400
commit1d5c536efeb9c109e330209867ae1242d42cdb7b (patch)
treecee0132641f894cedf68dee9452914ce464d7299 /drivers/staging
parent6403bb7dc1f6d77a93850935d9277a0d74783cf0 (diff)
staging: vt6656: Remove NULL check before kfree
This patch was generated by the following semantic patch: // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/vt6656/firmware.c3
-rw-r--r--drivers/staging/vt6656/hostap.c3
-rw-r--r--drivers/staging/vt6656/main_usb.c12
-rw-r--r--drivers/staging/vt6656/wpactl.c3
4 files changed, 7 insertions, 14 deletions
diff --git a/drivers/staging/vt6656/firmware.c b/drivers/staging/vt6656/firmware.c
index 162541255a0..8c8126a3540 100644
--- a/drivers/staging/vt6656/firmware.c
+++ b/drivers/staging/vt6656/firmware.c
@@ -109,8 +109,7 @@ FIRMWAREbDownload(
109 result = TRUE; 109 result = TRUE;
110 110
111out: 111out:
112 if (pBuffer) 112 kfree(pBuffer);
113 kfree(pBuffer);
114 113
115 spin_lock_irq(&pDevice->lock); 114 spin_lock_irq(&pDevice->lock);
116 return result; 115 return result;
diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c
index f70e922a615..51b5adf3657 100644
--- a/drivers/staging/vt6656/hostap.c
+++ b/drivers/staging/vt6656/hostap.c
@@ -858,8 +858,7 @@ int vt6656_hostap_ioctl(PSDevice pDevice, struct iw_point *p)
858 } 858 }
859 859
860 out: 860 out:
861 if (param != NULL) 861 kfree(param);
862 kfree(param);
863 862
864 return ret; 863 return ret;
865} 864}
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 37d639602c8..af14ab01ed7 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -837,8 +837,7 @@ static void device_free_tx_bufs(PSDevice pDevice)
837 usb_kill_urb(pTxContext->pUrb); 837 usb_kill_urb(pTxContext->pUrb);
838 usb_free_urb(pTxContext->pUrb); 838 usb_free_urb(pTxContext->pUrb);
839 } 839 }
840 if (pTxContext) 840 kfree(pTxContext);
841 kfree(pTxContext);
842 } 841 }
843 return; 842 return;
844} 843}
@@ -861,8 +860,7 @@ static void device_free_rx_bufs(PSDevice pDevice)
861 if (pRCB->skb) 860 if (pRCB->skb)
862 dev_kfree_skb(pRCB->skb); 861 dev_kfree_skb(pRCB->skb);
863 } 862 }
864 if (pDevice->pRCBMem) 863 kfree(pDevice->pRCBMem);
865 kfree(pDevice->pRCBMem);
866 864
867 return; 865 return;
868} 866}
@@ -878,8 +876,7 @@ static void usb_device_reset(PSDevice pDevice)
878 876
879static void device_free_int_bufs(PSDevice pDevice) 877static void device_free_int_bufs(PSDevice pDevice)
880{ 878{
881 if (pDevice->intBuf.pDataBuf != NULL) 879 kfree(pDevice->intBuf.pDataBuf);
882 kfree(pDevice->intBuf.pDataBuf);
883 return; 880 return;
884} 881}
885 882
@@ -1480,8 +1477,7 @@ error2:
1480 */ 1477 */
1481 1478
1482if(result!=0) { 1479if(result!=0) {
1483 if(buffer) 1480 kfree(buffer);
1484 kfree(buffer);
1485 buffer=NULL; 1481 buffer=NULL;
1486} 1482}
1487 return buffer; 1483 return buffer;
diff --git a/drivers/staging/vt6656/wpactl.c b/drivers/staging/vt6656/wpactl.c
index 7fd300f2e7c..8752736181b 100644
--- a/drivers/staging/vt6656/wpactl.c
+++ b/drivers/staging/vt6656/wpactl.c
@@ -999,8 +999,7 @@ int wpa_ioctl(PSDevice pDevice, struct iw_point *p)
999 } 999 }
1000 1000
1001out: 1001out:
1002 if (param != NULL) 1002 kfree(param);
1003 kfree(param);
1004 1003
1005 return ret; 1004 return ret;
1006} 1005}