diff options
author | Vincent Bossier <vincent.bossier@gmail.com> | 2011-06-03 05:07:39 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-06-28 17:04:53 -0400 |
commit | 584721cab2bdd26f63bfeca60c83f5e6b8eee7d0 (patch) | |
tree | 98c47e668faee797b5b4ef13d958e41356265a8e /drivers/staging/vme | |
parent | ed7c221c9a06f23c7521a9bfac2518656258bbb6 (diff) |
Staging VME: Fix remaining checkpatch.pl errors.
This patch solves all the existing issues reported by checkpatch.pl in the VME
sub-system.
Signed-off-by: Vincent Bossier <vincent.bossier@gmail.com>
Acked-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/vme')
-rw-r--r-- | drivers/staging/vme/boards/vme_vmivme7805.c | 4 | ||||
-rw-r--r-- | drivers/staging/vme/bridges/vme_ca91cx42.c | 2 | ||||
-rw-r--r-- | drivers/staging/vme/bridges/vme_tsi148.c | 2 | ||||
-rw-r--r-- | drivers/staging/vme/devices/vme_user.c | 24 | ||||
-rw-r--r-- | drivers/staging/vme/vme.h | 2 |
5 files changed, 17 insertions, 17 deletions
diff --git a/drivers/staging/vme/boards/vme_vmivme7805.c b/drivers/staging/vme/boards/vme_vmivme7805.c index 80eaa0c4fe1..8e05bb4e135 100644 --- a/drivers/staging/vme/boards/vme_vmivme7805.c +++ b/drivers/staging/vme/boards/vme_vmivme7805.c | |||
@@ -27,9 +27,9 @@ static void __exit vmic_exit(void); | |||
27 | /** Base address to access FPGA register */ | 27 | /** Base address to access FPGA register */ |
28 | static void *vmic_base; | 28 | static void *vmic_base; |
29 | 29 | ||
30 | static char driver_name[] = "vmivme_7805"; | 30 | static const char driver_name[] = "vmivme_7805"; |
31 | 31 | ||
32 | static struct pci_device_id vmic_ids[] = { | 32 | static DEFINE_PCI_DEVICE_TABLE(vmic_ids) = { |
33 | { PCI_DEVICE(PCI_VENDOR_ID_VMIC, PCI_DEVICE_ID_VTIMR) }, | 33 | { PCI_DEVICE(PCI_VENDOR_ID_VMIC, PCI_DEVICE_ID_VTIMR) }, |
34 | { }, | 34 | { }, |
35 | }; | 35 | }; |
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c index a4007287ef4..1c94ae6b867 100644 --- a/drivers/staging/vme/bridges/vme_ca91cx42.c +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c | |||
@@ -42,7 +42,7 @@ static void __exit ca91cx42_exit(void); | |||
42 | /* Module parameters */ | 42 | /* Module parameters */ |
43 | static int geoid; | 43 | static int geoid; |
44 | 44 | ||
45 | static char driver_name[] = "vme_ca91cx42"; | 45 | static const char driver_name[] = "vme_ca91cx42"; |
46 | 46 | ||
47 | static DEFINE_PCI_DEVICE_TABLE(ca91cx42_ids) = { | 47 | static DEFINE_PCI_DEVICE_TABLE(ca91cx42_ids) = { |
48 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_CA91C142) }, | 48 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_CA91C142) }, |
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c index 106aa9daff4..9c539513c74 100644 --- a/drivers/staging/vme/bridges/vme_tsi148.c +++ b/drivers/staging/vme/bridges/vme_tsi148.c | |||
@@ -44,7 +44,7 @@ static void __exit tsi148_exit(void); | |||
44 | static int err_chk; | 44 | static int err_chk; |
45 | static int geoid; | 45 | static int geoid; |
46 | 46 | ||
47 | static char driver_name[] = "vme_tsi148"; | 47 | static const char driver_name[] = "vme_tsi148"; |
48 | 48 | ||
49 | static DEFINE_PCI_DEVICE_TABLE(tsi148_ids) = { | 49 | static DEFINE_PCI_DEVICE_TABLE(tsi148_ids) = { |
50 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_TSI148) }, | 50 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_TSI148) }, |
diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index a571173249c..633a64259f1 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c | |||
@@ -41,7 +41,7 @@ | |||
41 | #include "vme_user.h" | 41 | #include "vme_user.h" |
42 | 42 | ||
43 | static DEFINE_MUTEX(vme_user_mutex); | 43 | static DEFINE_MUTEX(vme_user_mutex); |
44 | static char driver_name[] = "vme_user"; | 44 | static const char driver_name[] = "vme_user"; |
45 | 45 | ||
46 | static int bus[USER_BUS_MAX]; | 46 | static int bus[USER_BUS_MAX]; |
47 | static unsigned int bus_num; | 47 | static unsigned int bus_num; |
@@ -91,7 +91,7 @@ static unsigned int bus_num; | |||
91 | /* | 91 | /* |
92 | * Structure to handle image related parameters. | 92 | * Structure to handle image related parameters. |
93 | */ | 93 | */ |
94 | typedef struct { | 94 | struct image_desc { |
95 | void *kern_buf; /* Buffer address in kernel space */ | 95 | void *kern_buf; /* Buffer address in kernel space */ |
96 | dma_addr_t pci_buf; /* Buffer address in PCI address space */ | 96 | dma_addr_t pci_buf; /* Buffer address in PCI address space */ |
97 | unsigned long long size_buf; /* Buffer size */ | 97 | unsigned long long size_buf; /* Buffer size */ |
@@ -99,10 +99,10 @@ typedef struct { | |||
99 | struct device *device; /* Sysfs device */ | 99 | struct device *device; /* Sysfs device */ |
100 | struct vme_resource *resource; /* VME resource */ | 100 | struct vme_resource *resource; /* VME resource */ |
101 | int users; /* Number of current users */ | 101 | int users; /* Number of current users */ |
102 | } image_desc_t; | 102 | }; |
103 | static image_desc_t image[VME_DEVS]; | 103 | static struct image_desc image[VME_DEVS]; |
104 | 104 | ||
105 | typedef struct { | 105 | struct driver_stats { |
106 | unsigned long reads; | 106 | unsigned long reads; |
107 | unsigned long writes; | 107 | unsigned long writes; |
108 | unsigned long ioctls; | 108 | unsigned long ioctls; |
@@ -111,8 +111,8 @@ typedef struct { | |||
111 | unsigned long dmaErrors; | 111 | unsigned long dmaErrors; |
112 | unsigned long timeouts; | 112 | unsigned long timeouts; |
113 | unsigned long external; | 113 | unsigned long external; |
114 | } driver_stats_t; | 114 | }; |
115 | static driver_stats_t statistics; | 115 | static struct driver_stats statistics; |
116 | 116 | ||
117 | static struct cdev *vme_user_cdev; /* Character device */ | 117 | static struct cdev *vme_user_cdev; /* Character device */ |
118 | static struct class *vme_user_sysfs_class; /* Sysfs class */ | 118 | static struct class *vme_user_sysfs_class; /* Sysfs class */ |
@@ -138,7 +138,7 @@ static long vme_user_unlocked_ioctl(struct file *, unsigned int, unsigned long); | |||
138 | static int __devinit vme_user_probe(struct device *, int, int); | 138 | static int __devinit vme_user_probe(struct device *, int, int); |
139 | static int __devexit vme_user_remove(struct device *, int, int); | 139 | static int __devexit vme_user_remove(struct device *, int, int); |
140 | 140 | ||
141 | static struct file_operations vme_user_fops = { | 141 | static const struct file_operations vme_user_fops = { |
142 | .open = vme_user_open, | 142 | .open = vme_user_open, |
143 | .release = vme_user_release, | 143 | .release = vme_user_release, |
144 | .read = vme_user_read, | 144 | .read = vme_user_read, |
@@ -773,6 +773,7 @@ static int __devinit vme_user_probe(struct device *dev, int cur_bus, | |||
773 | 773 | ||
774 | /* Add sysfs Entries */ | 774 | /* Add sysfs Entries */ |
775 | for (i = 0; i < VME_DEVS; i++) { | 775 | for (i = 0; i < VME_DEVS; i++) { |
776 | int num; | ||
776 | switch (type[i]) { | 777 | switch (type[i]) { |
777 | case MASTER_MINOR: | 778 | case MASTER_MINOR: |
778 | sprintf(name, "bus/vme/m%%d"); | 779 | sprintf(name, "bus/vme/m%%d"); |
@@ -789,10 +790,9 @@ static int __devinit vme_user_probe(struct device *dev, int cur_bus, | |||
789 | break; | 790 | break; |
790 | } | 791 | } |
791 | 792 | ||
792 | image[i].device = | 793 | num = (type[i] == SLAVE_MINOR) ? i - (MASTER_MAX + 1) : i; |
793 | device_create(vme_user_sysfs_class, NULL, | 794 | image[i].device = device_create(vme_user_sysfs_class, NULL, |
794 | MKDEV(VME_MAJOR, i), NULL, name, | 795 | MKDEV(VME_MAJOR, i), NULL, name, num); |
795 | (type[i] == SLAVE_MINOR) ? i - (MASTER_MAX + 1) : i); | ||
796 | if (IS_ERR(image[i].device)) { | 796 | if (IS_ERR(image[i].device)) { |
797 | printk(KERN_INFO "%s: Error creating sysfs device\n", | 797 | printk(KERN_INFO "%s: Error creating sysfs device\n", |
798 | driver_name); | 798 | driver_name); |
diff --git a/drivers/staging/vme/vme.h b/drivers/staging/vme/vme.h index 48768ca97e1..4155d8c2a53 100644 --- a/drivers/staging/vme/vme.h +++ b/drivers/staging/vme/vme.h | |||
@@ -98,7 +98,7 @@ struct vme_device_id { | |||
98 | 98 | ||
99 | struct vme_driver { | 99 | struct vme_driver { |
100 | struct list_head node; | 100 | struct list_head node; |
101 | char *name; | 101 | const char *name; |
102 | const struct vme_device_id *bind_table; | 102 | const struct vme_device_id *bind_table; |
103 | int (*probe) (struct device *, int, int); | 103 | int (*probe) (struct device *, int, int); |
104 | int (*remove) (struct device *, int, int); | 104 | int (*remove) (struct device *, int, int); |