diff options
author | Németh Márton <nm127@freemail.hu> | 2010-01-09 18:18:26 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-03 19:42:42 -0500 |
commit | 13ac58dac0c6b1edeb060102049b07ebceea9a40 (patch) | |
tree | c086dec592c4082802c973620ba4891dfda907c8 /drivers/staging/vme | |
parent | 75b16013e29f6058e5bd648e6f4a9c03d262cf4f (diff) |
staging: make PCI device id constant
The id_table field of the struct pci_driver is constant in <linux/pci.h>
so it is worth to make the initialization data also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Németh Márton <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/vme')
-rw-r--r-- | drivers/staging/vme/bridges/vme_ca91cx42.c | 2 | ||||
-rw-r--r-- | drivers/staging/vme/bridges/vme_tsi148.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c index 47047985605..807278485bb 100644 --- a/drivers/staging/vme/bridges/vme_ca91cx42.c +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c | |||
@@ -61,7 +61,7 @@ static struct mutex vme_int; /* | |||
61 | 61 | ||
62 | static char driver_name[] = "vme_ca91cx42"; | 62 | static char driver_name[] = "vme_ca91cx42"; |
63 | 63 | ||
64 | static struct pci_device_id ca91cx42_ids[] = { | 64 | static const struct pci_device_id ca91cx42_ids[] = { |
65 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_CA91C142) }, | 65 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_CA91C142) }, |
66 | { }, | 66 | { }, |
67 | }; | 67 | }; |
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c index 4d19a914ec5..ed8297daf9e 100644 --- a/drivers/staging/vme/bridges/vme_tsi148.c +++ b/drivers/staging/vme/bridges/vme_tsi148.c | |||
@@ -81,7 +81,7 @@ static struct mutex vme_int; /* | |||
81 | 81 | ||
82 | static char driver_name[] = "vme_tsi148"; | 82 | static char driver_name[] = "vme_tsi148"; |
83 | 83 | ||
84 | static struct pci_device_id tsi148_ids[] = { | 84 | static const struct pci_device_id tsi148_ids[] = { |
85 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_TSI148) }, | 85 | { PCI_DEVICE(PCI_VENDOR_ID_TUNDRA, PCI_DEVICE_ID_TUNDRA_TSI148) }, |
86 | { }, | 86 | { }, |
87 | }; | 87 | }; |