staging: tidspbridge: remove DBC_ASSERT macro

This macro is only valid when CONFIG_TIDSPBRDIGE_DEBUG is enabled and it only
prints a log message, it is not a real assertion mechanism like BUG_ON() or
WARN_ON().

It is better to remove them: less code to maintain.

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 0 insertions, 12 deletions

diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c
index 91daf25d29a..3136e8ddad4 100644
--- a/drivers/staging/tidspbridge/core/chnl_sm.c
+++ b/drivers/staging/tidspbridge/core/chnl_sm.c
@@ -123,7 +123,6 @@ int bridge_chnl_add_io_req(struct chnl_object *chnl_obj, void *host_buf,
                                 CHNL_IS_OUTPUT(pchnl->chnl_mode))
                         return -EPIPE;
                 /* No other possible states left */
-                DBC_ASSERT(0);
         }
 
         dev_obj = dev_get_first();
@@ -190,7 +189,6 @@ func_cont:
          * Note: for dma chans dw_dsp_addr contains dsp address
          * of SM buffer.
          */
-        DBC_ASSERT(chnl_mgr_obj->word_size != 0);
         /* DSP address */
         chnl_packet_obj->dsp_tx_addr = dw_dsp_addr / chnl_mgr_obj->word_size;
         chnl_packet_obj->byte_size = byte_size;
@@ -201,7 +199,6 @@ func_cont:
                         CHNL_IOCSTATCOMPLETE);
         list_add_tail(&chnl_packet_obj->link, &pchnl->io_requests);
         pchnl->cio_reqs++;
-        DBC_ASSERT(pchnl->cio_reqs <= pchnl->chnl_packets);
         /*
          * If end of stream, update the channel state to prevent
          * more IOR's.
@@ -209,8 +206,6 @@ func_cont:
         if (is_eos)
                 pchnl->state |= CHNL_STATEEOS;
 
-        /* Legacy DSM Processor-Copy */
-        DBC_ASSERT(pchnl->chnl_type == CHNL_PCPY);
         /* Request IO from the DSP */
         io_request_chnl(chnl_mgr_obj->iomgr, pchnl,
                         (CHNL_IS_INPUT(pchnl->chnl_mode) ? IO_INPUT :
@@ -283,7 +278,6 @@ int bridge_chnl_cancel_io(struct chnl_object *chnl_obj)
                 list_add_tail(&chirp->link, &pchnl->io_completions);
                 pchnl->cio_cs++;
                 pchnl->cio_reqs--;
-                DBC_ASSERT(pchnl->cio_reqs >= 0);
         }
 
         spin_unlock_bh(&chnl_mgr_obj->chnl_mgr_lock);
@@ -311,8 +305,6 @@ int bridge_chnl_close(struct chnl_object *chnl_obj)
         status = bridge_chnl_cancel_io(chnl_obj);
         if (status)
                 return status;
-        /* Assert I/O on this channel is now cancelled: Protects from io_dpc */
-        DBC_ASSERT((pchnl->state & CHNL_STATECANCEL));
         /* Invalidate channel object: Protects from CHNL_GetIOCompletion() */
         /* Free the slot in the channel manager: */
         pchnl->chnl_mgr_obj->channels[pchnl->chnl_id] = NULL;
@@ -367,7 +359,6 @@ int bridge_chnl_create(struct chnl_mgr **channel_mgr,
                  *      mgr_attrts->max_channels = CHNL_MAXCHANNELS =
                  *                       DDMA_MAXDDMACHNLS = DDMA_MAXZCPYCHNLS.
                  */
-                DBC_ASSERT(mgr_attrts->max_channels == CHNL_MAXCHANNELS);
                 max_channels = CHNL_MAXCHANNELS + CHNL_MAXCHANNELS * CHNL_PCPY;
                 /* Create array of channels */
                 chnl_mgr_obj->channels = kzalloc(sizeof(struct chnl_object *)
@@ -584,7 +575,6 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout,
         omap_mbox_disable_irq(dev_ctxt->mbox, IRQ_RX);
         if (dequeue_ioc) {
                 /* Dequeue IOC and set chan_ioc; */
-                DBC_ASSERT(!list_empty(&pchnl->io_completions));
                 chnl_packet_obj = list_first_entry(&pchnl->io_completions,
                                 struct chnl_irp, link);
                 list_del(&chnl_packet_obj->link);
@@ -748,7 +738,6 @@ int bridge_chnl_open(struct chnl_object **chnl,
                         return status;
         }
 
-        DBC_ASSERT(ch_id < chnl_mgr_obj->max_channels);
 
         /* Create channel object: */
         pchnl = kzalloc(sizeof(struct chnl_object), GFP_KERNEL);
@@ -837,7 +826,6 @@ int bridge_chnl_register_notify(struct chnl_object *chnl_obj,
 {
         int status = 0;
 
-        DBC_ASSERT(!(event_mask & ~(DSP_STREAMDONE | DSP_STREAMIOCOMPLETION)));
 
         if (event_mask)
                 status = ntfy_register(chnl_obj->ntfy_obj, hnotification,