diff options
author | Alexander Beregalov <a.beregalov@gmail.com> | 2011-03-26 13:18:11 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-20 16:45:57 -0400 |
commit | f7468e2995dbd914817c780941750f0ac668ac50 (patch) | |
tree | 241a9e54539b88d6875dee1450a5e5c68c01fc11 /drivers/staging/rts_pstor | |
parent | 24c92eac7e5976b07f663e1149d73075aff96c0d (diff) |
Staging: rts_pstor: s/rtsx_free_dma_buf/kfree/
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/rts_pstor')
-rw-r--r-- | drivers/staging/rts_pstor/ms.c | 38 | ||||
-rw-r--r-- | drivers/staging/rts_pstor/rtsx.h | 1 | ||||
-rw-r--r-- | drivers/staging/rts_pstor/spi.c | 26 | ||||
-rw-r--r-- | drivers/staging/rts_pstor/xd.c | 2 |
4 files changed, 33 insertions, 34 deletions
diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c index 810e170894f..58fc7e07522 100644 --- a/drivers/staging/rts_pstor/ms.c +++ b/drivers/staging/rts_pstor/ms.c | |||
@@ -875,11 +875,11 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
875 | } | 875 | } |
876 | retval = rtsx_read_register(chip, MS_TRANS_CFG, &val); | 876 | retval = rtsx_read_register(chip, MS_TRANS_CFG, &val); |
877 | if (retval != STATUS_SUCCESS) { | 877 | if (retval != STATUS_SUCCESS) { |
878 | rtsx_free_dma_buf(chip, buf); | 878 | kfree(buf); |
879 | TRACE_RET(chip, STATUS_FAIL); | 879 | TRACE_RET(chip, STATUS_FAIL); |
880 | } | 880 | } |
881 | if (!(val & MS_INT_BREQ)) { | 881 | if (!(val & MS_INT_BREQ)) { |
882 | rtsx_free_dma_buf(chip, buf); | 882 | kfree(buf); |
883 | TRACE_RET(chip, STATUS_FAIL); | 883 | TRACE_RET(chip, STATUS_FAIL); |
884 | } | 884 | } |
885 | retval = ms_transfer_data(chip, MS_TM_AUTO_READ, PRO_READ_LONG_DATA, | 885 | retval = ms_transfer_data(chip, MS_TM_AUTO_READ, PRO_READ_LONG_DATA, |
@@ -891,7 +891,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
891 | } | 891 | } |
892 | } | 892 | } |
893 | if (retval != STATUS_SUCCESS) { | 893 | if (retval != STATUS_SUCCESS) { |
894 | rtsx_free_dma_buf(chip, buf); | 894 | kfree(buf); |
895 | TRACE_RET(chip, STATUS_FAIL); | 895 | TRACE_RET(chip, STATUS_FAIL); |
896 | } | 896 | } |
897 | 897 | ||
@@ -899,7 +899,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
899 | do { | 899 | do { |
900 | retval = rtsx_read_register(chip, MS_TRANS_CFG, &val); | 900 | retval = rtsx_read_register(chip, MS_TRANS_CFG, &val); |
901 | if (retval != STATUS_SUCCESS) { | 901 | if (retval != STATUS_SUCCESS) { |
902 | rtsx_free_dma_buf(chip, buf); | 902 | kfree(buf); |
903 | TRACE_RET(chip, STATUS_FAIL); | 903 | TRACE_RET(chip, STATUS_FAIL); |
904 | } | 904 | } |
905 | 905 | ||
@@ -908,7 +908,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
908 | 908 | ||
909 | retval = ms_transfer_tpc(chip, MS_TM_NORMAL_READ, PRO_READ_LONG_DATA, 0, WAIT_INT); | 909 | retval = ms_transfer_tpc(chip, MS_TM_NORMAL_READ, PRO_READ_LONG_DATA, 0, WAIT_INT); |
910 | if (retval != STATUS_SUCCESS) { | 910 | if (retval != STATUS_SUCCESS) { |
911 | rtsx_free_dma_buf(chip, buf); | 911 | kfree(buf); |
912 | TRACE_RET(chip, STATUS_FAIL); | 912 | TRACE_RET(chip, STATUS_FAIL); |
913 | } | 913 | } |
914 | 914 | ||
@@ -916,18 +916,18 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
916 | } while (i < 1024); | 916 | } while (i < 1024); |
917 | 917 | ||
918 | if (retval != STATUS_SUCCESS) { | 918 | if (retval != STATUS_SUCCESS) { |
919 | rtsx_free_dma_buf(chip, buf); | 919 | kfree(buf); |
920 | TRACE_RET(chip, STATUS_FAIL); | 920 | TRACE_RET(chip, STATUS_FAIL); |
921 | } | 921 | } |
922 | 922 | ||
923 | if ((buf[0] != 0xa5) && (buf[1] != 0xc3)) { | 923 | if ((buf[0] != 0xa5) && (buf[1] != 0xc3)) { |
924 | /* Signature code is wrong */ | 924 | /* Signature code is wrong */ |
925 | rtsx_free_dma_buf(chip, buf); | 925 | kfree(buf); |
926 | TRACE_RET(chip, STATUS_FAIL); | 926 | TRACE_RET(chip, STATUS_FAIL); |
927 | } | 927 | } |
928 | 928 | ||
929 | if ((buf[4] < 1) || (buf[4] > 12)) { | 929 | if ((buf[4] < 1) || (buf[4] > 12)) { |
930 | rtsx_free_dma_buf(chip, buf); | 930 | kfree(buf); |
931 | TRACE_RET(chip, STATUS_FAIL); | 931 | TRACE_RET(chip, STATUS_FAIL); |
932 | } | 932 | } |
933 | 933 | ||
@@ -949,15 +949,15 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
949 | RTSX_DEBUGP("sys_info_addr = 0x%x, sys_info_size = 0x%x\n", | 949 | RTSX_DEBUGP("sys_info_addr = 0x%x, sys_info_size = 0x%x\n", |
950 | sys_info_addr, sys_info_size); | 950 | sys_info_addr, sys_info_size); |
951 | if (sys_info_size != 96) { | 951 | if (sys_info_size != 96) { |
952 | rtsx_free_dma_buf(chip, buf); | 952 | kfree(buf); |
953 | TRACE_RET(chip, STATUS_FAIL); | 953 | TRACE_RET(chip, STATUS_FAIL); |
954 | } | 954 | } |
955 | if (sys_info_addr < 0x1A0) { | 955 | if (sys_info_addr < 0x1A0) { |
956 | rtsx_free_dma_buf(chip, buf); | 956 | kfree(buf); |
957 | TRACE_RET(chip, STATUS_FAIL); | 957 | TRACE_RET(chip, STATUS_FAIL); |
958 | } | 958 | } |
959 | if ((sys_info_size + sys_info_addr) > 0x8000) { | 959 | if ((sys_info_size + sys_info_addr) > 0x8000) { |
960 | rtsx_free_dma_buf(chip, buf); | 960 | kfree(buf); |
961 | TRACE_RET(chip, STATUS_FAIL); | 961 | TRACE_RET(chip, STATUS_FAIL); |
962 | } | 962 | } |
963 | 963 | ||
@@ -983,15 +983,15 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
983 | RTSX_DEBUGP("model_name_addr = 0x%x, model_name_size = 0x%x\n", | 983 | RTSX_DEBUGP("model_name_addr = 0x%x, model_name_size = 0x%x\n", |
984 | model_name_addr, model_name_size); | 984 | model_name_addr, model_name_size); |
985 | if (model_name_size != 48) { | 985 | if (model_name_size != 48) { |
986 | rtsx_free_dma_buf(chip, buf); | 986 | kfree(buf); |
987 | TRACE_RET(chip, STATUS_FAIL); | 987 | TRACE_RET(chip, STATUS_FAIL); |
988 | } | 988 | } |
989 | if (model_name_addr < 0x1A0) { | 989 | if (model_name_addr < 0x1A0) { |
990 | rtsx_free_dma_buf(chip, buf); | 990 | kfree(buf); |
991 | TRACE_RET(chip, STATUS_FAIL); | 991 | TRACE_RET(chip, STATUS_FAIL); |
992 | } | 992 | } |
993 | if ((model_name_size + model_name_addr) > 0x8000) { | 993 | if ((model_name_size + model_name_addr) > 0x8000) { |
994 | rtsx_free_dma_buf(chip, buf); | 994 | kfree(buf); |
995 | TRACE_RET(chip, STATUS_FAIL); | 995 | TRACE_RET(chip, STATUS_FAIL); |
996 | } | 996 | } |
997 | 997 | ||
@@ -1004,7 +1004,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
1004 | } | 1004 | } |
1005 | 1005 | ||
1006 | if (i == buf[4]) { | 1006 | if (i == buf[4]) { |
1007 | rtsx_free_dma_buf(chip, buf); | 1007 | kfree(buf); |
1008 | TRACE_RET(chip, STATUS_FAIL); | 1008 | TRACE_RET(chip, STATUS_FAIL); |
1009 | } | 1009 | } |
1010 | 1010 | ||
@@ -1041,7 +1041,7 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) | |||
1041 | memcpy(ms_card->raw_model_name, buf + model_name_addr, 48); | 1041 | memcpy(ms_card->raw_model_name, buf + model_name_addr, 48); |
1042 | #endif | 1042 | #endif |
1043 | 1043 | ||
1044 | rtsx_free_dma_buf(chip, buf); | 1044 | kfree(buf); |
1045 | 1045 | ||
1046 | #ifdef SUPPORT_MSXC | 1046 | #ifdef SUPPORT_MSXC |
1047 | if (CHK_MSXC(ms_card)) { | 1047 | if (CHK_MSXC(ms_card)) { |
@@ -3817,7 +3817,7 @@ int mg_get_local_EKB(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
3817 | 3817 | ||
3818 | GetEKBFinish: | 3818 | GetEKBFinish: |
3819 | if (buf) { | 3819 | if (buf) { |
3820 | rtsx_free_dma_buf(chip, buf); | 3820 | kfree(buf); |
3821 | } | 3821 | } |
3822 | return retval; | 3822 | return retval; |
3823 | } | 3823 | } |
@@ -4055,7 +4055,7 @@ int mg_get_ICV(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
4055 | 4055 | ||
4056 | GetICVFinish: | 4056 | GetICVFinish: |
4057 | if (buf) { | 4057 | if (buf) { |
4058 | rtsx_free_dma_buf(chip, buf); | 4058 | kfree(buf); |
4059 | } | 4059 | } |
4060 | return retval; | 4060 | return retval; |
4061 | } | 4061 | } |
@@ -4156,7 +4156,7 @@ int mg_set_ICV(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
4156 | 4156 | ||
4157 | SetICVFinish: | 4157 | SetICVFinish: |
4158 | if (buf) { | 4158 | if (buf) { |
4159 | rtsx_free_dma_buf(chip, buf); | 4159 | kfree(buf); |
4160 | } | 4160 | } |
4161 | return retval; | 4161 | return retval; |
4162 | } | 4162 | } |
diff --git a/drivers/staging/rts_pstor/rtsx.h b/drivers/staging/rts_pstor/rtsx.h index 4d5ddf6fbb5..263524c45aa 100644 --- a/drivers/staging/rts_pstor/rtsx.h +++ b/drivers/staging/rts_pstor/rtsx.h | |||
@@ -99,7 +99,6 @@ do { \ | |||
99 | #define SCSI_LUN(srb) ((srb)->device->lun) | 99 | #define SCSI_LUN(srb) ((srb)->device->lun) |
100 | 100 | ||
101 | #define rtsx_alloc_dma_buf(chip, size, flag) kmalloc((size), (flag)) | 101 | #define rtsx_alloc_dma_buf(chip, size, flag) kmalloc((size), (flag)) |
102 | #define rtsx_free_dma_buf(chip, ptr) kfree((ptr)) | ||
103 | 102 | ||
104 | typedef unsigned long DELAY_PARA_T; | 103 | typedef unsigned long DELAY_PARA_T; |
105 | 104 | ||
diff --git a/drivers/staging/rts_pstor/spi.c b/drivers/staging/rts_pstor/spi.c index 8a8689b327a..3daab9ad48b 100644 --- a/drivers/staging/rts_pstor/spi.c +++ b/drivers/staging/rts_pstor/spi.c | |||
@@ -543,7 +543,7 @@ int spi_read_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
543 | 543 | ||
544 | retval = rtsx_transfer_data(chip, 0, buf, pagelen, 0, DMA_FROM_DEVICE, 10000); | 544 | retval = rtsx_transfer_data(chip, 0, buf, pagelen, 0, DMA_FROM_DEVICE, 10000); |
545 | if (retval < 0) { | 545 | if (retval < 0) { |
546 | rtsx_free_dma_buf(chip, buf); | 546 | kfree(buf); |
547 | rtsx_clear_spi_error(chip); | 547 | rtsx_clear_spi_error(chip); |
548 | spi_set_err_code(chip, SPI_HW_ERR); | 548 | spi_set_err_code(chip, SPI_HW_ERR); |
549 | TRACE_RET(chip, STATUS_FAIL); | 549 | TRACE_RET(chip, STATUS_FAIL); |
@@ -556,7 +556,7 @@ int spi_read_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
556 | } | 556 | } |
557 | 557 | ||
558 | scsi_set_resid(srb, 0); | 558 | scsi_set_resid(srb, 0); |
559 | rtsx_free_dma_buf(chip, buf); | 559 | kfree(buf); |
560 | 560 | ||
561 | return STATUS_SUCCESS; | 561 | return STATUS_SUCCESS; |
562 | } | 562 | } |
@@ -591,7 +591,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
591 | while (len) { | 591 | while (len) { |
592 | retval = sf_enable_write(chip, SPI_WREN); | 592 | retval = sf_enable_write(chip, SPI_WREN); |
593 | if (retval != STATUS_SUCCESS) { | 593 | if (retval != STATUS_SUCCESS) { |
594 | rtsx_free_dma_buf(chip, buf); | 594 | kfree(buf); |
595 | TRACE_RET(chip, STATUS_FAIL); | 595 | TRACE_RET(chip, STATUS_FAIL); |
596 | } | 596 | } |
597 | 597 | ||
@@ -605,7 +605,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
605 | 605 | ||
606 | retval = rtsx_send_cmd(chip, 0, 100); | 606 | retval = rtsx_send_cmd(chip, 0, 100); |
607 | if (retval < 0) { | 607 | if (retval < 0) { |
608 | rtsx_free_dma_buf(chip, buf); | 608 | kfree(buf); |
609 | rtsx_clear_spi_error(chip); | 609 | rtsx_clear_spi_error(chip); |
610 | spi_set_err_code(chip, SPI_HW_ERR); | 610 | spi_set_err_code(chip, SPI_HW_ERR); |
611 | TRACE_RET(chip, STATUS_FAIL); | 611 | TRACE_RET(chip, STATUS_FAIL); |
@@ -613,7 +613,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
613 | 613 | ||
614 | retval = sf_polling_status(chip, 100); | 614 | retval = sf_polling_status(chip, 100); |
615 | if (retval != STATUS_SUCCESS) { | 615 | if (retval != STATUS_SUCCESS) { |
616 | rtsx_free_dma_buf(chip, buf); | 616 | kfree(buf); |
617 | TRACE_RET(chip, STATUS_FAIL); | 617 | TRACE_RET(chip, STATUS_FAIL); |
618 | } | 618 | } |
619 | 619 | ||
@@ -621,7 +621,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
621 | len--; | 621 | len--; |
622 | } | 622 | } |
623 | 623 | ||
624 | rtsx_free_dma_buf(chip, buf); | 624 | kfree(buf); |
625 | 625 | ||
626 | } else if (program_mode == AAI_PROGRAM) { | 626 | } else if (program_mode == AAI_PROGRAM) { |
627 | int first_byte = 1; | 627 | int first_byte = 1; |
@@ -650,7 +650,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
650 | 650 | ||
651 | retval = rtsx_send_cmd(chip, 0, 100); | 651 | retval = rtsx_send_cmd(chip, 0, 100); |
652 | if (retval < 0) { | 652 | if (retval < 0) { |
653 | rtsx_free_dma_buf(chip, buf); | 653 | kfree(buf); |
654 | rtsx_clear_spi_error(chip); | 654 | rtsx_clear_spi_error(chip); |
655 | spi_set_err_code(chip, SPI_HW_ERR); | 655 | spi_set_err_code(chip, SPI_HW_ERR); |
656 | TRACE_RET(chip, STATUS_FAIL); | 656 | TRACE_RET(chip, STATUS_FAIL); |
@@ -658,14 +658,14 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
658 | 658 | ||
659 | retval = sf_polling_status(chip, 100); | 659 | retval = sf_polling_status(chip, 100); |
660 | if (retval != STATUS_SUCCESS) { | 660 | if (retval != STATUS_SUCCESS) { |
661 | rtsx_free_dma_buf(chip, buf); | 661 | kfree(buf); |
662 | TRACE_RET(chip, STATUS_FAIL); | 662 | TRACE_RET(chip, STATUS_FAIL); |
663 | } | 663 | } |
664 | 664 | ||
665 | len--; | 665 | len--; |
666 | } | 666 | } |
667 | 667 | ||
668 | rtsx_free_dma_buf(chip, buf); | 668 | kfree(buf); |
669 | 669 | ||
670 | retval = sf_disable_write(chip, SPI_WRDI); | 670 | retval = sf_disable_write(chip, SPI_WRDI); |
671 | if (retval != STATUS_SUCCESS) | 671 | if (retval != STATUS_SUCCESS) |
@@ -687,7 +687,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
687 | 687 | ||
688 | retval = sf_enable_write(chip, SPI_WREN); | 688 | retval = sf_enable_write(chip, SPI_WREN); |
689 | if (retval != STATUS_SUCCESS) { | 689 | if (retval != STATUS_SUCCESS) { |
690 | rtsx_free_dma_buf(chip, buf); | 690 | kfree(buf); |
691 | TRACE_RET(chip, STATUS_FAIL); | 691 | TRACE_RET(chip, STATUS_FAIL); |
692 | } | 692 | } |
693 | 693 | ||
@@ -702,7 +702,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
702 | 702 | ||
703 | retval = rtsx_transfer_data(chip, 0, buf, pagelen, 0, DMA_TO_DEVICE, 100); | 703 | retval = rtsx_transfer_data(chip, 0, buf, pagelen, 0, DMA_TO_DEVICE, 100); |
704 | if (retval < 0) { | 704 | if (retval < 0) { |
705 | rtsx_free_dma_buf(chip, buf); | 705 | kfree(buf); |
706 | rtsx_clear_spi_error(chip); | 706 | rtsx_clear_spi_error(chip); |
707 | spi_set_err_code(chip, SPI_HW_ERR); | 707 | spi_set_err_code(chip, SPI_HW_ERR); |
708 | TRACE_RET(chip, STATUS_FAIL); | 708 | TRACE_RET(chip, STATUS_FAIL); |
@@ -710,7 +710,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
710 | 710 | ||
711 | retval = sf_polling_status(chip, 100); | 711 | retval = sf_polling_status(chip, 100); |
712 | if (retval != STATUS_SUCCESS) { | 712 | if (retval != STATUS_SUCCESS) { |
713 | rtsx_free_dma_buf(chip, buf); | 713 | kfree(buf); |
714 | TRACE_RET(chip, STATUS_FAIL); | 714 | TRACE_RET(chip, STATUS_FAIL); |
715 | } | 715 | } |
716 | 716 | ||
@@ -718,7 +718,7 @@ int spi_write_flash(struct scsi_cmnd *srb, struct rtsx_chip *chip) | |||
718 | len -= pagelen; | 718 | len -= pagelen; |
719 | } | 719 | } |
720 | 720 | ||
721 | rtsx_free_dma_buf(chip, buf); | 721 | kfree(buf); |
722 | } else { | 722 | } else { |
723 | spi_set_err_code(chip, SPI_INVALID_COMMAND); | 723 | spi_set_err_code(chip, SPI_INVALID_COMMAND); |
724 | TRACE_RET(chip, STATUS_FAIL); | 724 | TRACE_RET(chip, STATUS_FAIL); |
diff --git a/drivers/staging/rts_pstor/xd.c b/drivers/staging/rts_pstor/xd.c index 7bcd468b8f2..b9eb072d74e 100644 --- a/drivers/staging/rts_pstor/xd.c +++ b/drivers/staging/rts_pstor/xd.c | |||
@@ -426,7 +426,7 @@ static void xd_clear_dma_buffer(struct rtsx_chip *chip) | |||
426 | rtsx_write_register(chip, CARD_STOP, SD_STOP | SD_CLR_ERR, SD_STOP | SD_CLR_ERR); | 426 | rtsx_write_register(chip, CARD_STOP, SD_STOP | SD_CLR_ERR, SD_STOP | SD_CLR_ERR); |
427 | } | 427 | } |
428 | 428 | ||
429 | rtsx_free_dma_buf(chip, buf); | 429 | kfree(buf); |
430 | 430 | ||
431 | if (chip->asic_code) { | 431 | if (chip->asic_code) { |
432 | rtsx_write_register(chip, CARD_PULL_CTL2, 0xFF, 0x55); | 432 | rtsx_write_register(chip, CARD_PULL_CTL2, 0xFF, 0x55); |