diff options
author | Rob Clark <rob@ti.com> | 2011-12-10 00:26:07 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-12-12 19:37:52 -0500 |
commit | 65b0bd067df97737b9a13d92934d8f581cb0b07a (patch) | |
tree | 86fa4449d20a434d038205a2addd517d24006304 /drivers/staging/omapdrm | |
parent | b369839b88d6ffd9ad5b4f9362d6bb09a0e16c10 (diff) |
staging: drm/omap: crtc/encoder/fb destroy cleanups
Signed-off-by: Rob Clark <rob@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/omapdrm')
-rw-r--r-- | drivers/staging/omapdrm/omap_crtc.c | 3 | ||||
-rw-r--r-- | drivers/staging/omapdrm/omap_encoder.c | 3 | ||||
-rw-r--r-- | drivers/staging/omapdrm/omap_fb.c | 6 |
3 files changed, 4 insertions, 8 deletions
diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c index fd09bcfab85..cffdf5e1239 100644 --- a/drivers/staging/omapdrm/omap_crtc.c +++ b/drivers/staging/omapdrm/omap_crtc.c | |||
@@ -320,8 +320,7 @@ struct drm_crtc *omap_crtc_init(struct drm_device *dev, | |||
320 | 320 | ||
321 | fail: | 321 | fail: |
322 | if (crtc) { | 322 | if (crtc) { |
323 | drm_crtc_cleanup(crtc); | 323 | omap_crtc_destroy(crtc); |
324 | kfree(omap_crtc); | ||
325 | } | 324 | } |
326 | return NULL; | 325 | return NULL; |
327 | } | 326 | } |
diff --git a/drivers/staging/omapdrm/omap_encoder.c b/drivers/staging/omapdrm/omap_encoder.c index 83bacd8fd36..06c52cb62d2 100644 --- a/drivers/staging/omapdrm/omap_encoder.c +++ b/drivers/staging/omapdrm/omap_encoder.c | |||
@@ -164,8 +164,7 @@ struct drm_encoder *omap_encoder_init(struct drm_device *dev, | |||
164 | 164 | ||
165 | fail: | 165 | fail: |
166 | if (encoder) { | 166 | if (encoder) { |
167 | drm_encoder_cleanup(encoder); | 167 | omap_encoder_destroy(encoder); |
168 | kfree(omap_encoder); | ||
169 | } | 168 | } |
170 | 169 | ||
171 | return NULL; | 170 | return NULL; |
diff --git a/drivers/staging/omapdrm/omap_fb.c b/drivers/staging/omapdrm/omap_fb.c index 491be5395d8..3f62505813c 100644 --- a/drivers/staging/omapdrm/omap_fb.c +++ b/drivers/staging/omapdrm/omap_fb.c | |||
@@ -53,11 +53,9 @@ static void omap_framebuffer_destroy(struct drm_framebuffer *fb) | |||
53 | 53 | ||
54 | drm_framebuffer_cleanup(fb); | 54 | drm_framebuffer_cleanup(fb); |
55 | 55 | ||
56 | if (omap_gem_put_paddr(omap_fb->bo)) { | ||
57 | dev_err(dev->dev, "could not unmap!\n"); | ||
58 | } | ||
59 | |||
60 | if (omap_fb->bo) { | 56 | if (omap_fb->bo) { |
57 | if (omap_fb->paddr && omap_gem_put_paddr(omap_fb->bo)) | ||
58 | dev_err(dev->dev, "could not unmap!\n"); | ||
61 | drm_gem_object_unreference_unlocked(omap_fb->bo); | 59 | drm_gem_object_unreference_unlocked(omap_fb->bo); |
62 | } | 60 | } |
63 | 61 | ||