diff options
author | Randy Dunlap <randy.dunlap@oracle.com> | 2011-05-09 13:46:24 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-05-10 14:19:52 -0400 |
commit | d8aba9d5d6c0d9809798967b9aac293690233b6d (patch) | |
tree | 63af373225d7e5714839f1927951e84a016deb5b /drivers/staging/keucr/smilecc.c | |
parent | e5813f8449f7c6ef71346b21e30b92c84133fd0f (diff) |
staging/keucr: fix sparse statics and non-ANSI function warnings
Make lots of functions and data static (fixes sparse warnings).
Fix 5 functions to use ANSI format for function parameters (fixes
sparse warnings).
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/keucr/smilecc.c')
-rw-r--r-- | drivers/staging/keucr/smilecc.c | 49 |
1 files changed, 25 insertions, 24 deletions
diff --git a/drivers/staging/keucr/smilecc.c b/drivers/staging/keucr/smilecc.c index 5659dea7b70..ba25f158a1b 100644 --- a/drivers/staging/keucr/smilecc.c +++ b/drivers/staging/keucr/smilecc.c | |||
@@ -48,11 +48,13 @@ static void trans_result (BYTE, BYTE, BYTE *, BYTE *); | |||
48 | #define MASK_CPS 0x3f | 48 | #define MASK_CPS 0x3f |
49 | #define CORRECTABLE 0x00555554L | 49 | #define CORRECTABLE 0x00555554L |
50 | 50 | ||
51 | static void trans_result(reg2,reg3,ecc1,ecc2) | 51 | /* |
52 | BYTE reg2; // LP14,LP12,LP10,... | 52 | * reg2; // LP14,LP12,LP10,... |
53 | BYTE reg3; // LP15,LP13,LP11,... | 53 | * reg3; // LP15,LP13,LP11,... |
54 | BYTE *ecc1; // LP15,LP14,LP13,... | 54 | * *ecc1; // LP15,LP14,LP13,... |
55 | BYTE *ecc2; // LP07,LP06,LP05,... | 55 | * *ecc2; // LP07,LP06,LP05,... |
56 | */ | ||
57 | static void trans_result(BYTE reg2, BYTE reg3, BYTE *ecc1, BYTE *ecc2) | ||
56 | { | 58 | { |
57 | BYTE a; // Working for reg2,reg3 | 59 | BYTE a; // Working for reg2,reg3 |
58 | BYTE b; // Working for ecc1,ecc2 | 60 | BYTE b; // Working for ecc1,ecc2 |
@@ -83,12 +85,14 @@ BYTE *ecc2; // LP07,LP06,LP05,... | |||
83 | } | 85 | } |
84 | 86 | ||
85 | //static void calculate_ecc(table,data,ecc1,ecc2,ecc3) | 87 | //static void calculate_ecc(table,data,ecc1,ecc2,ecc3) |
86 | void calculate_ecc(table,data,ecc1,ecc2,ecc3) | 88 | /* |
87 | BYTE *table; // CP0-CP5 code table | 89 | * *table; // CP0-CP5 code table |
88 | BYTE *data; // DATA | 90 | * *data; // DATA |
89 | BYTE *ecc1; // LP15,LP14,LP13,... | 91 | * *ecc1; // LP15,LP14,LP13,... |
90 | BYTE *ecc2; // LP07,LP06,LP05,... | 92 | * *ecc2; // LP07,LP06,LP05,... |
91 | BYTE *ecc3; // CP5,CP4,CP3,...,"1","1" | 93 | * *ecc3; // CP5,CP4,CP3,...,"1","1" |
94 | */ | ||
95 | void calculate_ecc(BYTE *table, BYTE *data, BYTE *ecc1, BYTE *ecc2, BYTE *ecc3) | ||
92 | { | 96 | { |
93 | DWORD i; // For counting | 97 | DWORD i; // For counting |
94 | BYTE a; // Working for table | 98 | BYTE a; // Working for table |
@@ -113,12 +117,14 @@ BYTE *ecc3; // CP5,CP4,CP3,...,"1","1" | |||
113 | *ecc3=((~reg1)<<2)|BIT1BIT0; // Make TEL format | 117 | *ecc3=((~reg1)<<2)|BIT1BIT0; // Make TEL format |
114 | } | 118 | } |
115 | 119 | ||
116 | BYTE correct_data(data,eccdata,ecc1,ecc2,ecc3) | 120 | /* |
117 | BYTE *data; // DATA | 121 | * *data; // DATA |
118 | BYTE *eccdata; // ECC DATA | 122 | * *eccdata; // ECC DATA |
119 | BYTE ecc1; // LP15,LP14,LP13,... | 123 | * ecc1; // LP15,LP14,LP13,... |
120 | BYTE ecc2; // LP07,LP06,LP05,... | 124 | * ecc2; // LP07,LP06,LP05,... |
121 | BYTE ecc3; // CP5,CP4,CP3,...,"1","1" | 125 | * ecc3; // CP5,CP4,CP3,...,"1","1" |
126 | */ | ||
127 | BYTE correct_data(BYTE *data, BYTE *eccdata, BYTE ecc1, BYTE ecc2, BYTE ecc3) | ||
122 | { | 128 | { |
123 | DWORD l; // Working to check d | 129 | DWORD l; // Working to check d |
124 | DWORD d; // Result of comparison | 130 | DWORD d; // Result of comparison |
@@ -177,10 +183,7 @@ BYTE ecc3; // CP5,CP4,CP3,...,"1","1" | |||
177 | return(3); // Uncorrectable error | 183 | return(3); // Uncorrectable error |
178 | } | 184 | } |
179 | 185 | ||
180 | int _Correct_D_SwECC(buf,redundant_ecc,calculate_ecc) | 186 | int _Correct_D_SwECC(BYTE *buf, BYTE *redundant_ecc, BYTE *calculate_ecc) |
181 | BYTE *buf; | ||
182 | BYTE *redundant_ecc; | ||
183 | BYTE *calculate_ecc; | ||
184 | { | 187 | { |
185 | DWORD err; | 188 | DWORD err; |
186 | 189 | ||
@@ -195,9 +198,7 @@ BYTE *calculate_ecc; | |||
195 | return -1; | 198 | return -1; |
196 | } | 199 | } |
197 | 200 | ||
198 | void _Calculate_D_SwECC(buf,ecc) | 201 | void _Calculate_D_SwECC(BYTE *buf, BYTE *ecc) |
199 | BYTE *buf; | ||
200 | BYTE *ecc; | ||
201 | { | 202 | { |
202 | calculate_ecc(ecctable,buf,ecc+1,ecc+0,ecc+2); | 203 | calculate_ecc(ecctable,buf,ecc+1,ecc+0,ecc+2); |
203 | } | 204 | } |