diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-01-15 06:29:39 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-02-09 12:13:55 -0500 |
commit | 2da57c8e4ac0933417f9fdd141bf5bebc87edc1e (patch) | |
tree | b6aeda5be0654c634485ebd0f13c06eecb8e85ef /drivers/staging/crystalhd/crystalhd_hw.c | |
parent | a2f9dc55345baff05378c23de6e9e026f6838556 (diff) |
staging: precedence bug in crystalhd_stop_tx_dma_engine()
The intent here is to see if we have cleared the DMA_START_BIT flag. We
clear it a couple lines later. The current code has a precedence bug so
it is equivalent to "if (!dma_cntrl) { ...".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/crystalhd/crystalhd_hw.c')
-rw-r--r-- | drivers/staging/crystalhd/crystalhd_hw.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index 5acf39e7cde..eeddee9a605 100644 --- a/drivers/staging/crystalhd/crystalhd_hw.c +++ b/drivers/staging/crystalhd/crystalhd_hw.c | |||
@@ -868,8 +868,7 @@ static enum BC_STATUS crystalhd_stop_tx_dma_engine(struct crystalhd_hw *hw) | |||
868 | 868 | ||
869 | BCMLOG(BCMLOG_DBG, "Stopping TX DMA Engine..\n"); | 869 | BCMLOG(BCMLOG_DBG, "Stopping TX DMA Engine..\n"); |
870 | 870 | ||
871 | /* FIXME: jarod: invert dma_ctrl and check bit? or are there missing parens? */ | 871 | if (!(dma_cntrl & DMA_START_BIT)) { |
872 | if (!dma_cntrl & DMA_START_BIT) { | ||
873 | BCMLOG(BCMLOG_DBG, "Already Stopped\n"); | 872 | BCMLOG(BCMLOG_DBG, "Already Stopped\n"); |
874 | return BC_STS_SUCCESS; | 873 | return BC_STS_SUCCESS; |
875 | } | 874 | } |