diff options
author | Alwin Beukers <alwin@broadcom.com> | 2011-10-04 17:19:05 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-10-05 16:39:04 -0400 |
commit | eda075b546ec6beb8bc12f4fbad47688636122ff (patch) | |
tree | 881c103073205dc0ca799bcee981b8791e020f9a /drivers/staging/brcm80211 | |
parent | 62b54fca4bbeeed007fdef6ac57508685ec2c239 (diff) |
staging: brcm80211: cleanup of several wrapper functions
- removed brcms_c_write_template_ram function.
- removed brcms_c_mctrl function.
- removed brcms_c_pllreq function.
- removed brcms_c_mhf function.
- removed brcms_c_rate_shm_offset function.
- removed brcms_c_write_hw_bcntemplates function.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/brcm80211')
-rw-r--r-- | drivers/staging/brcm80211/brcmsmac/ampdu.c | 2 | ||||
-rw-r--r-- | drivers/staging/brcm80211/brcmsmac/main.c | 51 | ||||
-rw-r--r-- | drivers/staging/brcm80211/brcmsmac/main.h | 3 |
3 files changed, 13 insertions, 43 deletions
diff --git a/drivers/staging/brcm80211/brcmsmac/ampdu.c b/drivers/staging/brcm80211/brcmsmac/ampdu.c index fc499008fe7..7f27dbdb6b6 100644 --- a/drivers/staging/brcm80211/brcmsmac/ampdu.c +++ b/drivers/staging/brcm80211/brcmsmac/ampdu.c | |||
@@ -1162,7 +1162,7 @@ void brcms_c_ampdu_macaddr_upd(struct brcms_c_info *wlc) | |||
1162 | /* driver needs to write the ta in the template; ta is at offset 16 */ | 1162 | /* driver needs to write the ta in the template; ta is at offset 16 */ |
1163 | memset(template, 0, sizeof(template)); | 1163 | memset(template, 0, sizeof(template)); |
1164 | memcpy(template, wlc->pub->cur_etheraddr, ETH_ALEN); | 1164 | memcpy(template, wlc->pub->cur_etheraddr, ETH_ALEN); |
1165 | brcms_c_write_template_ram(wlc, (T_BA_TPL_BASE + 16), | 1165 | brcms_b_write_template_ram(wlc->hw, (T_BA_TPL_BASE + 16), |
1166 | (T_RAM_ACCESS_SZ * 2), | 1166 | (T_RAM_ACCESS_SZ * 2), |
1167 | template); | 1167 | template); |
1168 | } | 1168 | } |
diff --git a/drivers/staging/brcm80211/brcmsmac/main.c b/drivers/staging/brcm80211/brcmsmac/main.c index cbed10cbb46..bd38f33b13e 100644 --- a/drivers/staging/brcm80211/brcmsmac/main.c +++ b/drivers/staging/brcm80211/brcmsmac/main.c | |||
@@ -3846,9 +3846,9 @@ void brcms_c_mac_bcn_promisc_change(struct brcms_c_info *wlc, bool promisc) | |||
3846 | void brcms_c_mac_bcn_promisc(struct brcms_c_info *wlc) | 3846 | void brcms_c_mac_bcn_promisc(struct brcms_c_info *wlc) |
3847 | { | 3847 | { |
3848 | if (wlc->bcnmisc_monitor) | 3848 | if (wlc->bcnmisc_monitor) |
3849 | brcms_c_mctrl(wlc, MCTL_BCNS_PROMISC, MCTL_BCNS_PROMISC); | 3849 | brcms_b_mctrl(wlc->hw, MCTL_BCNS_PROMISC, MCTL_BCNS_PROMISC); |
3850 | else | 3850 | else |
3851 | brcms_c_mctrl(wlc, MCTL_BCNS_PROMISC, 0); | 3851 | brcms_b_mctrl(wlc->hw, MCTL_BCNS_PROMISC, 0); |
3852 | } | 3852 | } |
3853 | 3853 | ||
3854 | /* set or clear maccontrol bits MCTL_PROMISC and MCTL_KEEPCONTROL */ | 3854 | /* set or clear maccontrol bits MCTL_PROMISC and MCTL_KEEPCONTROL */ |
@@ -3872,7 +3872,7 @@ void brcms_c_mac_promisc(struct brcms_c_info *wlc) | |||
3872 | if (wlc->monitor) | 3872 | if (wlc->monitor) |
3873 | promisc_bits |= MCTL_PROMISC | MCTL_KEEPCONTROL; | 3873 | promisc_bits |= MCTL_PROMISC | MCTL_KEEPCONTROL; |
3874 | 3874 | ||
3875 | brcms_c_mctrl(wlc, MCTL_PROMISC | MCTL_KEEPCONTROL, promisc_bits); | 3875 | brcms_b_mctrl(wlc->hw, MCTL_PROMISC | MCTL_KEEPCONTROL, promisc_bits); |
3876 | } | 3876 | } |
3877 | 3877 | ||
3878 | /* push sw hps and wake state through hardware */ | 3878 | /* push sw hps and wake state through hardware */ |
@@ -3891,7 +3891,7 @@ void brcms_c_set_ps_ctrl(struct brcms_c_info *wlc) | |||
3891 | if (hps) | 3891 | if (hps) |
3892 | v2 |= MCTL_HPS; | 3892 | v2 |= MCTL_HPS; |
3893 | 3893 | ||
3894 | brcms_c_mctrl(wlc, MCTL_WAKE | MCTL_HPS, v2); | 3894 | brcms_b_mctrl(wlc->hw, MCTL_WAKE | MCTL_HPS, v2); |
3895 | 3895 | ||
3896 | awake_before = ((v1 & MCTL_WAKE) || ((v1 & MCTL_HPS) == 0)); | 3896 | awake_before = ((v1 & MCTL_WAKE) || ((v1 & MCTL_HPS) == 0)); |
3897 | 3897 | ||
@@ -4301,8 +4301,8 @@ static void brcms_c_down_led_upd(struct brcms_c_info *wlc) | |||
4301 | * maintain LEDs while in down state, turn on sbclk if | 4301 | * maintain LEDs while in down state, turn on sbclk if |
4302 | * not available yet. Turn on sbclk if necessary | 4302 | * not available yet. Turn on sbclk if necessary |
4303 | */ | 4303 | */ |
4304 | brcms_c_pllreq(wlc, true, BRCMS_PLLREQ_FLIP); | 4304 | brcms_b_pllreq(wlc->hw, true, BRCMS_PLLREQ_FLIP); |
4305 | brcms_c_pllreq(wlc, false, BRCMS_PLLREQ_FLIP); | 4305 | brcms_b_pllreq(wlc->hw, false, BRCMS_PLLREQ_FLIP); |
4306 | } | 4306 | } |
4307 | 4307 | ||
4308 | static void brcms_c_radio_monitor_start(struct brcms_c_info *wlc) | 4308 | static void brcms_c_radio_monitor_start(struct brcms_c_info *wlc) |
@@ -4312,7 +4312,7 @@ static void brcms_c_radio_monitor_start(struct brcms_c_info *wlc) | |||
4312 | return; | 4312 | return; |
4313 | 4313 | ||
4314 | wlc->radio_monitor = true; | 4314 | wlc->radio_monitor = true; |
4315 | brcms_c_pllreq(wlc, true, BRCMS_PLLREQ_RADIO_MON); | 4315 | brcms_b_pllreq(wlc->hw, true, BRCMS_PLLREQ_RADIO_MON); |
4316 | brcms_add_timer(wlc->wl, wlc->radio_timer, TIMER_INTERVAL_RADIOCHK, | 4316 | brcms_add_timer(wlc->wl, wlc->radio_timer, TIMER_INTERVAL_RADIOCHK, |
4317 | true); | 4317 | true); |
4318 | } | 4318 | } |
@@ -4345,7 +4345,7 @@ bool brcms_c_radio_monitor_stop(struct brcms_c_info *wlc) | |||
4345 | return true; | 4345 | return true; |
4346 | 4346 | ||
4347 | wlc->radio_monitor = false; | 4347 | wlc->radio_monitor = false; |
4348 | brcms_c_pllreq(wlc, false, BRCMS_PLLREQ_RADIO_MON); | 4348 | brcms_b_pllreq(wlc->hw, false, BRCMS_PLLREQ_RADIO_MON); |
4349 | return brcms_del_timer(wlc->wl, wlc->radio_timer); | 4349 | return brcms_del_timer(wlc->wl, wlc->radio_timer); |
4350 | } | 4350 | } |
4351 | 4351 | ||
@@ -5675,10 +5675,10 @@ int brcms_c_up(struct brcms_c_info *wlc) | |||
5675 | && (wlc->pub->sih->chip == BCM4313_CHIP_ID)) { | 5675 | && (wlc->pub->sih->chip == BCM4313_CHIP_ID)) { |
5676 | if (wlc->pub->boardrev >= 0x1250 | 5676 | if (wlc->pub->boardrev >= 0x1250 |
5677 | && (wlc->pub->boardflags & BFL_FEM_BT)) | 5677 | && (wlc->pub->boardflags & BFL_FEM_BT)) |
5678 | brcms_c_mhf(wlc, MHF5, MHF5_4313_GPIOCTRL, | 5678 | brcms_b_mhf(wlc->hw, MHF5, MHF5_4313_GPIOCTRL, |
5679 | MHF5_4313_GPIOCTRL, BRCM_BAND_ALL); | 5679 | MHF5_4313_GPIOCTRL, BRCM_BAND_ALL); |
5680 | else | 5680 | else |
5681 | brcms_c_mhf(wlc, MHF4, MHF4_EXTPA_ENABLE, | 5681 | brcms_b_mhf(wlc->hw, MHF4, MHF4_EXTPA_ENABLE, |
5682 | MHF4_EXTPA_ENABLE, BRCM_BAND_ALL); | 5682 | MHF4_EXTPA_ENABLE, BRCM_BAND_ALL); |
5683 | } | 5683 | } |
5684 | 5684 | ||
@@ -5720,7 +5720,7 @@ int brcms_c_up(struct brcms_c_info *wlc) | |||
5720 | brcms_c_radio_monitor_stop(wlc); | 5720 | brcms_c_radio_monitor_stop(wlc); |
5721 | 5721 | ||
5722 | /* Set EDCF hostflags */ | 5722 | /* Set EDCF hostflags */ |
5723 | brcms_c_mhf(wlc, MHF1, MHF1_EDCF, MHF1_EDCF, BRCM_BAND_ALL); | 5723 | brcms_b_mhf(wlc->hw, MHF1, MHF1_EDCF, MHF1_EDCF, BRCM_BAND_ALL); |
5724 | 5724 | ||
5725 | brcms_init(wlc->wl); | 5725 | brcms_init(wlc->wl); |
5726 | wlc->pub->up = true; | 5726 | wlc->pub->up = true; |
@@ -6578,11 +6578,6 @@ u16 brcms_b_rate_shm_offset(struct brcms_hardware *wlc_hw, u8 rate) | |||
6578 | return 2 * brcms_b_read_shm(wlc_hw, table_ptr + (index * 2)); | 6578 | return 2 * brcms_b_read_shm(wlc_hw, table_ptr + (index * 2)); |
6579 | } | 6579 | } |
6580 | 6580 | ||
6581 | static u16 brcms_c_rate_shm_offset(struct brcms_c_info *wlc, u8 rate) | ||
6582 | { | ||
6583 | return brcms_b_rate_shm_offset(wlc->hw, rate); | ||
6584 | } | ||
6585 | |||
6586 | /* Callback for device removed */ | 6581 | /* Callback for device removed */ |
6587 | 6582 | ||
6588 | /* | 6583 | /* |
@@ -8581,7 +8576,7 @@ void brcms_c_mod_prb_rsp_rate_table(struct brcms_c_info *wlc, uint frame_len) | |||
8581 | for (i = 0; i < rs.count; i++) { | 8576 | for (i = 0; i < rs.count; i++) { |
8582 | rate = rs.rates[i] & BRCMS_RATE_MASK; | 8577 | rate = rs.rates[i] & BRCMS_RATE_MASK; |
8583 | 8578 | ||
8584 | entry_ptr = brcms_c_rate_shm_offset(wlc, rate); | 8579 | entry_ptr = brcms_b_rate_shm_offset(wlc->hw, rate); |
8585 | 8580 | ||
8586 | /* Calculate the Probe Response PLCP for the given rate */ | 8581 | /* Calculate the Probe Response PLCP for the given rate */ |
8587 | brcms_c_compute_plcp(wlc, rate, frame_len, plcp); | 8582 | brcms_c_compute_plcp(wlc, rate, frame_len, plcp); |
@@ -8798,17 +8793,6 @@ void brcms_c_copyto_shm(struct brcms_c_info *wlc, uint offset, const void *buf, | |||
8798 | brcms_b_copyto_objmem(wlc->hw, offset, buf, len, OBJADDR_SHM_SEL); | 8793 | brcms_b_copyto_objmem(wlc->hw, offset, buf, len, OBJADDR_SHM_SEL); |
8799 | } | 8794 | } |
8800 | 8795 | ||
8801 | /* wrapper BMAC functions to for HIGH driver access */ | ||
8802 | void brcms_c_mctrl(struct brcms_c_info *wlc, u32 mask, u32 val) | ||
8803 | { | ||
8804 | brcms_b_mctrl(wlc->hw, mask, val); | ||
8805 | } | ||
8806 | |||
8807 | void brcms_c_mhf(struct brcms_c_info *wlc, u8 idx, u16 mask, u16 val, int bands) | ||
8808 | { | ||
8809 | brcms_b_mhf(wlc->hw, idx, mask, val, bands); | ||
8810 | } | ||
8811 | |||
8812 | int brcms_b_xmtfifo_sz_get(struct brcms_hardware *wlc_hw, uint fifo, | 8796 | int brcms_b_xmtfifo_sz_get(struct brcms_hardware *wlc_hw, uint fifo, |
8813 | uint *blocks) | 8797 | uint *blocks) |
8814 | { | 8798 | { |
@@ -8820,12 +8804,6 @@ int brcms_b_xmtfifo_sz_get(struct brcms_hardware *wlc_hw, uint fifo, | |||
8820 | return 0; | 8804 | return 0; |
8821 | } | 8805 | } |
8822 | 8806 | ||
8823 | void brcms_c_write_template_ram(struct brcms_c_info *wlc, int offset, int len, | ||
8824 | void *buf) | ||
8825 | { | ||
8826 | brcms_b_write_template_ram(wlc->hw, offset, len, buf); | ||
8827 | } | ||
8828 | |||
8829 | void | 8807 | void |
8830 | brcms_c_set_addrmatch(struct brcms_c_info *wlc, int match_reg_offset, | 8808 | brcms_c_set_addrmatch(struct brcms_c_info *wlc, int match_reg_offset, |
8831 | const u8 *addr) | 8809 | const u8 *addr) |
@@ -8835,11 +8813,6 @@ brcms_c_set_addrmatch(struct brcms_c_info *wlc, int match_reg_offset, | |||
8835 | memcpy(wlc->bsscfg->BSSID, addr, ETH_ALEN); | 8813 | memcpy(wlc->bsscfg->BSSID, addr, ETH_ALEN); |
8836 | } | 8814 | } |
8837 | 8815 | ||
8838 | void brcms_c_pllreq(struct brcms_c_info *wlc, bool set, u32 req_bit) | ||
8839 | { | ||
8840 | brcms_b_pllreq(wlc->hw, set, req_bit); | ||
8841 | } | ||
8842 | |||
8843 | /* check for the particular priority flow control bit being set */ | 8816 | /* check for the particular priority flow control bit being set */ |
8844 | bool | 8817 | bool |
8845 | brcms_c_txflowcontrol_prio_isset(struct brcms_c_info *wlc, | 8818 | brcms_c_txflowcontrol_prio_isset(struct brcms_c_info *wlc, |
diff --git a/drivers/staging/brcm80211/brcmsmac/main.h b/drivers/staging/brcm80211/brcmsmac/main.h index a71c5099109..99d5c60467c 100644 --- a/drivers/staging/brcm80211/brcmsmac/main.h +++ b/drivers/staging/brcm80211/brcmsmac/main.h | |||
@@ -674,9 +674,6 @@ extern void brcms_c_info_init(struct brcms_c_info *wlc, int unit); | |||
674 | extern void brcms_c_print_txstatus(struct tx_status *txs); | 674 | extern void brcms_c_print_txstatus(struct tx_status *txs); |
675 | extern int brcms_b_xmtfifo_sz_get(struct brcms_hardware *wlc_hw, uint fifo, | 675 | extern int brcms_b_xmtfifo_sz_get(struct brcms_hardware *wlc_hw, uint fifo, |
676 | uint *blocks); | 676 | uint *blocks); |
677 | extern void brcms_c_write_template_ram(struct brcms_c_info *wlc, int offset, | ||
678 | int len, void *buf); | ||
679 | extern void brcms_c_pllreq(struct brcms_c_info *wlc, bool set, u32 req_bit); | ||
680 | 677 | ||
681 | #if defined(BCMDBG) | 678 | #if defined(BCMDBG) |
682 | extern void brcms_c_print_rxh(struct d11rxhdr *rxh); | 679 | extern void brcms_c_print_rxh(struct d11rxhdr *rxh); |