diff options
author | Joe Perches <joe@perches.com> | 2011-01-27 23:04:20 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-01-31 16:53:11 -0500 |
commit | 509c9d973055e3d98c0d2aa2cb40c9139526fd74 (patch) | |
tree | 0512699e6c58b2712bd1e2122ea68f6972b0f65a /drivers/staging/ath6kl/os/linux/ar6000_drv.c | |
parent | 1f4c34bded914e81b4388ccfdfab8a31da5ab0c3 (diff) |
staging: ath6kl: Remove A_SUCCESS macro
Remove obfuscating A_SUCCESS(foo) macro.
Just test for !foo instead.
Reformat a few macros that used A_SUCCESS for better readability.
Add do { foo } while (0) surrounds to those macros too.
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Vipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/ath6kl/os/linux/ar6000_drv.c')
-rw-r--r-- | drivers/staging/ath6kl/os/linux/ar6000_drv.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/ath6kl/os/linux/ar6000_drv.c b/drivers/staging/ath6kl/os/linux/ar6000_drv.c index c171be5a109..4ad78f25f18 100644 --- a/drivers/staging/ath6kl/os/linux/ar6000_drv.c +++ b/drivers/staging/ath6kl/os/linux/ar6000_drv.c | |||
@@ -1674,8 +1674,8 @@ ar6000_avail_ev(void *context, void *hif_handle) | |||
1674 | if (ar_netif) { | 1674 | if (ar_netif) { |
1675 | HIF_DEVICE_OS_DEVICE_INFO osDevInfo; | 1675 | HIF_DEVICE_OS_DEVICE_INFO osDevInfo; |
1676 | A_MEMZERO(&osDevInfo, sizeof(osDevInfo)); | 1676 | A_MEMZERO(&osDevInfo, sizeof(osDevInfo)); |
1677 | if ( A_SUCCESS( HIFConfigureDevice(hif_handle, HIF_DEVICE_GET_OS_DEVICE, | 1677 | if (!HIFConfigureDevice(hif_handle, HIF_DEVICE_GET_OS_DEVICE, |
1678 | &osDevInfo, sizeof(osDevInfo))) ) { | 1678 | &osDevInfo, sizeof(osDevInfo))) { |
1679 | SET_NETDEV_DEV(dev, osDevInfo.pOSDevice); | 1679 | SET_NETDEV_DEV(dev, osDevInfo.pOSDevice); |
1680 | } | 1680 | } |
1681 | } | 1681 | } |
@@ -3115,7 +3115,7 @@ ar6000_data_tx(struct sk_buff *skb, struct net_device *dev) | |||
3115 | if (ac == HCI_TRANSPORT_STREAM_NUM) { | 3115 | if (ac == HCI_TRANSPORT_STREAM_NUM) { |
3116 | /* pass this to HCI */ | 3116 | /* pass this to HCI */ |
3117 | #ifndef EXPORT_HCI_BRIDGE_INTERFACE | 3117 | #ifndef EXPORT_HCI_BRIDGE_INTERFACE |
3118 | if (A_SUCCESS(hci_test_send(ar,skb))) { | 3118 | if (!hci_test_send(ar,skb)) { |
3119 | return 0; | 3119 | return 0; |
3120 | } | 3120 | } |
3121 | #endif | 3121 | #endif |
@@ -3428,7 +3428,7 @@ ar6000_tx_complete(void *Context, HTC_PACKET_QUEUE *pPacketQueue) | |||
3428 | /* add this to the list, use faster non-lock API */ | 3428 | /* add this to the list, use faster non-lock API */ |
3429 | __skb_queue_tail(&skb_queue,pktSkb); | 3429 | __skb_queue_tail(&skb_queue,pktSkb); |
3430 | 3430 | ||
3431 | if (A_SUCCESS(status)) { | 3431 | if (!status) { |
3432 | A_ASSERT(pPacket->ActualLength == A_NETBUF_LEN(pktSkb)); | 3432 | A_ASSERT(pPacket->ActualLength == A_NETBUF_LEN(pktSkb)); |
3433 | } | 3433 | } |
3434 | 3434 | ||
@@ -3597,7 +3597,7 @@ ar6000_rx(void *Context, HTC_PACKET *pPacket) | |||
3597 | * and adaptive power throughput state */ | 3597 | * and adaptive power throughput state */ |
3598 | AR6000_SPIN_LOCK(&ar->arLock, 0); | 3598 | AR6000_SPIN_LOCK(&ar->arLock, 0); |
3599 | 3599 | ||
3600 | if (A_SUCCESS(status)) { | 3600 | if (!status) { |
3601 | AR6000_STAT_INC(ar, rx_packets); | 3601 | AR6000_STAT_INC(ar, rx_packets); |
3602 | ar->arNetStats.rx_bytes += pPacket->ActualLength; | 3602 | ar->arNetStats.rx_bytes += pPacket->ActualLength; |
3603 | #ifdef ADAPTIVE_POWER_THROUGHPUT_CONTROL | 3603 | #ifdef ADAPTIVE_POWER_THROUGHPUT_CONTROL |