diff options
author | Kim, Milo <Milo.Kim@ti.com> | 2012-08-31 05:25:07 -0400 |
---|---|---|
committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-09-20 21:03:45 -0400 |
commit | 18763a36d0bae11a916ffe8fa58a26fd0b5eb115 (patch) | |
tree | bf001258595c34c2c02bf69553a83fda49819083 /drivers/power | |
parent | 6029719f08d2d21624504e326f50c68f89731353 (diff) |
lp8727_charger: Use specific definition
Add new LP8727_ICHG_SHIFT definition and replace a magic number. Reuse
definition for the size of interrupt register buffer.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Diffstat (limited to 'drivers/power')
-rw-r--r-- | drivers/power/lp8727_charger.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c index 65c9840a37e..254bbe07c26 100644 --- a/drivers/power/lp8727_charger.c +++ b/drivers/power/lp8727_charger.c | |||
@@ -59,6 +59,9 @@ | |||
59 | #define LP8727_TEMP_STAT (3 << 5) | 59 | #define LP8727_TEMP_STAT (3 << 5) |
60 | #define LP8727_TEMP_SHIFT 5 | 60 | #define LP8727_TEMP_SHIFT 5 |
61 | 61 | ||
62 | /* CHGCTRL2 register */ | ||
63 | #define LP8727_ICHG_SHIFT 4 | ||
64 | |||
62 | enum lp8727_dev_id { | 65 | enum lp8727_dev_id { |
63 | LP8727_ID_NONE, | 66 | LP8727_ID_NONE, |
64 | LP8727_ID_TA, | 67 | LP8727_ID_TA, |
@@ -222,11 +225,11 @@ static void lp8727_enable_chgdet(struct lp8727_chg *pchg) | |||
222 | 225 | ||
223 | static void lp8727_delayed_func(struct work_struct *_work) | 226 | static void lp8727_delayed_func(struct work_struct *_work) |
224 | { | 227 | { |
225 | u8 intstat[2], idno, vbus; | 228 | u8 intstat[LP8788_NUM_INTREGS], idno, vbus; |
226 | struct lp8727_chg *pchg = | 229 | struct lp8727_chg *pchg = |
227 | container_of(_work, struct lp8727_chg, work.work); | 230 | container_of(_work, struct lp8727_chg, work.work); |
228 | 231 | ||
229 | if (lp8727_read_bytes(pchg, LP8727_INT1, intstat, 2)) { | 232 | if (lp8727_read_bytes(pchg, LP8727_INT1, intstat, LP8788_NUM_INTREGS)) { |
230 | dev_err(pchg->dev, "can not read INT registers\n"); | 233 | dev_err(pchg->dev, "can not read INT registers\n"); |
231 | return; | 234 | return; |
232 | } | 235 | } |
@@ -401,7 +404,7 @@ static void lp8727_charger_changed(struct power_supply *psy) | |||
401 | if (pchg->chg_parm) { | 404 | if (pchg->chg_parm) { |
402 | eoc_level = pchg->chg_parm->eoc_level; | 405 | eoc_level = pchg->chg_parm->eoc_level; |
403 | ichg = pchg->chg_parm->ichg; | 406 | ichg = pchg->chg_parm->ichg; |
404 | val = (ichg << 4) | eoc_level; | 407 | val = (ichg << LP8727_ICHG_SHIFT) | eoc_level; |
405 | lp8727_write_byte(pchg, LP8727_CHGCTRL2, val); | 408 | lp8727_write_byte(pchg, LP8727_CHGCTRL2, val); |
406 | } | 409 | } |
407 | } | 410 | } |