diff options
author | Yevgeny Petrilin <yevgenyp@mellanox.co.il> | 2011-10-17 21:50:29 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-10-19 03:42:26 -0400 |
commit | e72ebf5a578464204c8418d7d9b375333bb33161 (patch) | |
tree | 9a31012872207aef3d0dae1bd2e17dfb169f1e27 /drivers/net | |
parent | 5ea2ef5f8b006ff9e970327e7fea78f1f5841c44 (diff) |
mlx4: Fix vlan table overflow
Prevent overflow when trying to register more Vlans then the Vlan table in
HW is configured to.
Need to take into acount that the first 2 entries are reserved.
Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/port.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c index 609e0ec14ce..163a314c148 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c | |||
@@ -65,7 +65,7 @@ void mlx4_init_vlan_table(struct mlx4_dev *dev, struct mlx4_vlan_table *table) | |||
65 | table->entries[i] = 0; | 65 | table->entries[i] = 0; |
66 | table->refs[i] = 0; | 66 | table->refs[i] = 0; |
67 | } | 67 | } |
68 | table->max = 1 << dev->caps.log_num_vlans; | 68 | table->max = (1 << dev->caps.log_num_vlans) - MLX4_VLAN_REGULAR; |
69 | table->total = 0; | 69 | table->total = 0; |
70 | } | 70 | } |
71 | 71 | ||
@@ -354,6 +354,13 @@ int mlx4_register_vlan(struct mlx4_dev *dev, u8 port, u16 vlan, int *index) | |||
354 | int free = -1; | 354 | int free = -1; |
355 | 355 | ||
356 | mutex_lock(&table->mutex); | 356 | mutex_lock(&table->mutex); |
357 | |||
358 | if (table->total == table->max) { | ||
359 | /* No free vlan entries */ | ||
360 | err = -ENOSPC; | ||
361 | goto out; | ||
362 | } | ||
363 | |||
357 | for (i = MLX4_VLAN_REGULAR; i < MLX4_MAX_VLAN_NUM; i++) { | 364 | for (i = MLX4_VLAN_REGULAR; i < MLX4_MAX_VLAN_NUM; i++) { |
358 | if (free < 0 && (table->refs[i] == 0)) { | 365 | if (free < 0 && (table->refs[i] == 0)) { |
359 | free = i; | 366 | free = i; |
@@ -375,12 +382,6 @@ int mlx4_register_vlan(struct mlx4_dev *dev, u8 port, u16 vlan, int *index) | |||
375 | goto out; | 382 | goto out; |
376 | } | 383 | } |
377 | 384 | ||
378 | if (table->total == table->max) { | ||
379 | /* No free vlan entries */ | ||
380 | err = -ENOSPC; | ||
381 | goto out; | ||
382 | } | ||
383 | |||
384 | /* Register new MAC */ | 385 | /* Register new MAC */ |
385 | table->refs[free] = 1; | 386 | table->refs[free] = 1; |
386 | table->entries[free] = cpu_to_be32(vlan | MLX4_VLAN_VALID); | 387 | table->entries[free] = cpu_to_be32(vlan | MLX4_VLAN_VALID); |