diff options
author | Matt Carlson <mcarlson@broadcom.com> | 2011-05-19 12:02:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-05-20 00:33:18 -0400 |
commit | d542fe27c86ecf932f40c898881208ccdaef9dc5 (patch) | |
tree | 8ee74f4e1e4c4a9f279939d2fa528a557e7458af /drivers/net | |
parent | 449f4544267e73d5db372971da63634707c32299 (diff) |
tg3: Fix NETIF_F_LOOPBACK error
Mahesh Bandewar noticed that the features cleanup in commit
0da0606f493c5cdab74bdcc96b12f4305ad94085, entitled
"tg3: Consolidate all netdev feature assignments", mistakenly sets
NETIF_F_LOOPBACK by default. This patch corrects the error.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/tg3.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 012ce70aeaf..284e99853ed 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c | |||
@@ -15080,6 +15080,9 @@ static int __devinit tg3_init_one(struct pci_dev *pdev, | |||
15080 | features |= NETIF_F_TSO_ECN; | 15080 | features |= NETIF_F_TSO_ECN; |
15081 | } | 15081 | } |
15082 | 15082 | ||
15083 | dev->features |= features; | ||
15084 | dev->vlan_features |= features; | ||
15085 | |||
15083 | /* | 15086 | /* |
15084 | * Add loopback capability only for a subset of devices that support | 15087 | * Add loopback capability only for a subset of devices that support |
15085 | * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY | 15088 | * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY |
@@ -15090,9 +15093,7 @@ static int __devinit tg3_init_one(struct pci_dev *pdev, | |||
15090 | /* Add the loopback capability */ | 15093 | /* Add the loopback capability */ |
15091 | features |= NETIF_F_LOOPBACK; | 15094 | features |= NETIF_F_LOOPBACK; |
15092 | 15095 | ||
15093 | dev->features |= features; | ||
15094 | dev->hw_features |= features; | 15096 | dev->hw_features |= features; |
15095 | dev->vlan_features |= features; | ||
15096 | 15097 | ||
15097 | if (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 && | 15098 | if (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 && |
15098 | !tg3_flag(tp, TSO_CAPABLE) && | 15099 | !tg3_flag(tp, TSO_CAPABLE) && |