diff options
author | Bruce Allan <bruce.w.allan@intel.com> | 2012-04-12 01:47:09 -0400 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2012-04-14 05:04:02 -0400 |
commit | 6ad651456e3c8f3ea77056bc05c85e46ab8ead5a (patch) | |
tree | c92f3b156c41357a9a71d00dc2cefe860bddb60b /drivers/net | |
parent | 48425b14929ef185377e3827ba7135d88343face (diff) |
e1000e: cleanup remaining strings split across multiple lines
Now that split strings generate checkpatch warnings (per Chapter 2 of
Documentation/CodingStyle to make it easier to grep the code for the
string) cleanup the remaining instances of them in the driver.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ethtool.c | 19 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/param.c | 8 |
2 files changed, 12 insertions, 15 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 6302b10cb3a..4f1edd9c22f 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
@@ -259,8 +259,7 @@ static int e1000_set_settings(struct net_device *netdev, | |||
259 | * cannot be changed | 259 | * cannot be changed |
260 | */ | 260 | */ |
261 | if (hw->phy.ops.check_reset_block(hw)) { | 261 | if (hw->phy.ops.check_reset_block(hw)) { |
262 | e_err("Cannot change link characteristics when SoL/IDER is " | 262 | e_err("Cannot change link characteristics when SoL/IDER is active.\n"); |
263 | "active.\n"); | ||
264 | return -EINVAL; | 263 | return -EINVAL; |
265 | } | 264 | } |
266 | 265 | ||
@@ -727,9 +726,8 @@ static bool reg_pattern_test(struct e1000_adapter *adapter, u64 *data, | |||
727 | (test[pat] & write)); | 726 | (test[pat] & write)); |
728 | val = E1000_READ_REG_ARRAY(&adapter->hw, reg, offset); | 727 | val = E1000_READ_REG_ARRAY(&adapter->hw, reg, offset); |
729 | if (val != (test[pat] & write & mask)) { | 728 | if (val != (test[pat] & write & mask)) { |
730 | e_err("pattern test reg %04X failed: got 0x%08X " | 729 | e_err("pattern test reg %04X failed: got 0x%08X expected 0x%08X\n", |
731 | "expected 0x%08X\n", reg + offset, val, | 730 | reg + offset, val, (test[pat] & write & mask)); |
732 | (test[pat] & write & mask)); | ||
733 | *data = reg; | 731 | *data = reg; |
734 | return 1; | 732 | return 1; |
735 | } | 733 | } |
@@ -744,8 +742,8 @@ static bool reg_set_and_check(struct e1000_adapter *adapter, u64 *data, | |||
744 | __ew32(&adapter->hw, reg, write & mask); | 742 | __ew32(&adapter->hw, reg, write & mask); |
745 | val = __er32(&adapter->hw, reg); | 743 | val = __er32(&adapter->hw, reg); |
746 | if ((write & mask) != (val & mask)) { | 744 | if ((write & mask) != (val & mask)) { |
747 | e_err("set/check reg %04X test failed: got 0x%08X " | 745 | e_err("set/check reg %04X test failed: got 0x%08X expected 0x%08X\n", |
748 | "expected 0x%08X\n", reg, (val & mask), (write & mask)); | 746 | reg, (val & mask), (write & mask)); |
749 | *data = reg; | 747 | *data = reg; |
750 | return 1; | 748 | return 1; |
751 | } | 749 | } |
@@ -797,8 +795,8 @@ static int e1000_reg_test(struct e1000_adapter *adapter, u64 *data) | |||
797 | ew32(STATUS, toggle); | 795 | ew32(STATUS, toggle); |
798 | after = er32(STATUS) & toggle; | 796 | after = er32(STATUS) & toggle; |
799 | if (value != after) { | 797 | if (value != after) { |
800 | e_err("failed STATUS register test got: 0x%08X expected: " | 798 | e_err("failed STATUS register test got: 0x%08X expected: 0x%08X\n", |
801 | "0x%08X\n", after, value); | 799 | after, value); |
802 | *data = 1; | 800 | *data = 1; |
803 | return 1; | 801 | return 1; |
804 | } | 802 | } |
@@ -1791,8 +1789,7 @@ static void e1000_get_wol(struct net_device *netdev, | |||
1791 | wol->supported &= ~WAKE_UCAST; | 1789 | wol->supported &= ~WAKE_UCAST; |
1792 | 1790 | ||
1793 | if (adapter->wol & E1000_WUFC_EX) | 1791 | if (adapter->wol & E1000_WUFC_EX) |
1794 | e_err("Interface does not support directed (unicast) " | 1792 | e_err("Interface does not support directed (unicast) frame wake-up packets\n"); |
1795 | "frame wake-up packets\n"); | ||
1796 | } | 1793 | } |
1797 | 1794 | ||
1798 | if (adapter->wol & E1000_WUFC_EX) | 1795 | if (adapter->wol & E1000_WUFC_EX) |
diff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c index ff796e42c3e..feb6eebb002 100644 --- a/drivers/net/ethernet/intel/e1000e/param.c +++ b/drivers/net/ethernet/intel/e1000e/param.c | |||
@@ -166,8 +166,8 @@ E1000_PARAM(WriteProtectNVM, "Write-protect NVM [WARNING: disabling this can lea | |||
166 | * | 166 | * |
167 | * Default Value: 1 (enabled) | 167 | * Default Value: 1 (enabled) |
168 | */ | 168 | */ |
169 | E1000_PARAM(CrcStripping, "Enable CRC Stripping, disable if your BMC needs " \ | 169 | E1000_PARAM(CrcStripping, |
170 | "the CRC"); | 170 | "Enable CRC Stripping, disable if your BMC needs the CRC"); |
171 | 171 | ||
172 | struct e1000_option { | 172 | struct e1000_option { |
173 | enum { enable_option, range_option, list_option } type; | 173 | enum { enable_option, range_option, list_option } type; |
@@ -360,8 +360,8 @@ void __devinit e1000e_check_options(struct e1000_adapter *adapter) | |||
360 | adapter->itr = 20000; | 360 | adapter->itr = 20000; |
361 | break; | 361 | break; |
362 | case 4: | 362 | case 4: |
363 | e_info("%s set to simplified (2000-8000 ints) " | 363 | e_info("%s set to simplified (2000-8000 ints) mode\n", |
364 | "mode\n", opt.name); | 364 | opt.name); |
365 | adapter->itr_setting = 4; | 365 | adapter->itr_setting = 4; |
366 | break; | 366 | break; |
367 | default: | 367 | default: |