diff options
author | Helmut Schaa <helmut.schaa@googlemail.com> | 2010-12-27 09:06:57 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-01-04 14:35:14 -0500 |
commit | bfe6a15d60671993eb3d4ac396b1f442ae08581c (patch) | |
tree | fc7dea9103f7e8644ec310e33d92b486a4ee212c /drivers/net/wireless/rt2x00/rt2x00dev.c | |
parent | f833eea0a77b0910ea202468175bfc80470d44d0 (diff) |
rt2x00: Simplify intf->delayed_flags locking
Instead of protecting delayed_flags with a spinlock use atomic bitops to
make the code more readable.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/rt2x00/rt2x00dev.c')
-rw-r--r-- | drivers/net/wireless/rt2x00/rt2x00dev.c | 15 |
1 files changed, 1 insertions, 14 deletions
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c index 97a8911571c..9597a03242c 100644 --- a/drivers/net/wireless/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c | |||
@@ -110,19 +110,6 @@ static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac, | |||
110 | { | 110 | { |
111 | struct rt2x00_dev *rt2x00dev = data; | 111 | struct rt2x00_dev *rt2x00dev = data; |
112 | struct rt2x00_intf *intf = vif_to_intf(vif); | 112 | struct rt2x00_intf *intf = vif_to_intf(vif); |
113 | int delayed_flags; | ||
114 | |||
115 | /* | ||
116 | * Copy all data we need during this action under the protection | ||
117 | * of a spinlock. Otherwise race conditions might occur which results | ||
118 | * into an invalid configuration. | ||
119 | */ | ||
120 | spin_lock(&intf->lock); | ||
121 | |||
122 | delayed_flags = intf->delayed_flags; | ||
123 | intf->delayed_flags = 0; | ||
124 | |||
125 | spin_unlock(&intf->lock); | ||
126 | 113 | ||
127 | /* | 114 | /* |
128 | * It is possible the radio was disabled while the work had been | 115 | * It is possible the radio was disabled while the work had been |
@@ -133,7 +120,7 @@ static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac, | |||
133 | if (!test_bit(DEVICE_STATE_ENABLED_RADIO, &rt2x00dev->flags)) | 120 | if (!test_bit(DEVICE_STATE_ENABLED_RADIO, &rt2x00dev->flags)) |
134 | return; | 121 | return; |
135 | 122 | ||
136 | if (delayed_flags & DELAYED_UPDATE_BEACON) | 123 | if (test_and_clear_bit(DELAYED_UPDATE_BEACON, &intf->delayed_flags)) |
137 | rt2x00queue_update_beacon(rt2x00dev, vif, true); | 124 | rt2x00queue_update_beacon(rt2x00dev, vif, true); |
138 | } | 125 | } |
139 | 126 | ||