diff options
author | Krishna Kumar <krkumar2@in.ibm.com> | 2011-10-19 18:17:27 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-10-20 04:53:56 -0400 |
commit | 8a59a7b94fc56e3ed3054c3c655b646bb631f9bc (patch) | |
tree | 62a491815692b197ebb1425fa03a36c03ff48e3a /drivers/net/virtio_net.c | |
parent | a0bec1cd8f7ac966f2885f7e56ec44df87bab738 (diff) |
virtio_net: Clean up set_skb_frag()
Remove manual initialization in set_skb_frag, and instead
use __skb_fill_page_desc() to do the same. Patch tested
on net-next.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/virtio_net.c')
-rw-r--r-- | drivers/net/virtio_net.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 0d4841bed0f..abbf34fcf4c 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c | |||
@@ -143,18 +143,15 @@ static void skb_xmit_done(struct virtqueue *svq) | |||
143 | static void set_skb_frag(struct sk_buff *skb, struct page *page, | 143 | static void set_skb_frag(struct sk_buff *skb, struct page *page, |
144 | unsigned int offset, unsigned int *len) | 144 | unsigned int offset, unsigned int *len) |
145 | { | 145 | { |
146 | int size = min((unsigned)PAGE_SIZE - offset, *len); | ||
146 | int i = skb_shinfo(skb)->nr_frags; | 147 | int i = skb_shinfo(skb)->nr_frags; |
147 | skb_frag_t *f; | ||
148 | 148 | ||
149 | f = &skb_shinfo(skb)->frags[i]; | 149 | __skb_fill_page_desc(skb, i, page, offset, size); |
150 | skb_frag_size_set(f, min((unsigned)PAGE_SIZE - offset, *len)); | ||
151 | f->page_offset = offset; | ||
152 | __skb_frag_set_page(f, page); | ||
153 | 150 | ||
154 | skb->data_len += skb_frag_size(f); | 151 | skb->data_len += size; |
155 | skb->len += skb_frag_size(f); | 152 | skb->len += size; |
156 | skb_shinfo(skb)->nr_frags++; | 153 | skb_shinfo(skb)->nr_frags++; |
157 | *len -= skb_frag_size(f); | 154 | *len -= size; |
158 | } | 155 | } |
159 | 156 | ||
160 | static struct sk_buff *page_to_skb(struct virtnet_info *vi, | 157 | static struct sk_buff *page_to_skb(struct virtnet_info *vi, |