diff options
author | Joe Perches <joe@perches.com> | 2011-05-09 05:45:22 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-05-09 15:51:15 -0400 |
commit | 726b65ad444dd142e34d0087fcbba03d16b34ca6 (patch) | |
tree | ee4e56b9d7aea7dbb10ce0fe57706232f42d6b74 /drivers/net/tulip/de2104x.c | |
parent | 163ef0b5922b14751e93218bdf2c9fe8f74b9c9d (diff) |
tulip: Convert uses of KERN_DEBUG
Convert logging messages to more current styles.
Added -DDEBUG to Makefile to maintain current message logging.
This could be converted to a specific CONFIG_TULIP_DEBUG option.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tulip/de2104x.c')
-rw-r--r-- | drivers/net/tulip/de2104x.c | 47 |
1 files changed, 21 insertions, 26 deletions
diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c index 62883a0b061..e925c1ea04b 100644 --- a/drivers/net/tulip/de2104x.c +++ b/drivers/net/tulip/de2104x.c | |||
@@ -377,9 +377,9 @@ static u16 t21041_csr15[] = { 0x0008, 0x0006, 0x000E, 0x0008, 0x0008, }; | |||
377 | static void de_rx_err_acct (struct de_private *de, unsigned rx_tail, | 377 | static void de_rx_err_acct (struct de_private *de, unsigned rx_tail, |
378 | u32 status, u32 len) | 378 | u32 status, u32 len) |
379 | { | 379 | { |
380 | netif_printk(de, rx_err, KERN_DEBUG, de->dev, | 380 | netif_dbg(de, rx_err, de->dev, |
381 | "rx err, slot %d status 0x%x len %d\n", | 381 | "rx err, slot %d status 0x%x len %d\n", |
382 | rx_tail, status, len); | 382 | rx_tail, status, len); |
383 | 383 | ||
384 | if ((status & 0x38000300) != 0x0300) { | 384 | if ((status & 0x38000300) != 0x0300) { |
385 | /* Ingore earlier buffers. */ | 385 | /* Ingore earlier buffers. */ |
@@ -433,10 +433,9 @@ static void de_rx (struct de_private *de) | |||
433 | 433 | ||
434 | copying_skb = (len <= rx_copybreak); | 434 | copying_skb = (len <= rx_copybreak); |
435 | 435 | ||
436 | if (unlikely(netif_msg_rx_status(de))) | 436 | netif_dbg(de, rx_status, de->dev, |
437 | printk(KERN_DEBUG "%s: rx slot %d status 0x%x len %d copying? %d\n", | 437 | "rx slot %d status 0x%x len %d copying? %d\n", |
438 | de->dev->name, rx_tail, status, len, | 438 | rx_tail, status, len, copying_skb); |
439 | copying_skb); | ||
440 | 439 | ||
441 | buflen = copying_skb ? (len + RX_OFFSET) : de->rx_buf_sz; | 440 | buflen = copying_skb ? (len + RX_OFFSET) : de->rx_buf_sz; |
442 | copy_skb = dev_alloc_skb (buflen); | 441 | copy_skb = dev_alloc_skb (buflen); |
@@ -504,10 +503,9 @@ static irqreturn_t de_interrupt (int irq, void *dev_instance) | |||
504 | if ((!(status & (IntrOK|IntrErr))) || (status == 0xFFFF)) | 503 | if ((!(status & (IntrOK|IntrErr))) || (status == 0xFFFF)) |
505 | return IRQ_NONE; | 504 | return IRQ_NONE; |
506 | 505 | ||
507 | if (netif_msg_intr(de)) | 506 | netif_dbg(de, intr, dev, "intr, status %08x mode %08x desc %u/%u/%u\n", |
508 | printk(KERN_DEBUG "%s: intr, status %08x mode %08x desc %u/%u/%u\n", | 507 | status, dr32(MacMode), |
509 | dev->name, status, dr32(MacMode), | 508 | de->rx_tail, de->tx_head, de->tx_tail); |
510 | de->rx_tail, de->tx_head, de->tx_tail); | ||
511 | 509 | ||
512 | dw32(MacStatus, status); | 510 | dw32(MacStatus, status); |
513 | 511 | ||
@@ -570,9 +568,9 @@ static void de_tx (struct de_private *de) | |||
570 | 568 | ||
571 | if (status & LastFrag) { | 569 | if (status & LastFrag) { |
572 | if (status & TxError) { | 570 | if (status & TxError) { |
573 | if (netif_msg_tx_err(de)) | 571 | netif_dbg(de, tx_err, de->dev, |
574 | printk(KERN_DEBUG "%s: tx err, status 0x%x\n", | 572 | "tx err, status 0x%x\n", |
575 | de->dev->name, status); | 573 | status); |
576 | de->net_stats.tx_errors++; | 574 | de->net_stats.tx_errors++; |
577 | if (status & TxOWC) | 575 | if (status & TxOWC) |
578 | de->net_stats.tx_window_errors++; | 576 | de->net_stats.tx_window_errors++; |
@@ -585,9 +583,8 @@ static void de_tx (struct de_private *de) | |||
585 | } else { | 583 | } else { |
586 | de->net_stats.tx_packets++; | 584 | de->net_stats.tx_packets++; |
587 | de->net_stats.tx_bytes += skb->len; | 585 | de->net_stats.tx_bytes += skb->len; |
588 | if (netif_msg_tx_done(de)) | 586 | netif_dbg(de, tx_done, de->dev, |
589 | printk(KERN_DEBUG "%s: tx done, slot %d\n", | 587 | "tx done, slot %d\n", tx_tail); |
590 | de->dev->name, tx_tail); | ||
591 | } | 588 | } |
592 | dev_kfree_skb_irq(skb); | 589 | dev_kfree_skb_irq(skb); |
593 | } | 590 | } |
@@ -644,9 +641,8 @@ static netdev_tx_t de_start_xmit (struct sk_buff *skb, | |||
644 | wmb(); | 641 | wmb(); |
645 | 642 | ||
646 | de->tx_head = NEXT_TX(entry); | 643 | de->tx_head = NEXT_TX(entry); |
647 | if (netif_msg_tx_queued(de)) | 644 | netif_dbg(de, tx_queued, dev, "tx queued, slot %d, skblen %d\n", |
648 | printk(KERN_DEBUG "%s: tx queued, slot %d, skblen %d\n", | 645 | entry, skb->len); |
649 | dev->name, entry, skb->len); | ||
650 | 646 | ||
651 | if (tx_free == 0) | 647 | if (tx_free == 0) |
652 | netif_stop_queue(dev); | 648 | netif_stop_queue(dev); |
@@ -1387,7 +1383,7 @@ static int de_open (struct net_device *dev) | |||
1387 | struct de_private *de = netdev_priv(dev); | 1383 | struct de_private *de = netdev_priv(dev); |
1388 | int rc; | 1384 | int rc; |
1389 | 1385 | ||
1390 | netif_printk(de, ifup, KERN_DEBUG, dev, "enabling interface\n"); | 1386 | netif_dbg(de, ifup, dev, "enabling interface\n"); |
1391 | 1387 | ||
1392 | de->rx_buf_sz = (dev->mtu <= 1500 ? PKT_BUF_SZ : dev->mtu + 32); | 1388 | de->rx_buf_sz = (dev->mtu <= 1500 ? PKT_BUF_SZ : dev->mtu + 32); |
1393 | 1389 | ||
@@ -1429,7 +1425,7 @@ static int de_close (struct net_device *dev) | |||
1429 | struct de_private *de = netdev_priv(dev); | 1425 | struct de_private *de = netdev_priv(dev); |
1430 | unsigned long flags; | 1426 | unsigned long flags; |
1431 | 1427 | ||
1432 | netif_printk(de, ifdown, KERN_DEBUG, dev, "disabling interface\n"); | 1428 | netif_dbg(de, ifdown, dev, "disabling interface\n"); |
1433 | 1429 | ||
1434 | del_timer_sync(&de->media_timer); | 1430 | del_timer_sync(&de->media_timer); |
1435 | 1431 | ||
@@ -1450,10 +1446,9 @@ static void de_tx_timeout (struct net_device *dev) | |||
1450 | { | 1446 | { |
1451 | struct de_private *de = netdev_priv(dev); | 1447 | struct de_private *de = netdev_priv(dev); |
1452 | 1448 | ||
1453 | netdev_printk(KERN_DEBUG, dev, | 1449 | netdev_dbg(dev, "NIC status %08x mode %08x sia %08x desc %u/%u/%u\n", |
1454 | "NIC status %08x mode %08x sia %08x desc %u/%u/%u\n", | 1450 | dr32(MacStatus), dr32(MacMode), dr32(SIAStatus), |
1455 | dr32(MacStatus), dr32(MacMode), dr32(SIAStatus), | 1451 | de->rx_tail, de->tx_head, de->tx_tail); |
1456 | de->rx_tail, de->tx_head, de->tx_tail); | ||
1457 | 1452 | ||
1458 | del_timer_sync(&de->media_timer); | 1453 | del_timer_sync(&de->media_timer); |
1459 | 1454 | ||