qlcnic: fix netdev notifier in error path

netdev notifier are not unregistered if pci_register_driver fails.

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 9 insertions, 1 deletions

diff --git a/drivers/net/qlcnic/qlcnic_main.c b/drivers/net/qlcnic/qlcnic_main.c
index 0fef8c3c553..0995f90b0ba 100644
--- a/drivers/net/qlcnic/qlcnic_main.c
+++ b/drivers/net/qlcnic/qlcnic_main.c
@@ -3451,6 +3451,7 @@ static struct pci_driver qlcnic_driver = {
 
 static int __init qlcnic_init_module(void)
 {
+        int ret;
 
         printk(KERN_INFO "%s\n", qlcnic_driver_string);
 
@@ -3459,8 +3460,15 @@ static int __init qlcnic_init_module(void)
         register_inetaddr_notifier(&qlcnic_inetaddr_cb);
 #endif
 
+        ret = pci_register_driver(&qlcnic_driver);
+        if (ret) {
+#ifdef CONFIG_INET
+                unregister_inetaddr_notifier(&qlcnic_inetaddr_cb);
+                unregister_netdevice_notifier(&qlcnic_netdev_cb);
+#endif
+        }
 
-        return pci_register_driver(&qlcnic_driver);
+        return ret;
 }
 
 module_init(qlcnic_init_module);