diff options
author | Eric Dumazet <edumazet@google.com> | 2012-05-18 16:23:00 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-05-19 02:32:30 -0400 |
commit | 968d70184d599abc7fe0a89447ef4e183e0135c4 (patch) | |
tree | 802783219bef73069906164aa4d6b6a67aab9f7d /drivers/net/ppp/ppp_synctty.c | |
parent | a50feda546ac03415707a9bbcac8d6b20714db21 (diff) |
ppp: avoid false drop_monitor false positives
Call consume_skb() in place of kfree_skb() were appropriate.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ppp/ppp_synctty.c')
-rw-r--r-- | drivers/net/ppp/ppp_synctty.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ppp/ppp_synctty.c b/drivers/net/ppp/ppp_synctty.c index 55e466c511d..1a12033d2ef 100644 --- a/drivers/net/ppp/ppp_synctty.c +++ b/drivers/net/ppp/ppp_synctty.c | |||
@@ -588,7 +588,7 @@ ppp_sync_txmunge(struct syncppp *ap, struct sk_buff *skb) | |||
588 | skb_reserve(npkt,2); | 588 | skb_reserve(npkt,2); |
589 | skb_copy_from_linear_data(skb, | 589 | skb_copy_from_linear_data(skb, |
590 | skb_put(npkt, skb->len), skb->len); | 590 | skb_put(npkt, skb->len), skb->len); |
591 | kfree_skb(skb); | 591 | consume_skb(skb); |
592 | skb = npkt; | 592 | skb = npkt; |
593 | } | 593 | } |
594 | skb_push(skb,2); | 594 | skb_push(skb,2); |
@@ -656,7 +656,7 @@ ppp_sync_push(struct syncppp *ap) | |||
656 | if (sent < ap->tpkt->len) { | 656 | if (sent < ap->tpkt->len) { |
657 | tty_stuffed = 1; | 657 | tty_stuffed = 1; |
658 | } else { | 658 | } else { |
659 | kfree_skb(ap->tpkt); | 659 | consume_skb(ap->tpkt); |
660 | ap->tpkt = NULL; | 660 | ap->tpkt = NULL; |
661 | clear_bit(XMIT_FULL, &ap->xmit_flags); | 661 | clear_bit(XMIT_FULL, &ap->xmit_flags); |
662 | done = 1; | 662 | done = 1; |