netdev: Add netdev->addr_list_lock protection.

Add netif_addr_{lock,unlock}{,_bh}() helpers.

Use them to protect operations that operate on or read
the network device unicast and multicast address lists.

Also use them in cases where the code simply wants to
block calls into the driver's ->set_rx_mode() and
->set_multicast_list() methods.

Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 4 insertions, 0 deletions

diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index babc79ad490..9ca57d36559 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -295,7 +295,9 @@ static void emac_rx_disable(struct emac_instance *dev)
 static inline void emac_netif_stop(struct emac_instance *dev)
 {
         netif_tx_lock_bh(dev->ndev);
+        netif_addr_lock(dev->ndev);
         dev->no_mcast = 1;
+        netif_addr_unlock(dev->ndev);
         netif_tx_unlock_bh(dev->ndev);
         dev->ndev->trans_start = jiffies;       /* prevent tx timeout */
         mal_poll_disable(dev->mal, &dev->commac);
@@ -305,9 +307,11 @@ static inline void emac_netif_stop(struct emac_instance *dev)
 static inline void emac_netif_start(struct emac_instance *dev)
 {
         netif_tx_lock_bh(dev->ndev);
+        netif_addr_lock(dev->ndev);
         dev->no_mcast = 0;
         if (dev->mcast_pending && netif_running(dev->ndev))
                 __emac_set_multicast_list(dev);
+        netif_addr_unlock(dev->ndev);
         netif_tx_unlock_bh(dev->ndev);
 
         netif_wake_queue(dev->ndev);