diff options
author | Huang, Xiong <xiong@qca.qualcomm.com> | 2012-04-18 18:01:23 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-04-19 20:14:19 -0400 |
commit | c08b9b2a5b3f0fd83e7f72da03f0a0df12c67e3a (patch) | |
tree | 0de7ea9631c906f282ebfb93fcd216701315f2f7 /drivers/net/ethernet/atheros/atl1c/atl1c_main.c | |
parent | 969a7ee2a8398fb705f9836dc11d9e307d3ac89c (diff) |
atl1c: update right threshold for TSO
atl1c_configure_tx used a wrong value of MAX_TX_OFFLOAD_THRESH(9KB)
for TSO threshold.
the right value should be 7KB
Fast Ethernet controller doesn't support Jumbo frame.
Signed-off-by: xiong <xiong@qca.qualcomm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/atheros/atl1c/atl1c_main.c')
-rw-r--r-- | drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index d2f89f026d7..e8e9c104cfe 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c | |||
@@ -501,11 +501,16 @@ static int atl1c_set_features(struct net_device *netdev, | |||
501 | static int atl1c_change_mtu(struct net_device *netdev, int new_mtu) | 501 | static int atl1c_change_mtu(struct net_device *netdev, int new_mtu) |
502 | { | 502 | { |
503 | struct atl1c_adapter *adapter = netdev_priv(netdev); | 503 | struct atl1c_adapter *adapter = netdev_priv(netdev); |
504 | struct atl1c_hw *hw = &adapter->hw; | ||
504 | int old_mtu = netdev->mtu; | 505 | int old_mtu = netdev->mtu; |
505 | int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN; | 506 | int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN; |
506 | 507 | ||
507 | if ((max_frame < ETH_ZLEN + ETH_FCS_LEN) || | 508 | /* Fast Ethernet controller doesn't support jumbo packet */ |
508 | (max_frame > MAX_JUMBO_FRAME_SIZE)) { | 509 | if (((hw->nic_type == athr_l2c || |
510 | hw->nic_type == athr_l2c_b || | ||
511 | hw->nic_type == athr_l2c_b2) && new_mtu > ETH_DATA_LEN) || | ||
512 | max_frame < ETH_ZLEN + ETH_FCS_LEN || | ||
513 | max_frame > MAX_JUMBO_FRAME_SIZE) { | ||
509 | if (netif_msg_link(adapter)) | 514 | if (netif_msg_link(adapter)) |
510 | dev_warn(&adapter->pdev->dev, "invalid MTU setting\n"); | 515 | dev_warn(&adapter->pdev->dev, "invalid MTU setting\n"); |
511 | return -EINVAL; | 516 | return -EINVAL; |
@@ -1049,7 +1054,7 @@ static void atl1c_configure_tx(struct atl1c_adapter *adapter) | |||
1049 | u16 tx_offload_thresh; | 1054 | u16 tx_offload_thresh; |
1050 | u32 txq_ctrl_data; | 1055 | u32 txq_ctrl_data; |
1051 | 1056 | ||
1052 | tx_offload_thresh = MAX_TX_OFFLOAD_THRESH; | 1057 | tx_offload_thresh = MAX_TSO_FRAME_SIZE; |
1053 | AT_WRITE_REG(hw, REG_TX_TSO_OFFLOAD_THRESH, | 1058 | AT_WRITE_REG(hw, REG_TX_TSO_OFFLOAD_THRESH, |
1054 | (tx_offload_thresh >> 3) & TX_TSO_OFFLOAD_THRESH_MASK); | 1059 | (tx_offload_thresh >> 3) & TX_TSO_OFFLOAD_THRESH_MASK); |
1055 | max_pay_load = pcie_get_readrq(adapter->pdev) >> 8; | 1060 | max_pay_load = pcie_get_readrq(adapter->pdev) >> 8; |