aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/e1000
diff options
context:
space:
mode:
authorJesse Brandeburg <jesse.brandeburg@intel.com>2009-04-21 14:42:05 -0400
committerDavid S. Miller <davem@davemloft.net>2009-04-22 03:47:54 -0400
commit4cb9be7ab47820a1fa747569f5f035a5f628c91b (patch)
treef272447c9bdc5b01578760f1c0f973a183f801b5 /drivers/net/e1000
parentbf98a82633b97fb638fcee0fae3c0de54d1f7b05 (diff)
e1000/e1000e/igb/ixgb: do not use netif_wake_queue un-necessarily
It was pointed out that the Intel wired ethernet drivers do not need to wake the tx queue since netif_carrier_on/off will take care of the qdisc management in order to guarantee the correct handling of the transmit routine enable state. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/e1000')
-rw-r--r--drivers/net/e1000/e1000_main.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 112e6b03998..71d4fe15976 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -498,6 +498,8 @@ int e1000_up(struct e1000_adapter *adapter)
498 498
499 e1000_irq_enable(adapter); 499 e1000_irq_enable(adapter);
500 500
501 netif_wake_queue(adapter->netdev);
502
501 /* fire a link change interrupt to start the watchdog */ 503 /* fire a link change interrupt to start the watchdog */
502 ew32(ICS, E1000_ICS_LSC); 504 ew32(ICS, E1000_ICS_LSC);
503 return 0; 505 return 0;
@@ -2591,7 +2593,6 @@ static void e1000_watchdog(unsigned long data)
2591 ew32(TCTL, tctl); 2593 ew32(TCTL, tctl);
2592 2594
2593 netif_carrier_on(netdev); 2595 netif_carrier_on(netdev);
2594 netif_wake_queue(netdev);
2595 mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ)); 2596 mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ));
2596 adapter->smartspeed = 0; 2597 adapter->smartspeed = 0;
2597 } else { 2598 } else {
@@ -2608,7 +2609,6 @@ static void e1000_watchdog(unsigned long data)
2608 printk(KERN_INFO "e1000: %s NIC Link is Down\n", 2609 printk(KERN_INFO "e1000: %s NIC Link is Down\n",
2609 netdev->name); 2610 netdev->name);
2610 netif_carrier_off(netdev); 2611 netif_carrier_off(netdev);
2611 netif_stop_queue(netdev);
2612 mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ)); 2612 mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ));
2613 2613
2614 /* 80003ES2LAN workaround-- 2614 /* 80003ES2LAN workaround--