diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2011-12-19 09:08:01 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-12-19 22:27:29 -0500 |
commit | eb93992207dadb946a3b5cf4544957dc924a6f58 (patch) | |
tree | 8d840ea0e0e5eb3cf6207a2608d434475a9076b4 /drivers/net/caif | |
parent | 3db1cd5c05f35fb43eb134df6f321de4e63141f2 (diff) |
module_param: make bool parameters really bool (net & drivers/net)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
(Thanks to Joe Perches for suggesting coccinelle for 0/1 -> true/false).
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/caif')
-rw-r--r-- | drivers/net/caif/caif_serial.c | 6 | ||||
-rw-r--r-- | drivers/net/caif/caif_spi.c | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c index 9341a2d6efe..8a3054b8481 100644 --- a/drivers/net/caif/caif_serial.c +++ b/drivers/net/caif/caif_serial.c | |||
@@ -38,15 +38,15 @@ MODULE_ALIAS_LDISC(N_CAIF); | |||
38 | /*This list is protected by the rtnl lock. */ | 38 | /*This list is protected by the rtnl lock. */ |
39 | static LIST_HEAD(ser_list); | 39 | static LIST_HEAD(ser_list); |
40 | 40 | ||
41 | static int ser_loop; | 41 | static bool ser_loop; |
42 | module_param(ser_loop, bool, S_IRUGO); | 42 | module_param(ser_loop, bool, S_IRUGO); |
43 | MODULE_PARM_DESC(ser_loop, "Run in simulated loopback mode."); | 43 | MODULE_PARM_DESC(ser_loop, "Run in simulated loopback mode."); |
44 | 44 | ||
45 | static int ser_use_stx = 1; | 45 | static bool ser_use_stx = true; |
46 | module_param(ser_use_stx, bool, S_IRUGO); | 46 | module_param(ser_use_stx, bool, S_IRUGO); |
47 | MODULE_PARM_DESC(ser_use_stx, "STX enabled or not."); | 47 | MODULE_PARM_DESC(ser_use_stx, "STX enabled or not."); |
48 | 48 | ||
49 | static int ser_use_fcs = 1; | 49 | static bool ser_use_fcs = true; |
50 | 50 | ||
51 | module_param(ser_use_fcs, bool, S_IRUGO); | 51 | module_param(ser_use_fcs, bool, S_IRUGO); |
52 | MODULE_PARM_DESC(ser_use_fcs, "FCS enabled or not."); | 52 | MODULE_PARM_DESC(ser_use_fcs, "FCS enabled or not."); |
diff --git a/drivers/net/caif/caif_spi.c b/drivers/net/caif/caif_spi.c index 761057b6f26..96391c36fa7 100644 --- a/drivers/net/caif/caif_spi.c +++ b/drivers/net/caif/caif_spi.c | |||
@@ -35,7 +35,7 @@ MODULE_DESCRIPTION("CAIF SPI driver"); | |||
35 | /* Returns the number of padding bytes for alignment. */ | 35 | /* Returns the number of padding bytes for alignment. */ |
36 | #define PAD_POW2(x, pow) ((((x)&((pow)-1))==0) ? 0 : (((pow)-((x)&((pow)-1))))) | 36 | #define PAD_POW2(x, pow) ((((x)&((pow)-1))==0) ? 0 : (((pow)-((x)&((pow)-1))))) |
37 | 37 | ||
38 | static int spi_loop; | 38 | static bool spi_loop; |
39 | module_param(spi_loop, bool, S_IRUGO); | 39 | module_param(spi_loop, bool, S_IRUGO); |
40 | MODULE_PARM_DESC(spi_loop, "SPI running in loopback mode."); | 40 | MODULE_PARM_DESC(spi_loop, "SPI running in loopback mode."); |
41 | 41 | ||