aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/gspca
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2011-08-21 18:56:52 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-09-03 20:12:53 -0400
commitbdfe91f411bd05392952efc1afdce8bda1923517 (patch)
treee14abebbd88b14cd56b52d8d590926c536bd89b2 /drivers/media/video/gspca
parentd650fc30c0328eceb0e48f348e01e073b5a7f1f6 (diff)
[media] m5602: Use current logging styles
Add pr_fmt and convert usb style logging macro uses to pr_<level>. Coalesce format strings. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Erik Andrén <erik.andren@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/gspca')
-rw-r--r--drivers/media/video/gspca/m5602/m5602_core.c9
-rw-r--r--drivers/media/video/gspca/m5602/m5602_mt9m111.c28
-rw-r--r--drivers/media/video/gspca/m5602/m5602_ov7660.c21
-rw-r--r--drivers/media/video/gspca/m5602/m5602_ov9650.c19
-rw-r--r--drivers/media/video/gspca/m5602/m5602_po1030.c21
-rw-r--r--drivers/media/video/gspca/m5602/m5602_s5k4aa.c35
-rw-r--r--drivers/media/video/gspca/m5602/m5602_s5k83a.c30
7 files changed, 89 insertions, 74 deletions
diff --git a/drivers/media/video/gspca/m5602/m5602_core.c b/drivers/media/video/gspca/m5602/m5602_core.c
index a7722b1aef9..67533e5582a 100644
--- a/drivers/media/video/gspca/m5602/m5602_core.c
+++ b/drivers/media/video/gspca/m5602/m5602_core.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include "m5602_ov9650.h" 21#include "m5602_ov9650.h"
20#include "m5602_ov7660.h" 22#include "m5602_ov7660.h"
21#include "m5602_mt9m111.h" 23#include "m5602_mt9m111.h"
@@ -192,10 +194,9 @@ static void m5602_dump_bridge(struct sd *sd)
192 for (i = 0; i < 0x80; i++) { 194 for (i = 0; i < 0x80; i++) {
193 unsigned char val = 0; 195 unsigned char val = 0;
194 m5602_read_bridge(sd, i, &val); 196 m5602_read_bridge(sd, i, &val);
195 info("ALi m5602 address 0x%x contains 0x%x", i, val); 197 pr_info("ALi m5602 address 0x%x contains 0x%x\n", i, val);
196 } 198 }
197 info("Warning: The ALi m5602 webcam probably won't work " 199 pr_info("Warning: The ALi m5602 webcam probably won't work until it's power cycled\n");
198 "until it's power cycled");
199} 200}
200 201
201static int m5602_probe_sensor(struct sd *sd) 202static int m5602_probe_sensor(struct sd *sd)
@@ -231,7 +232,7 @@ static int m5602_probe_sensor(struct sd *sd)
231 return 0; 232 return 0;
232 233
233 /* More sensor probe function goes here */ 234 /* More sensor probe function goes here */
234 info("Failed to find a sensor"); 235 pr_info("Failed to find a sensor\n");
235 sd->sensor = NULL; 236 sd->sensor = NULL;
236 return -ENODEV; 237 return -ENODEV;
237} 238}
diff --git a/drivers/media/video/gspca/m5602/m5602_mt9m111.c b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
index 0d605a52b92..6268aa24ec5 100644
--- a/drivers/media/video/gspca/m5602/m5602_mt9m111.c
+++ b/drivers/media/video/gspca/m5602/m5602_mt9m111.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include "m5602_mt9m111.h" 21#include "m5602_mt9m111.h"
20 22
21static int mt9m111_set_vflip(struct gspca_dev *gspca_dev, __s32 val); 23static int mt9m111_set_vflip(struct gspca_dev *gspca_dev, __s32 val);
@@ -163,7 +165,7 @@ int mt9m111_probe(struct sd *sd)
163 165
164 if (force_sensor) { 166 if (force_sensor) {
165 if (force_sensor == MT9M111_SENSOR) { 167 if (force_sensor == MT9M111_SENSOR) {
166 info("Forcing a %s sensor", mt9m111.name); 168 pr_info("Forcing a %s sensor\n", mt9m111.name);
167 goto sensor_found; 169 goto sensor_found;
168 } 170 }
169 /* If we want to force another sensor, don't try to probe this 171 /* If we want to force another sensor, don't try to probe this
@@ -191,7 +193,7 @@ int mt9m111_probe(struct sd *sd)
191 return -ENODEV; 193 return -ENODEV;
192 194
193 if ((data[0] == 0x14) && (data[1] == 0x3a)) { 195 if ((data[0] == 0x14) && (data[1] == 0x3a)) {
194 info("Detected a mt9m111 sensor"); 196 pr_info("Detected a mt9m111 sensor\n");
195 goto sensor_found; 197 goto sensor_found;
196 } 198 }
197 199
@@ -612,34 +614,34 @@ static void mt9m111_dump_registers(struct sd *sd)
612{ 614{
613 u8 address, value[2] = {0x00, 0x00}; 615 u8 address, value[2] = {0x00, 0x00};
614 616
615 info("Dumping the mt9m111 register state"); 617 pr_info("Dumping the mt9m111 register state\n");
616 618
617 info("Dumping the mt9m111 sensor core registers"); 619 pr_info("Dumping the mt9m111 sensor core registers\n");
618 value[1] = MT9M111_SENSOR_CORE; 620 value[1] = MT9M111_SENSOR_CORE;
619 m5602_write_sensor(sd, MT9M111_PAGE_MAP, value, 2); 621 m5602_write_sensor(sd, MT9M111_PAGE_MAP, value, 2);
620 for (address = 0; address < 0xff; address++) { 622 for (address = 0; address < 0xff; address++) {
621 m5602_read_sensor(sd, address, value, 2); 623 m5602_read_sensor(sd, address, value, 2);
622 info("register 0x%x contains 0x%x%x", 624 pr_info("register 0x%x contains 0x%x%x\n",
623 address, value[0], value[1]); 625 address, value[0], value[1]);
624 } 626 }
625 627
626 info("Dumping the mt9m111 color pipeline registers"); 628 pr_info("Dumping the mt9m111 color pipeline registers\n");
627 value[1] = MT9M111_COLORPIPE; 629 value[1] = MT9M111_COLORPIPE;
628 m5602_write_sensor(sd, MT9M111_PAGE_MAP, value, 2); 630 m5602_write_sensor(sd, MT9M111_PAGE_MAP, value, 2);
629 for (address = 0; address < 0xff; address++) { 631 for (address = 0; address < 0xff; address++) {
630 m5602_read_sensor(sd, address, value, 2); 632 m5602_read_sensor(sd, address, value, 2);
631 info("register 0x%x contains 0x%x%x", 633 pr_info("register 0x%x contains 0x%x%x\n",
632 address, value[0], value[1]); 634 address, value[0], value[1]);
633 } 635 }
634 636
635 info("Dumping the mt9m111 camera control registers"); 637 pr_info("Dumping the mt9m111 camera control registers\n");
636 value[1] = MT9M111_CAMERA_CONTROL; 638 value[1] = MT9M111_CAMERA_CONTROL;
637 m5602_write_sensor(sd, MT9M111_PAGE_MAP, value, 2); 639 m5602_write_sensor(sd, MT9M111_PAGE_MAP, value, 2);
638 for (address = 0; address < 0xff; address++) { 640 for (address = 0; address < 0xff; address++) {
639 m5602_read_sensor(sd, address, value, 2); 641 m5602_read_sensor(sd, address, value, 2);
640 info("register 0x%x contains 0x%x%x", 642 pr_info("register 0x%x contains 0x%x%x\n",
641 address, value[0], value[1]); 643 address, value[0], value[1]);
642 } 644 }
643 645
644 info("mt9m111 register state dump complete"); 646 pr_info("mt9m111 register state dump complete\n");
645} 647}
diff --git a/drivers/media/video/gspca/m5602/m5602_ov7660.c b/drivers/media/video/gspca/m5602/m5602_ov7660.c
index b12f60464b3..9a14835c128 100644
--- a/drivers/media/video/gspca/m5602/m5602_ov7660.c
+++ b/drivers/media/video/gspca/m5602/m5602_ov7660.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include "m5602_ov7660.h" 21#include "m5602_ov7660.h"
20 22
21static int ov7660_get_gain(struct gspca_dev *gspca_dev, __s32 *val); 23static int ov7660_get_gain(struct gspca_dev *gspca_dev, __s32 *val);
@@ -149,7 +151,7 @@ int ov7660_probe(struct sd *sd)
149 151
150 if (force_sensor) { 152 if (force_sensor) {
151 if (force_sensor == OV7660_SENSOR) { 153 if (force_sensor == OV7660_SENSOR) {
152 info("Forcing an %s sensor", ov7660.name); 154 pr_info("Forcing an %s sensor\n", ov7660.name);
153 goto sensor_found; 155 goto sensor_found;
154 } 156 }
155 /* If we want to force another sensor, 157 /* If we want to force another sensor,
@@ -180,10 +182,10 @@ int ov7660_probe(struct sd *sd)
180 if (m5602_read_sensor(sd, OV7660_VER, &ver_id, 1)) 182 if (m5602_read_sensor(sd, OV7660_VER, &ver_id, 1))
181 return -ENODEV; 183 return -ENODEV;
182 184
183 info("Sensor reported 0x%x%x", prod_id, ver_id); 185 pr_info("Sensor reported 0x%x%x\n", prod_id, ver_id);
184 186
185 if ((prod_id == 0x76) && (ver_id == 0x60)) { 187 if ((prod_id == 0x76) && (ver_id == 0x60)) {
186 info("Detected a ov7660 sensor"); 188 pr_info("Detected a ov7660 sensor\n");
187 goto sensor_found; 189 goto sensor_found;
188 } 190 }
189 return -ENODEV; 191 return -ENODEV;
@@ -457,17 +459,16 @@ static int ov7660_set_vflip(struct gspca_dev *gspca_dev, __s32 val)
457static void ov7660_dump_registers(struct sd *sd) 459static void ov7660_dump_registers(struct sd *sd)
458{ 460{
459 int address; 461 int address;
460 info("Dumping the ov7660 register state"); 462 pr_info("Dumping the ov7660 register state\n");
461 for (address = 0; address < 0xa9; address++) { 463 for (address = 0; address < 0xa9; address++) {
462 u8 value; 464 u8 value;
463 m5602_read_sensor(sd, address, &value, 1); 465 m5602_read_sensor(sd, address, &value, 1);
464 info("register 0x%x contains 0x%x", 466 pr_info("register 0x%x contains 0x%x\n", address, value);
465 address, value);
466 } 467 }
467 468
468 info("ov7660 register state dump complete"); 469 pr_info("ov7660 register state dump complete\n");
469 470
470 info("Probing for which registers that are read/write"); 471 pr_info("Probing for which registers that are read/write\n");
471 for (address = 0; address < 0xff; address++) { 472 for (address = 0; address < 0xff; address++) {
472 u8 old_value, ctrl_value; 473 u8 old_value, ctrl_value;
473 u8 test_value[2] = {0xff, 0xff}; 474 u8 test_value[2] = {0xff, 0xff};
@@ -477,9 +478,9 @@ static void ov7660_dump_registers(struct sd *sd)
477 m5602_read_sensor(sd, address, &ctrl_value, 1); 478 m5602_read_sensor(sd, address, &ctrl_value, 1);
478 479
479 if (ctrl_value == test_value[0]) 480 if (ctrl_value == test_value[0])
480 info("register 0x%x is writeable", address); 481 pr_info("register 0x%x is writeable\n", address);
481 else 482 else
482 info("register 0x%x is read only", address); 483 pr_info("register 0x%x is read only\n", address);
483 484
484 /* Restore original value */ 485 /* Restore original value */
485 m5602_write_sensor(sd, address, &old_value, 1); 486 m5602_write_sensor(sd, address, &old_value, 1);
diff --git a/drivers/media/video/gspca/m5602/m5602_ov9650.c b/drivers/media/video/gspca/m5602/m5602_ov9650.c
index 703d48670a2..2114a8b90ec 100644
--- a/drivers/media/video/gspca/m5602/m5602_ov9650.c
+++ b/drivers/media/video/gspca/m5602/m5602_ov9650.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include "m5602_ov9650.h" 21#include "m5602_ov9650.h"
20 22
21static int ov9650_set_exposure(struct gspca_dev *gspca_dev, __s32 val); 23static int ov9650_set_exposure(struct gspca_dev *gspca_dev, __s32 val);
@@ -299,7 +301,7 @@ int ov9650_probe(struct sd *sd)
299 301
300 if (force_sensor) { 302 if (force_sensor) {
301 if (force_sensor == OV9650_SENSOR) { 303 if (force_sensor == OV9650_SENSOR) {
302 info("Forcing an %s sensor", ov9650.name); 304 pr_info("Forcing an %s sensor\n", ov9650.name);
303 goto sensor_found; 305 goto sensor_found;
304 } 306 }
305 /* If we want to force another sensor, 307 /* If we want to force another sensor,
@@ -330,7 +332,7 @@ int ov9650_probe(struct sd *sd)
330 return -ENODEV; 332 return -ENODEV;
331 333
332 if ((prod_id == 0x96) && (ver_id == 0x52)) { 334 if ((prod_id == 0x96) && (ver_id == 0x52)) {
333 info("Detected an ov9650 sensor"); 335 pr_info("Detected an ov9650 sensor\n");
334 goto sensor_found; 336 goto sensor_found;
335 } 337 }
336 return -ENODEV; 338 return -ENODEV;
@@ -850,17 +852,16 @@ static int ov9650_set_auto_gain(struct gspca_dev *gspca_dev, __s32 val)
850static void ov9650_dump_registers(struct sd *sd) 852static void ov9650_dump_registers(struct sd *sd)
851{ 853{
852 int address; 854 int address;
853 info("Dumping the ov9650 register state"); 855 pr_info("Dumping the ov9650 register state\n");
854 for (address = 0; address < 0xa9; address++) { 856 for (address = 0; address < 0xa9; address++) {
855 u8 value; 857 u8 value;
856 m5602_read_sensor(sd, address, &value, 1); 858 m5602_read_sensor(sd, address, &value, 1);
857 info("register 0x%x contains 0x%x", 859 pr_info("register 0x%x contains 0x%x\n", address, value);
858 address, value);
859 } 860 }
860 861
861 info("ov9650 register state dump complete"); 862 pr_info("ov9650 register state dump complete\n");
862 863
863 info("Probing for which registers that are read/write"); 864 pr_info("Probing for which registers that are read/write\n");
864 for (address = 0; address < 0xff; address++) { 865 for (address = 0; address < 0xff; address++) {
865 u8 old_value, ctrl_value; 866 u8 old_value, ctrl_value;
866 u8 test_value[2] = {0xff, 0xff}; 867 u8 test_value[2] = {0xff, 0xff};
@@ -870,9 +871,9 @@ static void ov9650_dump_registers(struct sd *sd)
870 m5602_read_sensor(sd, address, &ctrl_value, 1); 871 m5602_read_sensor(sd, address, &ctrl_value, 1);
871 872
872 if (ctrl_value == test_value[0]) 873 if (ctrl_value == test_value[0])
873 info("register 0x%x is writeable", address); 874 pr_info("register 0x%x is writeable\n", address);
874 else 875 else
875 info("register 0x%x is read only", address); 876 pr_info("register 0x%x is read only\n", address);
876 877
877 /* Restore original value */ 878 /* Restore original value */
878 m5602_write_sensor(sd, address, &old_value, 1); 879 m5602_write_sensor(sd, address, &old_value, 1);
diff --git a/drivers/media/video/gspca/m5602/m5602_po1030.c b/drivers/media/video/gspca/m5602/m5602_po1030.c
index 1febd34c2f0..b8771698cbc 100644
--- a/drivers/media/video/gspca/m5602/m5602_po1030.c
+++ b/drivers/media/video/gspca/m5602/m5602_po1030.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include "m5602_po1030.h" 21#include "m5602_po1030.h"
20 22
21static int po1030_get_exposure(struct gspca_dev *gspca_dev, __s32 *val); 23static int po1030_get_exposure(struct gspca_dev *gspca_dev, __s32 *val);
@@ -197,7 +199,7 @@ int po1030_probe(struct sd *sd)
197 199
198 if (force_sensor) { 200 if (force_sensor) {
199 if (force_sensor == PO1030_SENSOR) { 201 if (force_sensor == PO1030_SENSOR) {
200 info("Forcing a %s sensor", po1030.name); 202 pr_info("Forcing a %s sensor\n", po1030.name);
201 goto sensor_found; 203 goto sensor_found;
202 } 204 }
203 /* If we want to force another sensor, don't try to probe this 205 /* If we want to force another sensor, don't try to probe this
@@ -221,7 +223,7 @@ int po1030_probe(struct sd *sd)
221 return -ENODEV; 223 return -ENODEV;
222 224
223 if (dev_id_h == 0x30) { 225 if (dev_id_h == 0x30) {
224 info("Detected a po1030 sensor"); 226 pr_info("Detected a po1030 sensor\n");
225 goto sensor_found; 227 goto sensor_found;
226 } 228 }
227 return -ENODEV; 229 return -ENODEV;
@@ -267,7 +269,7 @@ int po1030_init(struct sd *sd)
267 break; 269 break;
268 270
269 default: 271 default:
270 info("Invalid stream command, exiting init"); 272 pr_info("Invalid stream command, exiting init\n");
271 return -EINVAL; 273 return -EINVAL;
272 } 274 }
273 } 275 }
@@ -733,16 +735,15 @@ static void po1030_dump_registers(struct sd *sd)
733 int address; 735 int address;
734 u8 value = 0; 736 u8 value = 0;
735 737
736 info("Dumping the po1030 sensor core registers"); 738 pr_info("Dumping the po1030 sensor core registers\n");
737 for (address = 0; address < 0x7f; address++) { 739 for (address = 0; address < 0x7f; address++) {
738 m5602_read_sensor(sd, address, &value, 1); 740 m5602_read_sensor(sd, address, &value, 1);
739 info("register 0x%x contains 0x%x", 741 pr_info("register 0x%x contains 0x%x\n", address, value);
740 address, value);
741 } 742 }
742 743
743 info("po1030 register state dump complete"); 744 pr_info("po1030 register state dump complete\n");
744 745
745 info("Probing for which registers that are read/write"); 746 pr_info("Probing for which registers that are read/write\n");
746 for (address = 0; address < 0xff; address++) { 747 for (address = 0; address < 0xff; address++) {
747 u8 old_value, ctrl_value; 748 u8 old_value, ctrl_value;
748 u8 test_value[2] = {0xff, 0xff}; 749 u8 test_value[2] = {0xff, 0xff};
@@ -752,9 +753,9 @@ static void po1030_dump_registers(struct sd *sd)
752 m5602_read_sensor(sd, address, &ctrl_value, 1); 753 m5602_read_sensor(sd, address, &ctrl_value, 1);
753 754
754 if (ctrl_value == test_value[0]) 755 if (ctrl_value == test_value[0])
755 info("register 0x%x is writeable", address); 756 pr_info("register 0x%x is writeable\n", address);
756 else 757 else
757 info("register 0x%x is read only", address); 758 pr_info("register 0x%x is read only\n", address);
758 759
759 /* Restore original value */ 760 /* Restore original value */
760 m5602_write_sensor(sd, address, &old_value, 1); 761 m5602_write_sensor(sd, address, &old_value, 1);
diff --git a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
index d27280be985..cc8ec3f7e8d 100644
--- a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
+++ b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include "m5602_s5k4aa.h" 21#include "m5602_s5k4aa.h"
20 22
21static int s5k4aa_get_exposure(struct gspca_dev *gspca_dev, __s32 *val); 23static int s5k4aa_get_exposure(struct gspca_dev *gspca_dev, __s32 *val);
@@ -240,7 +242,7 @@ int s5k4aa_probe(struct sd *sd)
240 242
241 if (force_sensor) { 243 if (force_sensor) {
242 if (force_sensor == S5K4AA_SENSOR) { 244 if (force_sensor == S5K4AA_SENSOR) {
243 info("Forcing a %s sensor", s5k4aa.name); 245 pr_info("Forcing a %s sensor\n", s5k4aa.name);
244 goto sensor_found; 246 goto sensor_found;
245 } 247 }
246 /* If we want to force another sensor, don't try to probe this 248 /* If we want to force another sensor, don't try to probe this
@@ -276,7 +278,7 @@ int s5k4aa_probe(struct sd *sd)
276 data, 2); 278 data, 2);
277 break; 279 break;
278 default: 280 default:
279 info("Invalid stream command, exiting init"); 281 pr_info("Invalid stream command, exiting init\n");
280 return -EINVAL; 282 return -EINVAL;
281 } 283 }
282 } 284 }
@@ -292,7 +294,7 @@ int s5k4aa_probe(struct sd *sd)
292 if (memcmp(prod_id, expected_prod_id, sizeof(prod_id))) 294 if (memcmp(prod_id, expected_prod_id, sizeof(prod_id)))
293 return -ENODEV; 295 return -ENODEV;
294 else 296 else
295 info("Detected a s5k4aa sensor"); 297 pr_info("Detected a s5k4aa sensor\n");
296 298
297sensor_found: 299sensor_found:
298 sensor_settings = kmalloc( 300 sensor_settings = kmalloc(
@@ -347,7 +349,7 @@ int s5k4aa_start(struct sd *sd)
347 break; 349 break;
348 350
349 default: 351 default:
350 err("Invalid stream command, exiting init"); 352 pr_err("Invalid stream command, exiting init\n");
351 return -EINVAL; 353 return -EINVAL;
352 } 354 }
353 } 355 }
@@ -383,7 +385,7 @@ int s5k4aa_start(struct sd *sd)
383 break; 385 break;
384 386
385 default: 387 default:
386 err("Invalid stream command, exiting init"); 388 pr_err("Invalid stream command, exiting init\n");
387 return -EINVAL; 389 return -EINVAL;
388 } 390 }
389 } 391 }
@@ -447,7 +449,7 @@ int s5k4aa_init(struct sd *sd)
447 init_s5k4aa[i][1], data, 2); 449 init_s5k4aa[i][1], data, 2);
448 break; 450 break;
449 default: 451 default:
450 info("Invalid stream command, exiting init"); 452 pr_info("Invalid stream command, exiting init\n");
451 return -EINVAL; 453 return -EINVAL;
452 } 454 }
453 } 455 }
@@ -686,20 +688,21 @@ static void s5k4aa_dump_registers(struct sd *sd)
686 m5602_read_sensor(sd, S5K4AA_PAGE_MAP, &old_page, 1); 688 m5602_read_sensor(sd, S5K4AA_PAGE_MAP, &old_page, 1);
687 for (page = 0; page < 16; page++) { 689 for (page = 0; page < 16; page++) {
688 m5602_write_sensor(sd, S5K4AA_PAGE_MAP, &page, 1); 690 m5602_write_sensor(sd, S5K4AA_PAGE_MAP, &page, 1);
689 info("Dumping the s5k4aa register state for page 0x%x", page); 691 pr_info("Dumping the s5k4aa register state for page 0x%x\n",
692 page);
690 for (address = 0; address <= 0xff; address++) { 693 for (address = 0; address <= 0xff; address++) {
691 u8 value = 0; 694 u8 value = 0;
692 m5602_read_sensor(sd, address, &value, 1); 695 m5602_read_sensor(sd, address, &value, 1);
693 info("register 0x%x contains 0x%x", 696 pr_info("register 0x%x contains 0x%x\n",
694 address, value); 697 address, value);
695 } 698 }
696 } 699 }
697 info("s5k4aa register state dump complete"); 700 pr_info("s5k4aa register state dump complete\n");
698 701
699 for (page = 0; page < 16; page++) { 702 for (page = 0; page < 16; page++) {
700 m5602_write_sensor(sd, S5K4AA_PAGE_MAP, &page, 1); 703 m5602_write_sensor(sd, S5K4AA_PAGE_MAP, &page, 1);
701 info("Probing for which registers that are " 704 pr_info("Probing for which registers that are read/write for page 0x%x\n",
702 "read/write for page 0x%x", page); 705 page);
703 for (address = 0; address <= 0xff; address++) { 706 for (address = 0; address <= 0xff; address++) {
704 u8 old_value, ctrl_value, test_value = 0xff; 707 u8 old_value, ctrl_value, test_value = 0xff;
705 708
@@ -708,14 +711,16 @@ static void s5k4aa_dump_registers(struct sd *sd)
708 m5602_read_sensor(sd, address, &ctrl_value, 1); 711 m5602_read_sensor(sd, address, &ctrl_value, 1);
709 712
710 if (ctrl_value == test_value) 713 if (ctrl_value == test_value)
711 info("register 0x%x is writeable", address); 714 pr_info("register 0x%x is writeable\n",
715 address);
712 else 716 else
713 info("register 0x%x is read only", address); 717 pr_info("register 0x%x is read only\n",
718 address);
714 719
715 /* Restore original value */ 720 /* Restore original value */
716 m5602_write_sensor(sd, address, &old_value, 1); 721 m5602_write_sensor(sd, address, &old_value, 1);
717 } 722 }
718 } 723 }
719 info("Read/write register probing complete"); 724 pr_info("Read/write register probing complete\n");
720 m5602_write_sensor(sd, S5K4AA_PAGE_MAP, &old_page, 1); 725 m5602_write_sensor(sd, S5K4AA_PAGE_MAP, &old_page, 1);
721} 726}
diff --git a/drivers/media/video/gspca/m5602/m5602_s5k83a.c b/drivers/media/video/gspca/m5602/m5602_s5k83a.c
index fbd91545497..1de743a02b0 100644
--- a/drivers/media/video/gspca/m5602/m5602_s5k83a.c
+++ b/drivers/media/video/gspca/m5602/m5602_s5k83a.c
@@ -16,6 +16,8 @@
16 * 16 *
17 */ 17 */
18 18
19#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
19#include <linux/kthread.h> 21#include <linux/kthread.h>
20#include "m5602_s5k83a.h" 22#include "m5602_s5k83a.h"
21 23
@@ -135,7 +137,7 @@ int s5k83a_probe(struct sd *sd)
135 137
136 if (force_sensor) { 138 if (force_sensor) {
137 if (force_sensor == S5K83A_SENSOR) { 139 if (force_sensor == S5K83A_SENSOR) {
138 info("Forcing a %s sensor", s5k83a.name); 140 pr_info("Forcing a %s sensor\n", s5k83a.name);
139 goto sensor_found; 141 goto sensor_found;
140 } 142 }
141 /* If we want to force another sensor, don't try to probe this 143 /* If we want to force another sensor, don't try to probe this
@@ -168,7 +170,7 @@ int s5k83a_probe(struct sd *sd)
168 if ((prod_id == 0xff) || (ver_id == 0xff)) 170 if ((prod_id == 0xff) || (ver_id == 0xff))
169 return -ENODEV; 171 return -ENODEV;
170 else 172 else
171 info("Detected a s5k83a sensor"); 173 pr_info("Detected a s5k83a sensor\n");
172 174
173sensor_found: 175sensor_found:
174 sens_priv = kmalloc( 176 sens_priv = kmalloc(
@@ -227,7 +229,7 @@ int s5k83a_init(struct sd *sd)
227 init_s5k83a[i][1], data, 2); 229 init_s5k83a[i][1], data, 2);
228 break; 230 break;
229 default: 231 default:
230 info("Invalid stream command, exiting init"); 232 pr_info("Invalid stream command, exiting init\n");
231 return -EINVAL; 233 return -EINVAL;
232 } 234 }
233 } 235 }
@@ -273,7 +275,7 @@ static int rotation_thread_function(void *data)
273 s5k83a_get_rotation(sd, &reg); 275 s5k83a_get_rotation(sd, &reg);
274 if (previous_rotation != reg) { 276 if (previous_rotation != reg) {
275 previous_rotation = reg; 277 previous_rotation = reg;
276 info("Camera was flipped"); 278 pr_info("Camera was flipped\n");
277 279
278 s5k83a_get_vflip((struct gspca_dev *) sd, &vflip); 280 s5k83a_get_vflip((struct gspca_dev *) sd, &vflip);
279 s5k83a_get_hflip((struct gspca_dev *) sd, &hflip); 281 s5k83a_get_hflip((struct gspca_dev *) sd, &hflip);
@@ -566,20 +568,20 @@ static void s5k83a_dump_registers(struct sd *sd)
566 568
567 for (page = 0; page < 16; page++) { 569 for (page = 0; page < 16; page++) {
568 m5602_write_sensor(sd, S5K83A_PAGE_MAP, &page, 1); 570 m5602_write_sensor(sd, S5K83A_PAGE_MAP, &page, 1);
569 info("Dumping the s5k83a register state for page 0x%x", page); 571 pr_info("Dumping the s5k83a register state for page 0x%x\n",
572 page);
570 for (address = 0; address <= 0xff; address++) { 573 for (address = 0; address <= 0xff; address++) {
571 u8 val = 0; 574 u8 val = 0;
572 m5602_read_sensor(sd, address, &val, 1); 575 m5602_read_sensor(sd, address, &val, 1);
573 info("register 0x%x contains 0x%x", 576 pr_info("register 0x%x contains 0x%x\n", address, val);
574 address, val);
575 } 577 }
576 } 578 }
577 info("s5k83a register state dump complete"); 579 pr_info("s5k83a register state dump complete\n");
578 580
579 for (page = 0; page < 16; page++) { 581 for (page = 0; page < 16; page++) {
580 m5602_write_sensor(sd, S5K83A_PAGE_MAP, &page, 1); 582 m5602_write_sensor(sd, S5K83A_PAGE_MAP, &page, 1);
581 info("Probing for which registers that are read/write " 583 pr_info("Probing for which registers that are read/write for page 0x%x\n",
582 "for page 0x%x", page); 584 page);
583 for (address = 0; address <= 0xff; address++) { 585 for (address = 0; address <= 0xff; address++) {
584 u8 old_val, ctrl_val, test_val = 0xff; 586 u8 old_val, ctrl_val, test_val = 0xff;
585 587
@@ -588,14 +590,16 @@ static void s5k83a_dump_registers(struct sd *sd)
588 m5602_read_sensor(sd, address, &ctrl_val, 1); 590 m5602_read_sensor(sd, address, &ctrl_val, 1);
589 591
590 if (ctrl_val == test_val) 592 if (ctrl_val == test_val)
591 info("register 0x%x is writeable", address); 593 pr_info("register 0x%x is writeable\n",
594 address);
592 else 595 else
593 info("register 0x%x is read only", address); 596 pr_info("register 0x%x is read only\n",
597 address);
594 598
595 /* Restore original val */ 599 /* Restore original val */
596 m5602_write_sensor(sd, address, &old_val, 1); 600 m5602_write_sensor(sd, address, &old_val, 1);
597 } 601 }
598 } 602 }
599 info("Read/write register probing complete"); 603 pr_info("Read/write register probing complete\n");
600 m5602_write_sensor(sd, S5K83A_PAGE_MAP, &old_page, 1); 604 m5602_write_sensor(sd, S5K83A_PAGE_MAP, &old_page, 1);
601} 605}