aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/cx88/cx88-dvb.c
diff options
context:
space:
mode:
authorTrent Piepho <xyzzy@speakeasy.org>2007-08-15 13:41:59 -0400
committerMauro Carvalho Chehab <mchehab@infradead.org>2007-10-09 21:05:17 -0400
commit5772f81326904f2bfbb2bf2f365b3fb36ee3b7d8 (patch)
tree04ac6ac3478ddd9d5692ba44ae92d8bed81fe51f /drivers/media/video/cx88/cx88-dvb.c
parentbbc83597dfe3093b161014e6ebb351279eabaa7c (diff)
V4L/DVB (6023): cx88: Clean up some ugly and inconsistent printk()s
Get rid of the "CORE" prefix from cx88 printks. It was only used a few times, and it makes it look like they're coming from the kernel core or something. Fix the message, "TV tuner 60 at 0x1fe, Radio tuner -1 at 0x1fe", by adding a "cx88[0]" prefix to be consistent, and to keep people who grep their dmesg output for cx88 from missing it. Get rid of the addresses, which are always wrong. The addresses are always set to -1, but because it's an unsigned 8-bit value, the left shift converts it to the nonsense address 0x1fe. In the cx8802 driver, some cut and pasted code prefixed lines with "CORE cx88[0]:", which has been changed to "cx88[0]/2:" like the other printks from the cx8802 driver. Also fix some ugly printks in the cx8802 driver that used __FUNCTION__ for KERN_INFO and KERN_ERR messages. The changed printks in cx88-mpeg.c also needed lots of whitespace and 80-column fixes. A bunch of misc changes in cx88-dvb.c and cx88-video.c to add message levels or a consistent "cx88[?]/2" or "cx88[?]/0" prefix. Signed-off-by: Trent Piepho <xyzzy@speakeasy.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'drivers/media/video/cx88/cx88-dvb.c')
-rw-r--r--drivers/media/video/cx88/cx88-dvb.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index d98b9072101..00d0e43785a 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -482,7 +482,7 @@ static int dvb_register(struct cx8802_dev *dev)
482 &dev->core->i2c_adap, DVB_PLL_FMD1216ME); 482 &dev->core->i2c_adap, DVB_PLL_FMD1216ME);
483 } 483 }
484#else 484#else
485 printk("%s: built without vp3054 support\n", dev->core->name); 485 printk(KERN_ERR "%s/2: built without vp3054 support\n", dev->core->name);
486#endif 486#endif
487 break; 487 break;
488 case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_HYBRID: 488 case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_HYBRID:
@@ -625,12 +625,12 @@ static int dvb_register(struct cx8802_dev *dev)
625 } 625 }
626 break; 626 break;
627 default: 627 default:
628 printk("%s: The frontend of your DVB/ATSC card isn't supported yet\n", 628 printk(KERN_ERR "%s/2: The frontend of your DVB/ATSC card isn't supported yet\n",
629 dev->core->name); 629 dev->core->name);
630 break; 630 break;
631 } 631 }
632 if (NULL == dev->dvb.frontend) { 632 if (NULL == dev->dvb.frontend) {
633 printk("%s: frontend initialization failed\n",dev->core->name); 633 printk(KERN_ERR "%s/2: frontend initialization failed\n", dev->core->name);
634 return -1; 634 return -1;
635 } 635 }
636 636
@@ -709,7 +709,7 @@ static int cx8802_dvb_probe(struct cx8802_driver *drv)
709 goto fail_core; 709 goto fail_core;
710 710
711 /* dvb stuff */ 711 /* dvb stuff */
712 printk("%s/2: cx2388x based dvb card\n", core->name); 712 printk(KERN_INFO "%s/2: cx2388x based DVB/ATSC card\n", core->name);
713 videobuf_queue_init(&dev->dvb.dvbq, &dvb_qops, 713 videobuf_queue_init(&dev->dvb.dvbq, &dvb_qops,
714 dev->pci, &dev->slock, 714 dev->pci, &dev->slock,
715 V4L2_BUF_TYPE_VIDEO_CAPTURE, 715 V4L2_BUF_TYPE_VIDEO_CAPTURE,
@@ -718,7 +718,8 @@ static int cx8802_dvb_probe(struct cx8802_driver *drv)
718 dev); 718 dev);
719 err = dvb_register(dev); 719 err = dvb_register(dev);
720 if (err != 0) 720 if (err != 0)
721 printk("%s dvb_register failed err = %d\n", __FUNCTION__, err); 721 printk(KERN_ERR "%s/2: dvb_register failed (err = %d)\n",
722 core->name, err);
722 723
723 fail_core: 724 fail_core:
724 return err; 725 return err;
@@ -747,7 +748,7 @@ static struct cx8802_driver cx8802_dvb_driver = {
747 748
748static int dvb_init(void) 749static int dvb_init(void)
749{ 750{
750 printk(KERN_INFO "cx2388x dvb driver version %d.%d.%d loaded\n", 751 printk(KERN_INFO "cx88/2: cx2388x dvb driver version %d.%d.%d loaded\n",
751 (CX88_VERSION_CODE >> 16) & 0xff, 752 (CX88_VERSION_CODE >> 16) & 0xff,
752 (CX88_VERSION_CODE >> 8) & 0xff, 753 (CX88_VERSION_CODE >> 8) & 0xff,
753 CX88_VERSION_CODE & 0xff); 754 CX88_VERSION_CODE & 0xff);